mirror of
https://github.com/torvalds/linux
synced 2024-10-28 06:09:03 +00:00
df877fb3f5
The local array feature[] is in the stack. We can see the warning when we enable the CONFIG_DMA_API_DEBUG: ---------------------------------------------------------- WARNING: at lib/dma-debug.c:950 check_for_stack+0xac/0xf8() gpmi-nand 112000.gpmi-nand: DMA-API: device driver maps memory fromstack [addr=dc05be34] Modules linked in: CPU: 0 PID: 1 Comm: swapper/0 Not tainted 3.10.17-16851-g2414a73 #1324 [<80014cbc>] (unwind_backtrace+0x0/0x138) from [<8001251c>] (show_stack+0x10/0x14) [<8001251c>] (show_stack+0x10/0x14) from [<8002699c>] (warn_slowpath_common+0x4c/0x68) [<8002699c>] (warn_slowpath_common+0x4c/0x68) from [<80026a4c>] (warn_slowpath_fmt+0x30/0x40) [<80026a4c>] (warn_slowpath_fmt+0x30/0x40) from [<8028e2f8>] (check_for_stack+0xac/0xf8) [<8028e2f8>] (check_for_stack+0xac/0xf8) from [<8028e438>] (debug_dma_map_sg+0xf4/0x188) [<8028e438>] (debug_dma_map_sg+0xf4/0x188) from [<803968d0>] (prepare_data_dma+0xb8/0x1a8) [<803968d0>] (prepare_data_dma+0xb8/0x1a8) from [<80397b20>] (gpmi_send_data+0x84/0xfc) [<80397b20>] (gpmi_send_data+0x84/0xfc) from [<8038c2b4>] (nand_onfi_set_features+0x50/0x74) [<8038c2b4>] (nand_onfi_set_features+0x50/0x74) from [<80397198>] (gpmi_extra_init+0x90/0x170) [<80397198>] (gpmi_extra_init+0x90/0x170) from [<8039520c>] (gpmi_nand_probe+0x2f8/0xb3c) [<8039520c>] (gpmi_nand_probe+0x2f8/0xb3c) from [<8031b974>] (platform_drv_probe+0x18/0x1c) ---------------------------------------------------------- The patch uses the kzalloc to allocate the buffer, and free it when we do not use it anymore. Signed-off-by: Huang Shijie <b32955@freescale.com> Signed-off-by: Brian Norris <computersforpeace@gmail.com> |
||
|---|---|---|
| .. | ||
| bcm47xxnflash | ||
| gpmi-nand | ||
| ams-delta.c | ||
| atmel_nand.c | ||
| atmel_nand_ecc.h | ||
| atmel_nand_nfc.h | ||
| au1550nd.c | ||
| bf5xx_nand.c | ||
| cafe_nand.c | ||
| cmx270_nand.c | ||
| cs553x_nand.c | ||
| davinci_nand.c | ||
| denali.c | ||
| denali.h | ||
| denali_dt.c | ||
| denali_pci.c | ||
| diskonchip.c | ||
| docg4.c | ||
| fsl_elbc_nand.c | ||
| fsl_ifc_nand.c | ||
| fsl_upm.c | ||
| fsmc_nand.c | ||
| gpio.c | ||
| jz4740_nand.c | ||
| Kconfig | ||
| lpc32xx_mlc.c | ||
| lpc32xx_slc.c | ||
| Makefile | ||
| mpc5121_nfc.c | ||
| mxc_nand.c | ||
| nand_base.c | ||
| nand_bbt.c | ||
| nand_bch.c | ||
| nand_ecc.c | ||
| nand_ids.c | ||
| nandsim.c | ||
| ndfc.c | ||
| nuc900_nand.c | ||
| omap2.c | ||
| orion_nand.c | ||
| pasemi_nand.c | ||
| plat_nand.c | ||
| pxa3xx_nand.c | ||
| r852.c | ||
| r852.h | ||
| s3c2410.c | ||
| sh_flctl.c | ||
| sharpsl.c | ||
| sm_common.c | ||
| sm_common.h | ||
| socrates_nand.c | ||
| tmio_nand.c | ||
| txx9ndfmc.c | ||
| xway_nand.c | ||