Eryu Guan ec572b9e81 nfsd4: define nfsd4_secinfo_no_name_release() ... Commit 34b1744c91 ("nfsd4: define ->op_release for compound ops") defined a couple ->op_release functions and run them if necessary. But there's a problem with that is that it reused nfsd4_secinfo_release() as the op_release of OP_SECINFO_NO_NAME, and caused a leak on struct nfsd4_secinfo_no_name in nfsd4_encode_secinfo_no_name(), because there's no .si_exp field in struct nfsd4_secinfo_no_name. I found this because I was unable to umount an ext4 partition after exporting it via NFS & run fsstress on the nfs mount. A simplified reproducer would be: # mount a local-fs device at /mnt/test, and export it via NFS with # fsid=0 export option (this is required) mount /dev/sda5 /mnt/test echo "/mnt/test *(rw,no_root_squash,fsid=0)" >> /etc/exports service nfs restart # locally mount the nfs export with all default, note that I have # nfsv4.1 configured as the default nfs version, because of the # fsid export option, v4 mount would fail and fall back to v3 mount localhost:/mnt/test /mnt/nfs # try to umount the underlying device, but got EBUSY umount /mnt/nfs service nfs stop umount /mnt/test <=== EBUSY here Fixed it by defining a separate nfsd4_secinfo_no_name_release() function as the op_release method of OP_SECINFO_NO_NAME that releases the correct nfsd4_secinfo_no_name structure. Fixes: 34b1744c91 ("nfsd4: define ->op_release for compound ops") Signed-off-by: Eryu Guan <eguan@redhat.com> Signed-off-by: J. Bruce Fields <bfields@redhat.com>		2017-10-05 14:45:25 -04:00
..
acl.h
auth.c
auth.h
blocklayout.c	block: Make most scsi_req_init() calls implicit	2017-06-20 19:27:14 -06:00
blocklayoutxdr.c
blocklayoutxdr.h
cache.h
current_stateid.h
export.c
export.h
fault_inject.c
flexfilelayout.c
flexfilelayoutxdr.c
flexfilelayoutxdr.h
idmap.h
Kconfig
lockd.c
Makefile
netns.h
nfs2acl.c
nfs3acl.c
nfs3proc.c
nfs3xdr.c	nfsd4: factor ctime into change attribute	2017-07-12 15:55:00 -04:00
nfs4acl.c
nfs4callback.c	nfsd: Fix a memory scribble in the callback channel	2017-07-17 13:15:06 -04:00
nfs4idmap.c
nfs4layouts.c
nfs4proc.c	nfsd4: define nfsd4_secinfo_no_name_release()	2017-10-05 14:45:25 -04:00
nfs4recover.c
nfs4state.c
nfs4xdr.c	nfsd: Incoming xdr_bufs may have content in tail buffer	2017-09-05 15:15:29 -04:00
nfscache.c
nfsctl.c
nfsd.h
nfsfh.c
nfsfh.h	nfsd4: factor ctime into change attribute	2017-07-12 15:55:00 -04:00
nfsproc.c
nfssvc.c	sunrpc: Const-ify struct sv_serv_ops	2017-08-24 22:13:50 -04:00
nfsxdr.c	Linux 4.12-rc5	2017-06-28 13:34:15 -04:00
pnfs.h
state.h
stats.c
stats.h
trace.c
trace.h
vfs.c	annotate RWF_... flags	2017-08-31 17:32:38 -04:00
vfs.h
xdr.h
xdr3.h
xdr4.h	nfsd: Incoming xdr_bufs may have content in tail buffer	2017-09-05 15:15:29 -04:00
xdr4cb.h