mirror of
https://github.com/torvalds/linux
synced 2024-11-05 18:23:50 +00:00
1e2c2a4fe4
The header files could not be build indepdent from each other. This is happened because headers didn't include the files for things they've used. This was problematic because the success of a build depended on the knowledge about the right order of local includes. Also source files were not including everything they've used explicitly. Instead they required that transitive includes are always stable. This is problematic because some transitive includes are not obvious, depend on config settings and may not be stable in the future. The order for include blocks are: * primary headers (main.h and the *.h file of a *.c file) * global linux headers * required local headers * extra forward declarations for pointers in function/struct declarations The only exceptions are linux/bitops.h and linux/if_ether.h in packet.h. This header file is shared with userspace applications like batctl and must therefore build together with userspace applications. The header linux/bitops.h is not part of the uapi headers and linux/if_ether.h conflicts with the musl implementation of netinet/if_ether.h. The maintainers rejected the use of __KERNEL__ preprocessor checks and thus these two headers are only in main.h. All files using packet.h first have to include main.h to work correctly. Reported-by: Markus Pargmann <mpa@pengutronix.de> Signed-off-by: Sven Eckelmann <sven@narfation.org> Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
71 lines
1.7 KiB
C
71 lines
1.7 KiB
C
/* Copyright (C) 2010-2015 B.A.T.M.A.N. contributors:
|
|
*
|
|
* Marek Lindner
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of version 2 of the GNU General Public
|
|
* License as published by the Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope that it will be useful, but
|
|
* WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#ifndef _NET_BATMAN_ADV_DEBUGFS_H_
|
|
#define _NET_BATMAN_ADV_DEBUGFS_H_
|
|
|
|
#include "main.h"
|
|
|
|
#include <linux/kconfig.h>
|
|
|
|
struct batadv_hard_iface;
|
|
struct net_device;
|
|
|
|
#define BATADV_DEBUGFS_SUBDIR "batman_adv"
|
|
|
|
#if IS_ENABLED(CONFIG_DEBUG_FS)
|
|
|
|
void batadv_debugfs_init(void);
|
|
void batadv_debugfs_destroy(void);
|
|
int batadv_debugfs_add_meshif(struct net_device *dev);
|
|
void batadv_debugfs_del_meshif(struct net_device *dev);
|
|
int batadv_debugfs_add_hardif(struct batadv_hard_iface *hard_iface);
|
|
void batadv_debugfs_del_hardif(struct batadv_hard_iface *hard_iface);
|
|
|
|
#else
|
|
|
|
static inline void batadv_debugfs_init(void)
|
|
{
|
|
}
|
|
|
|
static inline void batadv_debugfs_destroy(void)
|
|
{
|
|
}
|
|
|
|
static inline int batadv_debugfs_add_meshif(struct net_device *dev)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static inline void batadv_debugfs_del_meshif(struct net_device *dev)
|
|
{
|
|
}
|
|
|
|
static inline
|
|
int batadv_debugfs_add_hardif(struct batadv_hard_iface *hard_iface)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static inline
|
|
void batadv_debugfs_del_hardif(struct batadv_hard_iface *hard_iface)
|
|
{
|
|
}
|
|
|
|
#endif
|
|
|
|
#endif /* _NET_BATMAN_ADV_DEBUGFS_H_ */
|