mirror of
https://github.com/torvalds/linux
synced 2024-07-21 10:41:44 +00:00
8a2b456665
It is permissible for kernel code to call virt_to_phys() against virtual
addresses that are in KSEG0 or KSEG1 and we need to be dealing with both
types. Rewrite the test condition to ensure that the kernel virtual
addresses are above PAGE_OFFSET which they must be, and below KSEG2
where the non-linear mapping starts.
For EVA, there is not much that we can do given the linear address range
that is offered, so just return any virtual address as being valid.
Finally, when HIGHMEM is not enabled, all virtual addresses are assumed
to be valid as well.
Fixes: dfad83cb71 ("MIPS: Add support for CONFIG_DEBUG_VIRTUAL")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Serge Semin <fancer.lancer@gmail.com>
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
51 lines
1.3 KiB
C
51 lines
1.3 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
#include <linux/bug.h>
|
|
#include <linux/export.h>
|
|
#include <linux/types.h>
|
|
#include <linux/mmdebug.h>
|
|
#include <linux/mm.h>
|
|
|
|
#include <asm/addrspace.h>
|
|
#include <asm/sections.h>
|
|
#include <asm/io.h>
|
|
#include <asm/page.h>
|
|
#include <asm/dma.h>
|
|
|
|
static inline bool __debug_virt_addr_valid(unsigned long x)
|
|
{
|
|
/*
|
|
* MAX_DMA_ADDRESS is a virtual address that may not correspond to an
|
|
* actual physical address. Enough code relies on
|
|
* virt_to_phys(MAX_DMA_ADDRESS) that we just need to work around it
|
|
* and always return true.
|
|
*/
|
|
if (x == MAX_DMA_ADDRESS)
|
|
return true;
|
|
|
|
return x >= PAGE_OFFSET && (KSEGX(x) < KSEG2 ||
|
|
IS_ENABLED(CONFIG_EVA) ||
|
|
!IS_ENABLED(CONFIG_HIGHMEM));
|
|
}
|
|
|
|
phys_addr_t __virt_to_phys(volatile const void *x)
|
|
{
|
|
WARN(!__debug_virt_addr_valid((unsigned long)x),
|
|
"virt_to_phys used for non-linear address: %pK (%pS)\n",
|
|
x, x);
|
|
|
|
return __virt_to_phys_nodebug(x);
|
|
}
|
|
EXPORT_SYMBOL(__virt_to_phys);
|
|
|
|
phys_addr_t __phys_addr_symbol(unsigned long x)
|
|
{
|
|
/* This is bounds checking against the kernel image only.
|
|
* __pa_symbol should only be used on kernel symbol addresses.
|
|
*/
|
|
VIRTUAL_BUG_ON(x < (unsigned long)_text ||
|
|
x > (unsigned long)_end);
|
|
|
|
return __pa_symbol_nodebug(x);
|
|
}
|
|
EXPORT_SYMBOL(__phys_addr_symbol);
|