Namhyung Kim d50bf78ff6 perf ui/gtk: Fix segmentation fault on perf_hpp__for_each_format loop ... The commit 2b8bfa6bb8 ("perf tools: Centralize default columns init in perf_hpp__init") moves initialization of common overhead column to perf_hpp__init() but forgot about the gtk code. So the gtk code added the same column to the list twice causing infinite loop when iterating it by perf_hpp__for_each_format loop. When I run perf report --gtk, I can see following messages indefinitely. (perf:11687): Gtk-CRITICAL **: IA__gtk_main_quit: assertion 'main_loops != NULL' failed perf: Segmentation fault Signed-off-by: Namhyung Kim <namhyung@kernel.org> Reviewed-by: Pekka Enberg <penberg@kernel.org> Cc: Andi Kleen <andi@firstfloor.org> Cc: Christoph Hellwig <hch@infradead.org> Cc: Ingo Molnar <mingo@kernel.org> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Paul Mackerras <paulus@samba.org> Cc: Pekka Enberg <penberg@kernel.org> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Link: http://lkml.kernel.org/r/1375766056-19377-2-git-send-email-namhyung@kernel.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>		2013-08-07 17:35:39 -03:00
..
annotate.c	perf annotate/gtk: Support event group view on GTK	2013-03-15 13:06:07 -03:00
browser.c	perf ui/gtk: Factor out common browser routines	2013-01-24 16:40:16 -03:00
gtk.h	perf gtk/annotate: Support multiple event annotation	2013-02-14 14:59:28 -03:00
helpline.c	perf ui/helpline: Introduce ui_helpline__vshow()	2012-12-09 08:46:04 -03:00
hists.c	perf ui/gtk: Fix segmentation fault on perf_hpp__for_each_format loop	2013-08-07 17:35:39 -03:00
progress.c	perf ui: Add ui_progress__finish()	2012-11-14 16:52:56 -03:00
setup.c	perf ui gtk: Implement ui_progress functions	2012-11-14 16:52:48 -03:00
util.c	perf ui: Introduce generic ui_progress helper	2012-11-14 16:52:39 -03:00