linux/drivers/net/vmxnet3
Neil Horman 1c4d5f51a8 vmxnet3: ensure that adapter is in proper state during force_close
There are several paths in vmxnet3, where settings changes cause the
adapter to be brought down and back up (vmxnet3_set_ringparam among
them).  Should part of the reset operation fail, these paths call
vmxnet3_force_close, which enables all napi instances prior to calling
dev_close (with the expectation that vmxnet3_close will then properly
disable them again).  However, vmxnet3_force_close neglects to clear
VMXNET3_STATE_BIT_QUIESCED prior to calling dev_close.  As a result
vmxnet3_quiesce_dev (called from vmxnet3_close), returns early, and
leaves all the napi instances in a enabled state while the device itself
is closed.  If a device in this state is activated again, napi_enable
will be called on already enabled napi_instances, leading to a BUG halt.

The fix is to simply enausre that the QUIESCED bit is cleared in
vmxnet3_force_close to allow quesence to be completed properly on close.

Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
CC: Shrikrishna Khare <skhare@vmware.com>
CC: "VMware, Inc." <pv-drivers@vmware.com>
CC: "David S. Miller" <davem@davemloft.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
2017-05-12 12:23:52 -04:00
..
Makefile vmxnet3: prepare for version 3 changes 2016-06-16 22:37:04 -07:00
upt1_defs.h vmxnet3: prepare for version 3 changes 2016-06-16 22:37:04 -07:00
vmxnet3_defs.h vmxnet3: introduce command to register memory region 2016-06-16 22:37:05 -07:00
vmxnet3_drv.c vmxnet3: ensure that adapter is in proper state during force_close 2017-05-12 12:23:52 -04:00
vmxnet3_ethtool.c net: vmxnet3: use new api ethtool_{get|set}_link_ksettings 2017-03-22 19:26:52 -07:00
vmxnet3_int.h net: make ndo_get_stats64 a void function 2017-01-08 17:51:44 -05:00