system/linux
system/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux synced 2024-10-08 12:22:38 +00:00
Code Issues Packages Projects Releases Wiki Activity
linux/drivers/pinctrl/samsung
History
Krzysztof Kozlowski cee7413d84 pinctrl: samsung: Fix NULL pointer exception on external interrupts on S3C24xx 
After commit 8b1bd11c1f ("pinctrl: samsung: Add the support the
multiple IORESOURCE_MEM for one pin-bank"), the S3C24xx (and probably
S3C64xx as well) fails:

	Unable to handle kernel NULL pointer dereference at virtual address 000000a8
	...
	(s3c24xx_demux_eint4_7) from [<c004469c>] (__handle_domain_irq+0x6c/0xcc)
	(__handle_domain_irq) from [<c0009444>] (s3c24xx_handle_irq+0x6c/0x12c)
	(s3c24xx_handle_irq) from [<c000e5fc>] (__irq_svc+0x5c/0x78)

Mentioned commit moved the pointer to controller's base IO memory address
from each controller's driver data (samsung_pinctrl_drv_data) to per-bank
structure (samsung_pin_bank).  The external interrupt demux
handlers (s3c24xx_demux_eint()) tried to get this base address from opaque
pointer stored under irq_chip data:

	struct irq_data *irqd = irq_desc_get_irq_data(desc);
	struct samsung_pin_bank *bank = irq_data_get_irq_chip_data(irqd);
	...
	pend = readl(bank->eint_base + EINTPEND_REG);

which is wrong because this is hardware irq and it bank was never set
for this irq_chip.

For S3C24xx and S3C64xx, this partially reverts mentioned commit by
bringing back the virt_base stored under each controller's driver data
(samsung_pinctrl_drv_data).  This virt_base address will be now
duplicated:
 - samsung_pinctrl_drv_data->virt_base: used on S3C24xx and S3C64xx,
 - samsung_pin_bank->pctl_base: used on Exynos.

Fixes: 8b1bd11c1f ("pinctrl: samsung: Add the support the multiple IORESOURCE_MEM for one pin-bank")
Cc: <stable@vger.kernel.org>
Cc: Sergio Prado <sergio.prado@e-labworks.com>
Reported-by: Sergio Prado <sergio.prado@e-labworks.com>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Tested-by: Lihua Yao <ylhuajnu@163.com>
2017-07-18 18:09:05 +02:00
..
Kconfig pinctrl: samsung: Split Exynos drivers per ARMv7 and ARMv8 2017-06-07 20:40:47 +02:00
Makefile pinctrl: samsung: Split Exynos drivers per ARMv7 and ARMv8 2017-06-07 20:40:47 +02:00
pinctrl-exynos-arm.c pinctrl: samsung: Explicitly cast pointer returned by of_iomap() to iomem 2017-06-07 20:40:48 +02:00
pinctrl-exynos-arm64.c pinctrl: samsung: Split Exynos drivers per ARMv7 and ARMv8 2017-06-07 20:40:47 +02:00
pinctrl-exynos.c pinctrl: samsung: Remove bogus irq_[un]mask from resource management 2017-06-30 15:51:42 +02:00
pinctrl-exynos.h pinctrl: samsung: Split Exynos drivers per ARMv7 and ARMv8 2017-06-07 20:40:47 +02:00
pinctrl-exynos5440.c pinctrl: samsung: Clean up modular vs. non-modular distinctions 2017-05-23 16:49:17 +02:00
pinctrl-s3c24xx.c pinctrl: samsung: Fix NULL pointer exception on external interrupts on S3C24xx 2017-07-18 18:09:05 +02:00
pinctrl-s3c64xx.c pinctrl: samsung: Fix NULL pointer exception on external interrupts on S3C24xx 2017-07-18 18:09:05 +02:00
pinctrl-samsung.c pinctrl: samsung: Fix NULL pointer exception on external interrupts on S3C24xx 2017-07-18 18:09:05 +02:00
pinctrl-samsung.h pinctrl: samsung: Fix NULL pointer exception on external interrupts on S3C24xx 2017-07-18 18:09:05 +02:00