mirror of
https://github.com/torvalds/linux
synced 2024-10-24 12:17:07 +00:00
457f218095
The current uaccess code uses a page table walk in some circumstances,
e.g. in case of the in atomic futex operations or if running on old
hardware which doesn't support the mvcos instruction.
However it turned out that the page table walk code does not correctly
lock page tables when accessing page table entries.
In other words: a different cpu may invalidate a page table entry while
the current cpu inspects the pte. This may lead to random data corruption.
Adding correct locking however isn't trivial for all uaccess operations.
Especially copy_in_user() is problematic since that requires to hold at
least two locks, but must be protected against ABBA deadlock when a
different cpu also performs a copy_in_user() operation.
So the solution is a different approach where we change address spaces:
User space runs in primary address mode, or access register mode within
vdso code, like it currently already does.
The kernel usually also runs in home space mode, however when accessing
user space the kernel switches to primary or secondary address mode if
the mvcos instruction is not available or if a compare-and-swap (futex)
instruction on a user space address is performed.
KVM however is special, since that requires the kernel to run in home
address space while implicitly accessing user space with the sie
instruction.
So we end up with:
User space:
- runs in primary or access register mode
- cr1 contains the user asce
- cr7 contains the user asce
- cr13 contains the kernel asce
Kernel space:
- runs in home space mode
- cr1 contains the user or kernel asce
-> the kernel asce is loaded when a uaccess requires primary or
secondary address mode
- cr7 contains the user or kernel asce, (changed with set_fs())
- cr13 contains the kernel asce
In case of uaccess the kernel changes to:
- primary space mode in case of a uaccess (copy_to_user) and uses
e.g. the mvcp instruction to access user space. However the kernel
will stay in home space mode if the mvcos instruction is available
- secondary space mode in case of futex atomic operations, so that the
instructions come from primary address space and data from secondary
space
In case of kvm the kernel runs in home space mode, but cr1 gets switched
to contain the gmap asce before the sie instruction gets executed. When
the sie instruction is finished cr1 will be switched back to contain the
user asce.
A context switch between two processes will always load the kernel asce
for the next process in cr1. So the first exit to user space is a bit
more expensive (one extra load control register instruction) than before,
however keeps the code rather simple.
In sum this means there is no need to perform any error prone page table
walks anymore when accessing user space.
The patch seems to be rather large, however it mainly removes the
the page table walk code and restores the previously deleted "standard"
uaccess code, with a couple of changes.
The uaccess without mvcos mode can be enforced with the "uaccess_primary"
kernel parameter.
Reported-by: Christian Borntraeger <borntraeger@de.ibm.com>
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
120 lines
3.8 KiB
C
120 lines
3.8 KiB
C
/*
|
|
* S390 version
|
|
* Copyright IBM Corp. 2002, 2006
|
|
* Author(s): Martin Schwidefsky (schwidefsky@de.ibm.com)
|
|
*/
|
|
|
|
#ifndef _ASM_THREAD_INFO_H
|
|
#define _ASM_THREAD_INFO_H
|
|
|
|
/*
|
|
* Size of kernel stack for each process
|
|
*/
|
|
#ifndef CONFIG_64BIT
|
|
#define THREAD_ORDER 1
|
|
#define ASYNC_ORDER 1
|
|
#else /* CONFIG_64BIT */
|
|
#define THREAD_ORDER 2
|
|
#define ASYNC_ORDER 2
|
|
#endif /* CONFIG_64BIT */
|
|
|
|
#define THREAD_SIZE (PAGE_SIZE << THREAD_ORDER)
|
|
#define ASYNC_SIZE (PAGE_SIZE << ASYNC_ORDER)
|
|
|
|
#ifndef __ASSEMBLY__
|
|
#include <asm/lowcore.h>
|
|
#include <asm/page.h>
|
|
#include <asm/processor.h>
|
|
|
|
/*
|
|
* low level task data that entry.S needs immediate access to
|
|
* - this struct should fit entirely inside of one cache line
|
|
* - this struct shares the supervisor stack pages
|
|
* - if the contents of this structure are changed, the assembly constants must also be changed
|
|
*/
|
|
struct thread_info {
|
|
struct task_struct *task; /* main task structure */
|
|
struct exec_domain *exec_domain; /* execution domain */
|
|
unsigned long flags; /* low level flags */
|
|
unsigned long sys_call_table; /* System call table address */
|
|
unsigned int cpu; /* current CPU */
|
|
int preempt_count; /* 0 => preemptable, <0 => BUG */
|
|
struct restart_block restart_block;
|
|
unsigned int system_call;
|
|
__u64 user_timer;
|
|
__u64 system_timer;
|
|
unsigned long last_break; /* last breaking-event-address. */
|
|
};
|
|
|
|
/*
|
|
* macros/functions for gaining access to the thread information structure
|
|
*/
|
|
#define INIT_THREAD_INFO(tsk) \
|
|
{ \
|
|
.task = &tsk, \
|
|
.exec_domain = &default_exec_domain, \
|
|
.flags = 0, \
|
|
.cpu = 0, \
|
|
.preempt_count = INIT_PREEMPT_COUNT, \
|
|
.restart_block = { \
|
|
.fn = do_no_restart_syscall, \
|
|
}, \
|
|
}
|
|
|
|
#define init_thread_info (init_thread_union.thread_info)
|
|
#define init_stack (init_thread_union.stack)
|
|
|
|
/* how to get the thread information struct from C */
|
|
static inline struct thread_info *current_thread_info(void)
|
|
{
|
|
return (struct thread_info *) S390_lowcore.thread_info;
|
|
}
|
|
|
|
#define THREAD_SIZE_ORDER THREAD_ORDER
|
|
|
|
#endif
|
|
|
|
/*
|
|
* thread information flags bit numbers
|
|
*/
|
|
#define TIF_SYSCALL 0 /* inside a system call */
|
|
#define TIF_NOTIFY_RESUME 1 /* callback before returning to user */
|
|
#define TIF_SIGPENDING 2 /* signal pending */
|
|
#define TIF_NEED_RESCHED 3 /* rescheduling necessary */
|
|
#define TIF_TLB_WAIT 4 /* wait for TLB flush completion */
|
|
#define TIF_ASCE 5 /* primary asce needs fixup / uaccess */
|
|
#define TIF_PER_TRAP 6 /* deliver sigtrap on return to user */
|
|
#define TIF_MCCK_PENDING 7 /* machine check handling is pending */
|
|
#define TIF_SYSCALL_TRACE 8 /* syscall trace active */
|
|
#define TIF_SYSCALL_AUDIT 9 /* syscall auditing active */
|
|
#define TIF_SECCOMP 10 /* secure computing */
|
|
#define TIF_SYSCALL_TRACEPOINT 11 /* syscall tracepoint instrumentation */
|
|
#define TIF_31BIT 17 /* 32bit process */
|
|
#define TIF_MEMDIE 18 /* is terminating due to OOM killer */
|
|
#define TIF_RESTORE_SIGMASK 19 /* restore signal mask in do_signal() */
|
|
#define TIF_SINGLE_STEP 20 /* This task is single stepped */
|
|
#define TIF_BLOCK_STEP 21 /* This task is block stepped */
|
|
|
|
#define _TIF_SYSCALL (1<<TIF_SYSCALL)
|
|
#define _TIF_NOTIFY_RESUME (1<<TIF_NOTIFY_RESUME)
|
|
#define _TIF_SIGPENDING (1<<TIF_SIGPENDING)
|
|
#define _TIF_NEED_RESCHED (1<<TIF_NEED_RESCHED)
|
|
#define _TIF_TLB_WAIT (1<<TIF_TLB_WAIT)
|
|
#define _TIF_ASCE (1<<TIF_ASCE)
|
|
#define _TIF_PER_TRAP (1<<TIF_PER_TRAP)
|
|
#define _TIF_MCCK_PENDING (1<<TIF_MCCK_PENDING)
|
|
#define _TIF_SYSCALL_TRACE (1<<TIF_SYSCALL_TRACE)
|
|
#define _TIF_SYSCALL_AUDIT (1<<TIF_SYSCALL_AUDIT)
|
|
#define _TIF_SECCOMP (1<<TIF_SECCOMP)
|
|
#define _TIF_SYSCALL_TRACEPOINT (1<<TIF_SYSCALL_TRACEPOINT)
|
|
#define _TIF_31BIT (1<<TIF_31BIT)
|
|
#define _TIF_SINGLE_STEP (1<<TIF_SINGLE_STEP)
|
|
|
|
#ifdef CONFIG_64BIT
|
|
#define is_32bit_task() (test_thread_flag(TIF_31BIT))
|
|
#else
|
|
#define is_32bit_task() (1)
|
|
#endif
|
|
|
|
#endif /* _ASM_THREAD_INFO_H */
|