linux/net/nfc
Johannes Berg 634fef6107 networking: add and use skb_put_u8()
Joe and Bjørn suggested that it'd be nicer to not have the
cast in the fairly common case of doing
	*(u8 *)skb_put(skb, 1) = c;

Add skb_put_u8() for this case, and use it across the code,
using the following spatch:

    @@
    expression SKB, C, S;
    typedef u8;
    identifier fn = {skb_put};
    fresh identifier fn2 = fn ## "_u8";
    @@
    - *(u8 *)fn(SKB, S) = C;
    + fn2(SKB, C);

Note that due to the "S", the spatch isn't perfect, it should
have checked that S is 1, but there's also places that use a
sizeof expression like sizeof(var) or sizeof(u8) etc. Turns
out that nobody ever did something like
	*(u8 *)skb_put(skb, 2) = c;

which would be wrong anyway since the second byte wouldn't be
initialized.

Suggested-by: Joe Perches <joe@perches.com>
Suggested-by: Bjørn Mork <bjorn@mork.no>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2017-06-16 11:48:40 -04:00
..
hci networking: add and use skb_put_u8() 2017-06-16 11:48:40 -04:00
nci networking: add and use skb_put_u8() 2017-06-16 11:48:40 -04:00
af_nfc.c
core.c
digital.h
digital_core.c networking: add and use skb_put_u8() 2017-06-16 11:48:40 -04:00
digital_dep.c networking: add and use skb_put_u8() 2017-06-16 11:48:40 -04:00
digital_technology.c networking: add and use skb_put_u8() 2017-06-16 11:48:40 -04:00
Kconfig
llcp.h
llcp_commands.c
llcp_core.c
llcp_sock.c
Makefile
netlink.c
nfc.h
rawsock.c networking: make skb_push & __skb_push return void pointers 2017-06-16 11:48:40 -04:00