mirror of
https://github.com/torvalds/linux
synced 2024-11-05 18:23:50 +00:00
cde2e9a651
Eric Dumazet pointed out this warning in the drop_monitor protocol to me: [ 38.352571] BUG: sleeping function called from invalid context at kernel/mutex.c:85 [ 38.352576] in_atomic(): 1, irqs_disabled(): 0, pid: 4415, name: dropwatch [ 38.352580] Pid: 4415, comm: dropwatch Not tainted 3.4.0-rc2+ #71 [ 38.352582] Call Trace: [ 38.352592] [<ffffffff8153aaf0>] ? trace_napi_poll_hit+0xd0/0xd0 [ 38.352599] [<ffffffff81063f2a>] __might_sleep+0xca/0xf0 [ 38.352606] [<ffffffff81655b16>] mutex_lock+0x26/0x50 [ 38.352610] [<ffffffff8153aaf0>] ? trace_napi_poll_hit+0xd0/0xd0 [ 38.352616] [<ffffffff810b72d9>] tracepoint_probe_register+0x29/0x90 [ 38.352621] [<ffffffff8153a585>] set_all_monitor_traces+0x105/0x170 [ 38.352625] [<ffffffff8153a8ca>] net_dm_cmd_trace+0x2a/0x40 [ 38.352630] [<ffffffff8154a81a>] genl_rcv_msg+0x21a/0x2b0 [ 38.352636] [<ffffffff810f8029>] ? zone_statistics+0x99/0xc0 [ 38.352640] [<ffffffff8154a600>] ? genl_rcv+0x30/0x30 [ 38.352645] [<ffffffff8154a059>] netlink_rcv_skb+0xa9/0xd0 [ 38.352649] [<ffffffff8154a5f0>] genl_rcv+0x20/0x30 [ 38.352653] [<ffffffff81549a7e>] netlink_unicast+0x1ae/0x1f0 [ 38.352658] [<ffffffff81549d76>] netlink_sendmsg+0x2b6/0x310 [ 38.352663] [<ffffffff8150824f>] sock_sendmsg+0x10f/0x130 [ 38.352668] [<ffffffff8150abe0>] ? move_addr_to_kernel+0x60/0xb0 [ 38.352673] [<ffffffff81515f04>] ? verify_iovec+0x64/0xe0 [ 38.352677] [<ffffffff81509c46>] __sys_sendmsg+0x386/0x390 [ 38.352682] [<ffffffff810ffaf9>] ? handle_mm_fault+0x139/0x210 [ 38.352687] [<ffffffff8165b5bc>] ? do_page_fault+0x1ec/0x4f0 [ 38.352693] [<ffffffff8106ba4d>] ? set_next_entity+0x9d/0xb0 [ 38.352699] [<ffffffff81310b49>] ? tty_ldisc_deref+0x9/0x10 [ 38.352703] [<ffffffff8106d363>] ? pick_next_task_fair+0x63/0x140 [ 38.352708] [<ffffffff8150b8d4>] sys_sendmsg+0x44/0x80 [ 38.352713] [<ffffffff8165f8e2>] system_call_fastpath+0x16/0x1b It stems from holding a spinlock (trace_state_lock) while attempting to register or unregister tracepoint hooks, making in_atomic() true in this context, leading to the warning when the tracepoint calls might_sleep() while its taking a mutex. Since we only use the trace_state_lock to prevent trace protocol state races, as well as hardware stat list updates on an rcu write side, we can just convert the spinlock to a mutex to avoid this problem. Signed-off-by: Neil Horman <nhorman@tuxdriver.com> Reported-by: Eric Dumazet <eric.dumazet@gmail.com> CC: David Miller <davem@davemloft.net> Acked-by: Eric Dumazet <edumazet@google.com> Signed-off-by: David S. Miller <davem@davemloft.net>
386 lines
8.5 KiB
C
386 lines
8.5 KiB
C
/*
|
|
* Monitoring code for network dropped packet alerts
|
|
*
|
|
* Copyright (C) 2009 Neil Horman <nhorman@tuxdriver.com>
|
|
*/
|
|
|
|
#include <linux/netdevice.h>
|
|
#include <linux/etherdevice.h>
|
|
#include <linux/string.h>
|
|
#include <linux/if_arp.h>
|
|
#include <linux/inetdevice.h>
|
|
#include <linux/inet.h>
|
|
#include <linux/interrupt.h>
|
|
#include <linux/netpoll.h>
|
|
#include <linux/sched.h>
|
|
#include <linux/delay.h>
|
|
#include <linux/types.h>
|
|
#include <linux/workqueue.h>
|
|
#include <linux/netlink.h>
|
|
#include <linux/net_dropmon.h>
|
|
#include <linux/percpu.h>
|
|
#include <linux/timer.h>
|
|
#include <linux/bitops.h>
|
|
#include <linux/slab.h>
|
|
#include <net/genetlink.h>
|
|
#include <net/netevent.h>
|
|
|
|
#include <trace/events/skb.h>
|
|
#include <trace/events/napi.h>
|
|
|
|
#include <asm/unaligned.h>
|
|
|
|
#define TRACE_ON 1
|
|
#define TRACE_OFF 0
|
|
|
|
static void send_dm_alert(struct work_struct *unused);
|
|
|
|
|
|
/*
|
|
* Globals, our netlink socket pointer
|
|
* and the work handle that will send up
|
|
* netlink alerts
|
|
*/
|
|
static int trace_state = TRACE_OFF;
|
|
static DEFINE_MUTEX(trace_state_mutex);
|
|
|
|
struct per_cpu_dm_data {
|
|
struct work_struct dm_alert_work;
|
|
struct sk_buff *skb;
|
|
atomic_t dm_hit_count;
|
|
struct timer_list send_timer;
|
|
};
|
|
|
|
struct dm_hw_stat_delta {
|
|
struct net_device *dev;
|
|
unsigned long last_rx;
|
|
struct list_head list;
|
|
struct rcu_head rcu;
|
|
unsigned long last_drop_val;
|
|
};
|
|
|
|
static struct genl_family net_drop_monitor_family = {
|
|
.id = GENL_ID_GENERATE,
|
|
.hdrsize = 0,
|
|
.name = "NET_DM",
|
|
.version = 2,
|
|
.maxattr = NET_DM_CMD_MAX,
|
|
};
|
|
|
|
static DEFINE_PER_CPU(struct per_cpu_dm_data, dm_cpu_data);
|
|
|
|
static int dm_hit_limit = 64;
|
|
static int dm_delay = 1;
|
|
static unsigned long dm_hw_check_delta = 2*HZ;
|
|
static LIST_HEAD(hw_stats_list);
|
|
|
|
static void reset_per_cpu_data(struct per_cpu_dm_data *data)
|
|
{
|
|
size_t al;
|
|
struct net_dm_alert_msg *msg;
|
|
struct nlattr *nla;
|
|
|
|
al = sizeof(struct net_dm_alert_msg);
|
|
al += dm_hit_limit * sizeof(struct net_dm_drop_point);
|
|
al += sizeof(struct nlattr);
|
|
|
|
data->skb = genlmsg_new(al, GFP_KERNEL);
|
|
genlmsg_put(data->skb, 0, 0, &net_drop_monitor_family,
|
|
0, NET_DM_CMD_ALERT);
|
|
nla = nla_reserve(data->skb, NLA_UNSPEC, sizeof(struct net_dm_alert_msg));
|
|
msg = nla_data(nla);
|
|
memset(msg, 0, al);
|
|
atomic_set(&data->dm_hit_count, dm_hit_limit);
|
|
}
|
|
|
|
static void send_dm_alert(struct work_struct *unused)
|
|
{
|
|
struct sk_buff *skb;
|
|
struct per_cpu_dm_data *data = &__get_cpu_var(dm_cpu_data);
|
|
|
|
/*
|
|
* Grab the skb we're about to send
|
|
*/
|
|
skb = data->skb;
|
|
|
|
/*
|
|
* Replace it with a new one
|
|
*/
|
|
reset_per_cpu_data(data);
|
|
|
|
/*
|
|
* Ship it!
|
|
*/
|
|
genlmsg_multicast(skb, 0, NET_DM_GRP_ALERT, GFP_KERNEL);
|
|
|
|
}
|
|
|
|
/*
|
|
* This is the timer function to delay the sending of an alert
|
|
* in the event that more drops will arrive during the
|
|
* hysteresis period. Note that it operates under the timer interrupt
|
|
* so we don't need to disable preemption here
|
|
*/
|
|
static void sched_send_work(unsigned long unused)
|
|
{
|
|
struct per_cpu_dm_data *data = &__get_cpu_var(dm_cpu_data);
|
|
|
|
schedule_work(&data->dm_alert_work);
|
|
}
|
|
|
|
static void trace_drop_common(struct sk_buff *skb, void *location)
|
|
{
|
|
struct net_dm_alert_msg *msg;
|
|
struct nlmsghdr *nlh;
|
|
struct nlattr *nla;
|
|
int i;
|
|
struct per_cpu_dm_data *data = &__get_cpu_var(dm_cpu_data);
|
|
|
|
|
|
if (!atomic_add_unless(&data->dm_hit_count, -1, 0)) {
|
|
/*
|
|
* we're already at zero, discard this hit
|
|
*/
|
|
goto out;
|
|
}
|
|
|
|
nlh = (struct nlmsghdr *)data->skb->data;
|
|
nla = genlmsg_data(nlmsg_data(nlh));
|
|
msg = nla_data(nla);
|
|
for (i = 0; i < msg->entries; i++) {
|
|
if (!memcmp(&location, msg->points[i].pc, sizeof(void *))) {
|
|
msg->points[i].count++;
|
|
atomic_inc(&data->dm_hit_count);
|
|
goto out;
|
|
}
|
|
}
|
|
|
|
/*
|
|
* We need to create a new entry
|
|
*/
|
|
__nla_reserve_nohdr(data->skb, sizeof(struct net_dm_drop_point));
|
|
nla->nla_len += NLA_ALIGN(sizeof(struct net_dm_drop_point));
|
|
memcpy(msg->points[msg->entries].pc, &location, sizeof(void *));
|
|
msg->points[msg->entries].count = 1;
|
|
msg->entries++;
|
|
|
|
if (!timer_pending(&data->send_timer)) {
|
|
data->send_timer.expires = jiffies + dm_delay * HZ;
|
|
add_timer_on(&data->send_timer, smp_processor_id());
|
|
}
|
|
|
|
out:
|
|
return;
|
|
}
|
|
|
|
static void trace_kfree_skb_hit(void *ignore, struct sk_buff *skb, void *location)
|
|
{
|
|
trace_drop_common(skb, location);
|
|
}
|
|
|
|
static void trace_napi_poll_hit(void *ignore, struct napi_struct *napi)
|
|
{
|
|
struct dm_hw_stat_delta *new_stat;
|
|
|
|
/*
|
|
* Don't check napi structures with no associated device
|
|
*/
|
|
if (!napi->dev)
|
|
return;
|
|
|
|
rcu_read_lock();
|
|
list_for_each_entry_rcu(new_stat, &hw_stats_list, list) {
|
|
/*
|
|
* only add a note to our monitor buffer if:
|
|
* 1) this is the dev we received on
|
|
* 2) its after the last_rx delta
|
|
* 3) our rx_dropped count has gone up
|
|
*/
|
|
if ((new_stat->dev == napi->dev) &&
|
|
(time_after(jiffies, new_stat->last_rx + dm_hw_check_delta)) &&
|
|
(napi->dev->stats.rx_dropped != new_stat->last_drop_val)) {
|
|
trace_drop_common(NULL, NULL);
|
|
new_stat->last_drop_val = napi->dev->stats.rx_dropped;
|
|
new_stat->last_rx = jiffies;
|
|
break;
|
|
}
|
|
}
|
|
rcu_read_unlock();
|
|
}
|
|
|
|
static int set_all_monitor_traces(int state)
|
|
{
|
|
int rc = 0;
|
|
struct dm_hw_stat_delta *new_stat = NULL;
|
|
struct dm_hw_stat_delta *temp;
|
|
|
|
mutex_lock(&trace_state_mutex);
|
|
|
|
if (state == trace_state) {
|
|
rc = -EAGAIN;
|
|
goto out_unlock;
|
|
}
|
|
|
|
switch (state) {
|
|
case TRACE_ON:
|
|
rc |= register_trace_kfree_skb(trace_kfree_skb_hit, NULL);
|
|
rc |= register_trace_napi_poll(trace_napi_poll_hit, NULL);
|
|
break;
|
|
case TRACE_OFF:
|
|
rc |= unregister_trace_kfree_skb(trace_kfree_skb_hit, NULL);
|
|
rc |= unregister_trace_napi_poll(trace_napi_poll_hit, NULL);
|
|
|
|
tracepoint_synchronize_unregister();
|
|
|
|
/*
|
|
* Clean the device list
|
|
*/
|
|
list_for_each_entry_safe(new_stat, temp, &hw_stats_list, list) {
|
|
if (new_stat->dev == NULL) {
|
|
list_del_rcu(&new_stat->list);
|
|
kfree_rcu(new_stat, rcu);
|
|
}
|
|
}
|
|
break;
|
|
default:
|
|
rc = 1;
|
|
break;
|
|
}
|
|
|
|
if (!rc)
|
|
trace_state = state;
|
|
else
|
|
rc = -EINPROGRESS;
|
|
|
|
out_unlock:
|
|
mutex_unlock(&trace_state_mutex);
|
|
|
|
return rc;
|
|
}
|
|
|
|
|
|
static int net_dm_cmd_config(struct sk_buff *skb,
|
|
struct genl_info *info)
|
|
{
|
|
return -ENOTSUPP;
|
|
}
|
|
|
|
static int net_dm_cmd_trace(struct sk_buff *skb,
|
|
struct genl_info *info)
|
|
{
|
|
switch (info->genlhdr->cmd) {
|
|
case NET_DM_CMD_START:
|
|
return set_all_monitor_traces(TRACE_ON);
|
|
break;
|
|
case NET_DM_CMD_STOP:
|
|
return set_all_monitor_traces(TRACE_OFF);
|
|
break;
|
|
}
|
|
|
|
return -ENOTSUPP;
|
|
}
|
|
|
|
static int dropmon_net_event(struct notifier_block *ev_block,
|
|
unsigned long event, void *ptr)
|
|
{
|
|
struct net_device *dev = ptr;
|
|
struct dm_hw_stat_delta *new_stat = NULL;
|
|
struct dm_hw_stat_delta *tmp;
|
|
|
|
switch (event) {
|
|
case NETDEV_REGISTER:
|
|
new_stat = kzalloc(sizeof(struct dm_hw_stat_delta), GFP_KERNEL);
|
|
|
|
if (!new_stat)
|
|
goto out;
|
|
|
|
new_stat->dev = dev;
|
|
new_stat->last_rx = jiffies;
|
|
mutex_lock(&trace_state_mutex);
|
|
list_add_rcu(&new_stat->list, &hw_stats_list);
|
|
mutex_unlock(&trace_state_mutex);
|
|
break;
|
|
case NETDEV_UNREGISTER:
|
|
mutex_lock(&trace_state_mutex);
|
|
list_for_each_entry_safe(new_stat, tmp, &hw_stats_list, list) {
|
|
if (new_stat->dev == dev) {
|
|
new_stat->dev = NULL;
|
|
if (trace_state == TRACE_OFF) {
|
|
list_del_rcu(&new_stat->list);
|
|
kfree_rcu(new_stat, rcu);
|
|
break;
|
|
}
|
|
}
|
|
}
|
|
mutex_unlock(&trace_state_mutex);
|
|
break;
|
|
}
|
|
out:
|
|
return NOTIFY_DONE;
|
|
}
|
|
|
|
static struct genl_ops dropmon_ops[] = {
|
|
{
|
|
.cmd = NET_DM_CMD_CONFIG,
|
|
.doit = net_dm_cmd_config,
|
|
},
|
|
{
|
|
.cmd = NET_DM_CMD_START,
|
|
.doit = net_dm_cmd_trace,
|
|
},
|
|
{
|
|
.cmd = NET_DM_CMD_STOP,
|
|
.doit = net_dm_cmd_trace,
|
|
},
|
|
};
|
|
|
|
static struct notifier_block dropmon_net_notifier = {
|
|
.notifier_call = dropmon_net_event
|
|
};
|
|
|
|
static int __init init_net_drop_monitor(void)
|
|
{
|
|
struct per_cpu_dm_data *data;
|
|
int cpu, rc;
|
|
|
|
printk(KERN_INFO "Initializing network drop monitor service\n");
|
|
|
|
if (sizeof(void *) > 8) {
|
|
printk(KERN_ERR "Unable to store program counters on this arch, Drop monitor failed\n");
|
|
return -ENOSPC;
|
|
}
|
|
|
|
rc = genl_register_family_with_ops(&net_drop_monitor_family,
|
|
dropmon_ops,
|
|
ARRAY_SIZE(dropmon_ops));
|
|
if (rc) {
|
|
printk(KERN_ERR "Could not create drop monitor netlink family\n");
|
|
return rc;
|
|
}
|
|
|
|
rc = register_netdevice_notifier(&dropmon_net_notifier);
|
|
if (rc < 0) {
|
|
printk(KERN_CRIT "Failed to register netdevice notifier\n");
|
|
goto out_unreg;
|
|
}
|
|
|
|
rc = 0;
|
|
|
|
for_each_present_cpu(cpu) {
|
|
data = &per_cpu(dm_cpu_data, cpu);
|
|
reset_per_cpu_data(data);
|
|
INIT_WORK(&data->dm_alert_work, send_dm_alert);
|
|
init_timer(&data->send_timer);
|
|
data->send_timer.data = cpu;
|
|
data->send_timer.function = sched_send_work;
|
|
}
|
|
|
|
goto out;
|
|
|
|
out_unreg:
|
|
genl_unregister_family(&net_drop_monitor_family);
|
|
out:
|
|
return rc;
|
|
}
|
|
|
|
late_initcall(init_net_drop_monitor);
|