linux/drivers/s390
Farhan Ali c9f597a4d6 vfio-ccw: Fix misleading comment when setting orb.cmd.c64
The comment is misleading because it tells us that
we should set orb.cmd.c64 before calling ccwchain_calc_length,
otherwise the function ccwchain_calc_length would return an
error. This is not completely accurate.

We want to allow an orb without cmd.c64, and this is fine
as long as the channel program does not use IDALs. But we do
want to reject any channel program that uses IDALs and does
not set the flag, which is what we do in ccwchain_calc_length.

After we have done the ccw processing, we need to set cmd.c64,
as we use IDALs for all translated channel programs.

Also for better code readability let's move the setting of
cmd.c64 within the non error path.

Fixes: fb9e7880af ("vfio: ccw: push down unsupported IDA check")
Signed-off-by: Farhan Ali <alifm@linux.ibm.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Message-Id: <f68636106aef0faeb6ce9712584d102d1b315ff8.1562854091.git.alifm@linux.ibm.com>
Reviewed-by: Eric Farman <farman@linux.ibm.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
2019-07-15 14:14:33 +02:00
..
block s390/dasd: Handle out-of-space constraint 2019-07-11 20:39:54 +02:00
char s390/ipl: Fix detection of has_secure attribute 2019-07-11 20:40:02 +02:00
cio vfio-ccw: Fix misleading comment when setting orb.cmd.c64 2019-07-15 14:14:33 +02:00
crypto s390/zcrypt: remove the exporting of ap_query_configuration 2019-07-11 20:40:02 +02:00
net s390 updates for the 5.3 merge window 2019-07-08 10:06:12 -07:00
scsi scsi: zfcp: fix to prevent port_remove with pure auto scan LUNs (only sdevs) 2019-05-29 21:52:31 -04:00
virtio virtio/s390: make airq summary indicators DMA 2019-06-15 12:25:41 +02:00
Makefile