linux/drivers/staging/crystalhd
Arnd Bergmann 8e2394a981 Staging: autoconvert trivial BKL users to private mutex
All these files use the big kernel lock in a trivial
way to serialize their private file operations,
typically resulting from an earlier semi-automatic
pushdown from VFS.

None of these drivers appears to want to lock against
other code, and they all use the BKL as the top-level
lock in their file operations, meaning that there
is no lock-order inversion problem.

Consequently, we can remove the BKL completely,
replacing it with a per-file mutex in every case.
Using a scripted approach means we can avoid
typos.

file=$1
name=$2
if grep -q lock_kernel ${file} ; then
    if grep -q 'include.*linux.mutex.h' ${file} ; then
            sed -i '/include.*<linux\/smp_lock.h>/d' ${file}
    else
            sed -i 's/include.*<linux\/smp_lock.h>.*$/include <linux\/mutex.h>/g' ${file}
    fi
    sed -i ${file} \
        -e "/^#include.*linux.mutex.h/,$ {
                1,/^\(static\|int\|long\)/ {
                     /^\(static\|int\|long\)/istatic DEFINE_MUTEX(${name}_mutex);

} }"  \
    -e "s/\(un\)*lock_kernel\>[ ]*()/mutex_\1lock(\&${name}_mutex)/g" \
    -e '/[      ]*cycle_kernel_lock();/d'
else
    sed -i -e '/include.*\<smp_lock.h\>/d' ${file}  \
                -e '/cycle_kernel_lock()/d'
fi

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-07-22 11:10:29 -07:00
..
bc_dts_defs.h Staging: crystalhd: Remove typedefs from driver 2010-05-18 14:53:17 -07:00
bc_dts_glob_lnx.h Staging: crystalhd: Remove typedefs from driver 2010-05-18 14:53:17 -07:00
bc_dts_types.h Staging: crystalhd: Cleanup all WIN* references 2010-05-11 11:36:01 -07:00
bcm_70012_regs.h Staging: crystalhd: Whitespace fixes, indentation fixes and 3 changed #includes 2010-05-11 11:35:36 -07:00
crystalhd_cmds.c Staging: crystalhd: Remove typedefs from driver 2010-05-18 14:53:17 -07:00
crystalhd_cmds.h Staging: crystalhd: Remove typedefs from driver 2010-05-18 14:53:17 -07:00
crystalhd_fw_if.h Staging: crystalhd: Remove typedefs from driver 2010-05-18 14:53:17 -07:00
crystalhd_hw.c Staging: crystalhd: Remove typedefs from driver 2010-05-18 14:53:17 -07:00
crystalhd_hw.h Staging: crystalhd: Remove typedefs from driver 2010-05-18 14:53:17 -07:00
crystalhd_lnx.c Staging: autoconvert trivial BKL users to private mutex 2010-07-22 11:10:29 -07:00
crystalhd_lnx.h Staging: crystalhd: Remove typedefs from driver 2010-05-18 14:53:17 -07:00
crystalhd_misc.c Staging: crystalhd: Remove typedefs from driver 2010-05-18 14:53:17 -07:00
crystalhd_misc.h Staging: crystalhd: Remove typedefs from driver 2010-05-18 14:53:17 -07:00
Kconfig staging: add Broadcom Crystal HD driver 2010-03-03 16:42:34 -08:00
Makefile staging: add Broadcom Crystal HD driver 2010-03-03 16:42:34 -08:00
TODO Staging: crystalhd: Cleanup all WIN* references 2010-05-11 11:36:01 -07:00