mirror of
https://github.com/torvalds/linux
synced 2024-10-18 17:29:25 +00:00
c58f009e01
Addresses "[BUG] completely bonkers use of set_need_resched + VM_FAULT_NOPAGE". In the first occurence it was used to try to be nice while releasing the mmap_sem and retrying the fault to work around a locking inversion. The second occurence was never used. There has been some discussion whether we should change the locking order to mmap_sem -> bo_reserve. This patch doesn't address that issue, and leaves that locking order undefined. The solution that we release the mmap_sem if tryreserve fails and wait for the buffer to become unreserved is something we want in any case, and follows how the core vm system waits for pages to be come unlocked while releasing the mmap_sem. The code also outlines what needs to be changed if we want to establish the locking order as mmap_sem -> bo::reserve. One slight issue that remains with this code is that the fault handler might be prone to starvation if another thread countinously reserves the buffer. IMO that usage pattern is highly unlikely. Signed-off-by: Thomas Hellstrom <thellstrom@vmware.com> |
||
|---|---|---|
| .. | ||
| ttm_bo_api.h | ||
| ttm_bo_driver.h | ||
| ttm_execbuf_util.h | ||
| ttm_lock.h | ||
| ttm_memory.h | ||
| ttm_module.h | ||
| ttm_object.h | ||
| ttm_page_alloc.h | ||
| ttm_placement.h | ||