Eric Dumazet c4e86b4363 net: add two more call_rcu_hurry() ... I had failures with pmtu.sh selftests lately, with netns dismantles firing ref_tracking alerts [1]. After much debugging, I found that some queued rcu callbacks were delayed by minutes, because of CONFIG_RCU_LAZY=y option. Joel Fernandes had a similar issue in the past, fixed with commit 483c26ff63 ("net: Use call_rcu_hurry() for dst_release()") In this commit, I make sure nexthop_free_rcu() and free_fib_info_rcu() are not delayed too much because they both can release device references. tools/testing/selftests/net/pmtu.sh no longer fails. Traces were: [ 968.179860] ref_tracker: veth_A-R1@00000000d0ff3fe2 has 3/5 users at dst_alloc+0x76/0x160 ip6_dst_alloc+0x25/0x80 ip6_pol_route+0x2a8/0x450 ip6_pol_route_output+0x1f/0x30 fib6_rule_lookup+0x163/0x270 ip6_route_output_flags+0xda/0x190 ip6_dst_lookup_tail.constprop.0+0x1d0/0x260 ip6_dst_lookup_flow+0x47/0xa0 udp_tunnel6_dst_lookup+0x158/0x210 vxlan_xmit_one+0x4c2/0x1550 [vxlan] vxlan_xmit+0x52d/0x14f0 [vxlan] dev_hard_start_xmit+0x7b/0x1e0 __dev_queue_xmit+0x20b/0xe40 ip6_finish_output2+0x2ea/0x6e0 ip6_finish_output+0x143/0x320 ip6_output+0x74/0x140 [ 968.179860] ref_tracker: veth_A-R1@00000000d0ff3fe2 has 1/5 users at netdev_get_by_index+0xc0/0xe0 fib6_nh_init+0x1a9/0xa90 rtm_new_nexthop+0x6fa/0x1580 rtnetlink_rcv_msg+0x155/0x3e0 netlink_rcv_skb+0x61/0x110 rtnetlink_rcv+0x19/0x20 netlink_unicast+0x23f/0x380 netlink_sendmsg+0x1fc/0x430 ____sys_sendmsg+0x2ef/0x320 ___sys_sendmsg+0x86/0xd0 __sys_sendmsg+0x67/0xc0 __x64_sys_sendmsg+0x21/0x30 x64_sys_call+0x252/0x2030 do_syscall_64+0x6c/0x190 entry_SYSCALL_64_after_hwframe+0x76/0x7e [ 968.179860] ref_tracker: veth_A-R1@00000000d0ff3fe2 has 1/5 users at ipv6_add_dev+0x136/0x530 addrconf_notify+0x19d/0x770 notifier_call_chain+0x65/0xd0 raw_notifier_call_chain+0x1a/0x20 call_netdevice_notifiers_info+0x54/0x90 register_netdevice+0x61e/0x790 veth_newlink+0x230/0x440 __rtnl_newlink+0x7d2/0xaa0 rtnl_newlink+0x4c/0x70 rtnetlink_rcv_msg+0x155/0x3e0 netlink_rcv_skb+0x61/0x110 rtnetlink_rcv+0x19/0x20 netlink_unicast+0x23f/0x380 netlink_sendmsg+0x1fc/0x430 ____sys_sendmsg+0x2ef/0x320 ___sys_sendmsg+0x86/0xd0 .... [ 1079.316024] ? show_regs+0x68/0x80 [ 1079.316087] ? __warn+0x8c/0x140 [ 1079.316103] ? ref_tracker_free+0x1a0/0x270 [ 1079.316117] ? report_bug+0x196/0x1c0 [ 1079.316135] ? handle_bug+0x42/0x80 [ 1079.316149] ? exc_invalid_op+0x1c/0x70 [ 1079.316162] ? asm_exc_invalid_op+0x1f/0x30 [ 1079.316193] ? ref_tracker_free+0x1a0/0x270 [ 1079.316208] ? _raw_spin_unlock+0x1a/0x40 [ 1079.316222] ? free_unref_page+0x126/0x1a0 [ 1079.316239] ? destroy_large_folio+0x69/0x90 [ 1079.316251] ? __folio_put+0x99/0xd0 [ 1079.316276] dst_dev_put+0x69/0xd0 [ 1079.316308] fib6_nh_release_dsts.part.0+0x3d/0x80 [ 1079.316327] fib6_nh_release+0x45/0x70 [ 1079.316340] nexthop_free_rcu+0x131/0x170 [ 1079.316356] rcu_do_batch+0x1ee/0x820 [ 1079.316370] ? rcu_do_batch+0x179/0x820 [ 1079.316388] rcu_core+0x1aa/0x4d0 [ 1079.316405] rcu_core_si+0x12/0x20 [ 1079.316417] __do_softirq+0x13a/0x3dc [ 1079.316435] __irq_exit_rcu+0xa3/0x110 [ 1079.316449] irq_exit_rcu+0x12/0x30 [ 1079.316462] sysvec_apic_timer_interrupt+0x5b/0xe0 [ 1079.316474] asm_sysvec_apic_timer_interrupt+0x1f/0x30 [ 1079.316569] RIP: 0033:0x7f06b65c63f0 Signed-off-by: Eric Dumazet <edumazet@google.com> Cc: Joel Fernandes (Google) <joel@joelfernandes.org> Cc: Paul E. McKenney <paulmck@kernel.org> Reviewed-by: David Ahern <dsahern@kernel.org> Link: https://lore.kernel.org/r/20240423205408.39632-1-edumazet@google.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>		2024-04-25 15:24:23 -07:00
..
9p	9p: Add additional debug flags and open modes	2023-03-27 02:33:48 +00:00
bluetooth	Bluetooth: hci_event: Fix sending HCI_OP_READ_ENC_KEY_SIZE	2024-04-24 16:26:11 -04:00
caif	net: caif: Remove unused declaration cfsrvl_ctrlcmd()	2023-08-10 18:24:48 -07:00
iucv	s390/iucv: use new address translation helpers	2024-03-13 09:23:48 +01:00
mana	Merge branch mana-ib-flex of git://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git	2024-04-11 07:38:28 -07:00
netfilter	netfilter: flowtable: validate pppoe header	2024-04-11 12:13:11 +02:00
netns	net: Namespace-ify sysctl_optmem_max	2023-12-15 11:01:27 +00:00
nfc	nfc: core: make nfc_class constant	2024-03-05 11:21:18 -08:00
page_pool	net: page_pool: fix recycle stats for system page_pool allocator	2024-02-19 12:30:27 -08:00
phonet	net: ioctl: Use kernel memory on protocol ioctl callbacks	2023-06-15 22:33:26 -07:00
sctp	sctp: preserve const qualifier in sctp_sk()	2024-02-05 11:08:06 +00:00
tc_act	net/sched: Retire ipt action	2024-01-02 12:41:16 +00:00
6lowpan.h
act_api.h	net/sched: Add helper macros with module names	2024-02-02 10:57:55 -08:00
addrconf.h	ipv6: fix race condition between ipv6_get_ifaddr and ipv6_del_addr	2024-04-09 17:09:05 -07:00
af_ieee802154.h
af_rxrpc.h	rxrpc, afs: Allow afs to pin rxrpc_peer objects	2023-12-24 15:22:50 +00:00
af_unix.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2024-04-25 12:41:37 -07:00
af_vsock.h	virtio/vsock: send credit update during setting SO_RCVLOWAT	2023-12-15 10:37:35 +00:00
ah.h
amt.h
arp.h	neighbour: switch to standard rcu, instead of rcu_bh	2023-03-21 21:32:18 -07:00
atmclip.h
ax25.h	x25: preserve const qualifier in [a]x25_sk()	2023-03-18 12:23:34 +00:00
ax88796.h	ax88796: Fix some typo in a comment	2022-08-09 22:14:02 -07:00
bareudp.h
bond_3ad.h	bonding: Add independent control state machine	2024-02-06 13:17:54 +01:00
bond_alb.h	bonding (gcc13): synchronize bond_{a,t}lb_xmit() types	2022-11-02 20:38:13 -07:00
bond_options.h	bonding: Add independent control state machine	2024-02-06 13:17:54 +01:00
bonding.h	bonding: Add independent control state machine	2024-02-06 13:17:54 +01:00
bpf_sk_storage.h
busy_poll.h	net: add napi_busy_loop_rcu()	2024-02-09 10:01:09 -08:00
calipso.h
cfg80211-wext.h	wifi: cfg80211: Avoid clashing function prototypes	2022-11-16 11:31:47 +02:00
cfg80211.h	wifi: cfg80211: fix cfg80211 function kernel-doc	2024-04-19 10:17:16 +02:00
cfg802154.h	mac802154: fix llsec key resources release in mac802154_llsec_key_del	2024-03-06 21:01:26 +01:00
checksum.h	net: checksum: drop the linux/uaccess.h include	2023-01-27 11:19:46 +00:00
cipso_ipv4.h
cls_cgroup.h
codel.h	codel: fix kernel-doc notation warnings	2023-07-14 20:39:29 -07:00
codel_impl.h
codel_qdisc.h
compat.h
datalink.h	net: datalink: Remove unused declarations	2023-07-27 17:17:32 -07:00
dcbevent.h
dcbnl.h	net: dcb: add helper functions to retrieve PCP and DSCP rewrite maps	2023-01-20 09:33:22 +00:00
devlink.h	devlink: extend devlink_param *set pointer	2024-04-22 13:05:19 -07:00
dropreason-core.h	tcp: introduce dropreasons in receive path	2024-02-28 10:39:21 +00:00
dropreason.h	net: openvswitch: add last-action drop reason	2023-08-14 08:01:06 +01:00
dsa.h	devlink: extend devlink_param *set pointer	2024-04-22 13:05:19 -07:00
dsa_stubs.h	net: dsa: Use conduit and user terms	2023-10-24 13:08:14 -07:00
dsfield.h
dst.h	net: dst: Make dst_destroy() static and return void.	2024-02-06 11:45:53 +01:00
dst_cache.h
dst_metadata.h	ip_tunnel: convert __be16 tunnel flags to bitmaps	2024-04-01 10:49:28 +01:00
dst_ops.h	net: remove unnecessary input parameter 'how' in ifdown function	2023-08-22 13:19:02 +02:00
eee.h	net: add helpers for EEE configuration	2024-03-05 19:21:17 -08:00
erspan.h
esp.h
espintcp.h	inet: preserve const qualifier in inet_csk()	2024-04-01 21:27:08 -07:00
ethoc.h
failover.h
fib_notifier.h
fib_rules.h	fib: remove unnecessary input parameters in fib_default_rule_add	2024-01-03 16:42:48 -08:00
firewire.h
flow.h	inet: shrink struct flowi_common	2023-11-02 09:31:02 +01:00
flow_dissector.h	ip_tunnel: convert __be16 tunnel flags to bitmaps	2024-04-01 10:49:28 +01:00
flow_offload.h	flow_offload: add control flag checking helpers	2024-04-15 10:33:14 +01:00
fou.h	bpf,fou: Add bpf_skb_{set,get}_fou_encap kfuncs	2023-04-12 16:40:39 -07:00
fq.h	net: fq: Remove unused typedef fq_flow_get_default_t	2023-08-08 15:58:23 -07:00
fq_impl.h	wifi: mac80211: add support for restricting netdev features per vif	2022-12-01 15:09:10 +01:00
garp.h
gen_stats.h
genetlink.h	genetlink: remove linux/genetlink.h	2024-04-01 21:44:34 -07:00
geneve.h	net: geneve: fix array of flexible structures warnings	2022-10-31 10:43:04 +00:00
gre.h	ip_tunnel: convert __be16 tunnel flags to bitmaps	2024-04-01 10:49:28 +01:00
gro.h	net: gro: move two declarations to include/net/gro.h	2024-03-11 14:13:14 -07:00
gro_cells.h
gso.h	net: move gso declarations and functions to their own files	2023-06-10 00:11:41 -07:00
gtp.h
gue.h
handshake.h	net/handshake: Add helpers for parsing incoming TLS Alerts	2023-07-28 14:07:59 -07:00
hotdata.h	net: move rps_sock_flow_table to net_hotdata	2024-03-07 21:12:43 -08:00
hwbm.h
icmp.h
ieee80211_radiotap.h	wifi: radiotap: add bandwidth definition of EHT U-SIG	2023-10-12 15:14:27 +03:00
ieee802154_netdev.h	mac802154: Handle association requests from peers	2023-11-20 11:43:03 +01:00
if_inet6.h	ipv6: anycast: complete RCU handling of struct ifacaddr6	2024-02-26 18:40:34 -08:00
ife.h
inet6_connection_sock.h
inet6_hashtables.h	net: Fix slab-out-of-bounds in inet[6]_steal_sock	2023-08-15 13:57:51 -07:00
inet_common.h	net: factor out __inet_listen_sk() helper	2023-08-14 07:06:13 +01:00
inet_connection_sock.h	tcp/dccp: complete lockless accesses to sk->sk_max_ack_backlog	2024-04-02 18:21:13 -07:00
inet_dscp.h
inet_ecn.h
inet_frag.h	inet: frags: eliminate kernel-doc warning	2023-07-14 20:39:29 -07:00
inet_hashtables.h	tcp: Remove dead code and fields for bhash2.	2023-12-22 22:15:35 +00:00
inet_sock.h	inet: Add getsockopt support for IP_ROUTER_ALERT and IPV6_ROUTER_ALERT	2024-03-06 12:37:06 +00:00
inet_timewait_sock.h	tcp/dccp: do not care about families in inet_twsk_purge()	2024-04-01 21:27:58 -07:00
inetpeer.h
ioam6.h	net: ioam6: multicast event	2024-02-28 11:19:41 +00:00
ip.h	ipmr: fix kernel panic when forwarding mcast packets	2024-01-26 21:05:26 -08:00
ip6_checksum.h
ip6_fib.h	net/ipv6: Remove expired routes with a separated list of routes.	2024-02-12 10:24:12 +00:00
ip6_route.h	ipv6: annotate data-races around cnf.mtu6	2024-03-01 08:42:31 +00:00
ip6_tunnel.h	ip_tunnel: convert __be16 tunnel flags to bitmaps	2024-04-01 10:49:28 +01:00
ip_fib.h	inet: allow ip_valid_fib_dump_req() to be called with RTNL or RCU	2024-02-26 11:46:12 +00:00
ip_tunnels.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2024-04-11 14:23:47 -07:00
ip_vs.h	ipvs: Correct spelling in comments	2023-04-22 01:39:41 +02:00
ipcomp.h	xfrm: ipcomp: add extack to ipcomp{4,6}_init_state	2022-09-29 07:18:00 +02:00
ipconfig.h
ipv6.h	ipv6: annotate data-races around cnf.forwarding	2024-03-01 08:42:31 +00:00
ipv6_frag.h	net: dropreason: add SKB_DROP_REASON_FRAG_REASM_TIMEOUT	2022-10-31 20:14:27 -07:00
ipv6_stubs.h	ipsec-next-2023-10-28	2023-10-30 14:36:57 -07:00
iw_handler.h	wifi: wext: Remove unused declaration dev_get_wireless_info()	2023-08-22 21:40:40 +02:00
kcm.h	kcm: Send multiple frags in one sendmsg()	2023-06-12 21:13:23 -07:00
l3mdev.h
lag.h
lapb.h
lib80211.h
llc.h
llc_c_ac.h	net: llc: Remove unused function declarations	2023-08-04 15:33:17 -07:00
llc_c_ev.h	net: llc: Remove unused function declarations	2023-08-04 15:33:17 -07:00
llc_c_st.h
llc_conn.h	llc: Check netns in llc_estab_match() and llc_listener_match().	2023-07-20 10:46:28 +02:00
llc_if.h
llc_pdu.h	llc: Drop support for ETH_P_TR_802_2.	2024-01-19 21:30:09 -08:00
llc_s_ac.h
llc_s_ev.h
llc_s_st.h
llc_sap.h
lwtunnel.h	lwt: Check LWTUNNEL_XMIT_CONTINUE strictly	2023-08-18 16:05:26 +02:00
mac80211.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2024-04-25 12:41:37 -07:00
mac802154.h	mac802154: Drop IEEE802154_HW_RX_DROP_BAD_CKSUM	2022-10-12 12:57:19 +02:00
macsec.h	macsec: Enable devices to advertise whether they update sk_buff md_dst during offloads	2024-04-25 08:20:54 -07:00
mctp.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2024-02-29 14:24:56 -08:00
mctpdevice.h
mip6.h
mld.h
mpls.h
mpls_iptunnel.h
mptcp.h	mptcp: add struct mptcp_sched_ops	2023-08-22 17:31:18 -07:00
mrp.h	mrp: introduce active flags to prevent UAF when applicant uninit	2022-11-18 12:14:55 +00:00
ncsi.h
ndisc.h	ndisc: Remove unused ndisc_ifinfo_sysctl_strategy() declaration	2023-08-07 08:53:55 +01:00
neighbour.h	neighbour: Fix __randomize_layout crash in struct neighbour	2023-11-28 12:18:29 +01:00
net_debug.h
net_failover.h
net_namespace.h	net: add exit_batch_rtnl() method	2024-02-07 18:55:10 -08:00
net_ratelimit.h
net_trackers.h
netdev_queues.h	netdev: add queue stat for alloc failures	2024-03-07 21:13:26 -08:00
netdev_rx_queue.h	net: Add queue and napi association	2023-12-04 18:04:05 -08:00
netevent.h
netkit.h	bpf, netkit: Add indirect call wrapper for fetching peer dev	2023-11-20 10:15:16 -08:00
netlabel.h	netlabel: cleanup struct netlbl_lsm_catmap	2024-02-07 12:38:30 +00:00
netlink.h	netlink: add nlmsg_consume() and use it in devlink compat	2024-04-06 18:20:14 +01:00
netmem.h	net: introduce abstraction for network memory	2024-02-20 09:22:58 +01:00
netprio_cgroup.h
netrom.h
nexthop.h	net: add two more call_rcu_hurry()	2024-04-25 15:24:23 -07:00
nl802154.h	ieee802154: Give the user the association list	2023-11-20 11:43:45 +01:00
nsh.h	net: NSH: fix kernel-doc notation warning	2023-07-14 20:39:29 -07:00
p8022.h	net: 802: Remove unused function declarations	2023-08-04 15:33:50 -07:00
pfcp.h	pfcp: always set pfcp metadata	2024-04-01 10:49:28 +01:00
pie.h	pie: fix kernel-doc notation warning	2023-07-14 20:39:30 -07:00
ping.h	net/ipv4: ping_group_range: allow GID from 2147483648 to 4294967294	2023-06-02 09:55:22 +01:00
pkt_cls.h	net: sched: make skip_sw actually skip software	2024-03-29 09:46:39 +00:00
pkt_sched.h	net/sched: Add helper macros with module names	2024-02-02 10:57:55 -08:00
pptp.h
protocol.h	ipv6: move tcp_ipv6_hash_secret and udp_ipv6_hash_secret to net_hotdata	2024-03-07 21:12:43 -08:00
psample.h
psnap.h
raw.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2023-04-06 12:01:20 -07:00
rawv6.h	ipv6: raw: constify raw_v6_match() socket argument	2023-03-17 08:56:37 +00:00
red.h	net_sched: sch_choke: implement lockless choke_dump()	2024-04-19 11:34:07 +01:00
regulatory.h	wifi: cfg80211: save power spectral density(psd) of regulatory rule	2023-09-18 09:44:05 +02:00
request_sock.h	tcp: Clear req->syncookie in reqsk_alloc().	2024-03-19 19:35:59 -07:00
rose.h
route.h	ipv4: Remove RTO_ONLINK.	2024-04-11 19:52:11 -07:00
rpl.h	ipv6: rpl: Remove pskb(_may)?_pull() in ipv6_rpl_srh_rcv().	2023-06-19 11:32:58 -07:00
rps.h	net: rps: add rps_input_queue_head_add() helper	2024-04-01 11:28:32 +01:00
rsi_91x.h	rsi: remove kernel-doc comment marker	2023-07-14 20:39:30 -07:00
rtnetlink.h	rtnetlink: add RTNL_FLAG_DUMP_UNLOCKED flag	2024-02-26 11:46:12 +00:00
rtnh.h
sch_generic.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2024-04-18 13:12:24 -07:00
scm.h	af_unix: Link struct unix_edge when queuing skb.	2024-03-29 08:27:50 -07:00
secure_seq.h
seg6.h
seg6_hmac.h
seg6_local.h
selftests.h
slhc_vj.h
smc.h	net/smc: make smc_hash_sk/smc_unhash_sk static	2024-03-29 09:48:23 +00:00
snmp.h
sock.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2024-04-25 12:41:37 -07:00
sock_reuseport.h	soreuseport: Fix socket selection for SO_INCOMING_CPU.	2022-10-25 11:35:16 +02:00
Space.h	net: appletalk: remove cops support	2023-10-04 11:49:20 -07:00
stp.h
strparser.h
switchdev.h	net: bridge: switchdev: Skip MDB replays of deferred events on offload	2024-02-16 09:36:37 +00:00
tc_wrapper.h	Merge branch 'x86/bugs' into x86/core, to pick up pending changes before dependent patches	2024-02-14 10:49:37 +01:00
tcp.h	tcp: move tcp_skb_cb->sacked flags to enum	2024-04-25 08:52:12 +01:00
tcp_ao.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2024-01-04 18:06:46 -08:00
tcp_states.h	tcp: Dump bound-only sockets in inet_diag.	2023-12-04 14:45:26 -08:00
tcx.h	bpf, tcx: Get rid of tcx_link_const	2023-10-23 15:01:53 -07:00
timewait_sock.h
tipc.h
tls.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2024-04-25 12:41:37 -07:00
tls_prot.h	net/tls: Add TLS Alert definitions	2023-07-28 14:07:59 -07:00
tls_toe.h
transp_v6.h	inet6: Remove unused function declaration udpv6_connect()	2023-08-01 15:06:27 -07:00
tso.h	net: tso: inline tso_count_descs()	2022-12-12 15:04:39 -08:00
tun_proto.h
udp.h	udp/udplite: Remove unused function declarations udp{,lite}_get_port()	2023-08-07 08:53:55 +01:00
udp_tunnel.h	ip_tunnel: convert __be16 tunnel flags to bitmaps	2024-04-01 10:49:28 +01:00
udplite.h	udplite: fix various data-races	2023-09-14 16:16:36 +02:00
vsock_addr.h
vxlan.h	vxlan: add support for flowlabel inherit	2023-11-16 22:33:31 +00:00
wext.h
x25.h	x25: preserve const qualifier in [a]x25_sk()	2023-03-18 12:23:34 +00:00
x25device.h
xdp.h	net, xdp: Correct grammar	2023-12-14 16:38:59 +01:00
xdp_priv.h
xdp_sock.h	xsk: Don't assume metadata is always requested in TX completion	2024-03-19 13:47:29 +01:00
xdp_sock_drv.h	xsk: fix usage of multi-buffer BPF helpers for ZC XDP	2024-01-24 16:24:06 -08:00
xfrm.h	xfrm: get global statistics from the offloaded device	2024-02-05 16:45:49 -08:00
xsk_buff_pool.h	xsk: add functions to fill control buffer	2023-12-13 16:16:40 -08:00