Niklas Cassel fa997b0576 ata: ahci: Do not enable LPM if no LPM states are supported by the HBA ... LPM consists of HIPM (host initiated power management) and DIPM (device initiated power management). ata_eh_set_lpm() will only enable HIPM if both the HBA and the device supports it. However, DIPM will be enabled as long as the device supports it. The HBA will later reject the device's request to enter a power state that it does not support (Slumber/Partial/DevSleep) (DevSleep is never initiated by the device). For a HBA that doesn't support any LPM states, simply don't set a LPM policy such that all the HIPM/DIPM probing/enabling will be skipped. Not enabling HIPM or DIPM in the first place is safer than relying on the device following the AHCI specification and respecting the NAK. (There are comments in the code that some devices misbehave when receiving a NAK.) Performing this check in ahci_update_initial_lpm_policy() also has the advantage that a HBA that doesn't support any LPM states will take the exact same code paths as a port that is external/hot plug capable. Side note: the port in ata_port_dbg() has not been given a unique id yet, but this is not overly important as the debug print is disabled unless explicitly enabled using dynamic debug. A follow-up series will make sure that the unique id assignment will be done earlier. For now, the important thing is that the function returns before setting the LPM policy. Fixes: 7627a0edef ("ata: ahci: Drop low power policy board type") Cc: stable@vger.kernel.org Reviewed-by: Mario Limonciello <mario.limonciello@amd.com> Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com> Reviewed-by: Damien Le Moal <dlemoal@kernel.org> Link: https://lore.kernel.org/r/20240618152828.2686771-2-cassel@kernel.org Signed-off-by: Niklas Cassel <cassel@kernel.org>		2024-06-19 13:19:38 +02:00
..
pata_parport	ata: pata_parport: make pata_parport_bus_type const	2024-02-06 10:41:57 +01:00
acard-ahci.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
ahci.c	ata: ahci: Do not enable LPM if no LPM states are supported by the HBA	2024-06-19 13:19:38 +02:00
ahci.h	scsi: libata: Switch to using ->device_configure	2024-04-11 21:37:50 -04:00
ahci_brcm.c	ata: libata: Make ata_platform_remove_one return void	2023-05-15 06:49:39 +09:00
ahci_ceva.c	ata: ahci_ceva: fix error handling for Xilinx GT PHY support	2024-02-19 10:44:37 +01:00
ahci_da850.c	ata: libata: Make ata_platform_remove_one return void	2023-05-15 06:49:39 +09:00
ahci_dm816.c	ata: libata: Make ata_platform_remove_one return void	2023-05-15 06:49:39 +09:00
ahci_dwc.c	ata: Explicitly include correct DT includes	2023-08-02 17:37:05 +09:00
ahci_imx.c	ata: imx: Use device_get_match_data()	2023-10-11 17:54:05 +09:00
ahci_mtk.c	ata: Explicitly include correct DT includes	2023-08-02 17:37:05 +09:00
ahci_mvebu.c	ata: Explicitly include correct DT includes	2023-08-02 17:37:05 +09:00
ahci_octeon.c	ata: ahci_octeon: Convert to devm_platform_ioremap_resource()	2023-08-02 17:37:06 +09:00
ahci_platform.c	driver core changes for 6.5-rc1	2023-07-03 12:56:23 -07:00
ahci_qoriq.c	ata: fix debounce timings type	2023-08-02 17:37:06 +09:00
ahci_seattle.c	ata: ahci_seattle: Convert to devm_platform_ioremap_resource()	2023-08-02 17:37:06 +09:00
ahci_st.c	ata: ahci_st: Remove an unused field in struct st_ahci_drv_data	2024-04-02 12:18:15 +09:00
ahci_sunxi.c	ata: Explicitly include correct DT includes	2023-08-02 17:37:05 +09:00
ahci_tegra.c	ata: ahci_tegra: Convert to devm_platform_ioremap_resource()	2023-08-02 17:37:06 +09:00
ahci_xgene.c	ata: xgene: Use of_device_get_match_data()	2023-10-11 17:53:37 +09:00
ata_generic.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
ata_piix.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
Kconfig	ata: add HAS_IOPORT dependencies	2024-04-08 10:07:28 +09:00
libahci.c	ahci: print the number of implemented ports	2024-02-21 19:13:43 +01:00
libahci_platform.c	ata: Explicitly include correct DT includes	2023-08-02 17:37:05 +09:00
libata-acpi.c
libata-core.c	ata: libata-core: Add ATA_HORKAGE_NOLPM for Apacer AS340	2024-05-31 15:14:06 +02:00
libata-eh.c	scsi: sd: Fix TCG OPAL unlock on system resume	2024-03-25 15:46:12 -04:00
libata-pata-timings.c
libata-pmp.c
libata-sata.c	scsi: libata: Switch to using ->device_configure	2024-04-11 21:37:50 -04:00
libata-scsi.c	ata: libata-scsi: Set the RMB bit only for removable media devices	2024-06-14 14:18:46 +02:00
libata-sff.c	ata: add HAS_IOPORT dependencies	2024-04-08 10:07:28 +09:00
libata-trace.c
libata-transport.c	ata: libata-core: Do not register PM operations for SAS ports	2023-09-28 21:23:14 +09:00
libata-transport.h
libata-zpodd.c
libata.h	SCSI misc on 20240514	2024-05-14 18:25:53 -07:00
Makefile
pata_acpi.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_ali.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_amd.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_arasan_cf.c	ata: pata_arasan_cf: Convert to platform remove callback returning void	2023-08-02 17:53:09 +09:00
pata_artop.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_atiixp.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_atp867x.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_buddha.c	ata: pata_buddha: Remove #include <asm/ide.h>	2023-08-24 08:09:59 +09:00
pata_cmd64x.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_cmd640.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_cs5520.c	ata: pata_cs5520: Remove unnecessary call to pci_enable_device_io()	2024-05-16 14:35:08 -05:00
pata_cs5530.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_cs5535.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_cs5536.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_cypress.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_efar.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_ep93xx.c	ata: pata_ep93xx: use soc_device_match for UDMA modes	2023-08-25 22:09:43 +09:00
pata_falcon.c	ata: pata_falcon: Convert to platform remove callback returning void	2023-11-08 09:00:44 +09:00
pata_ftide010.c	ata: pata_ftide010: Add missing MODULE_DESCRIPTION	2023-08-25 08:21:03 +09:00
pata_gayle.c	ata: pata_gayle: Convert to platform remove callback returning void	2023-11-08 09:00:49 +09:00
pata_hpt3x2n.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_hpt3x3.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_hpt37x.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_hpt366.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_icside.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_imx.c	ata: pata_imx: Use helper function devm_clk_get_enabled()	2023-08-17 07:45:32 +09:00
pata_isapnp.c	ata: pata_isapnp: Add missing error check for devm_ioport_map()	2023-11-20 09:22:26 +09:00
pata_it821x.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_it8213.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_ixp4xx_cf.c	ata: pata_ixp4xx: Remove unnecessary return value check	2023-08-02 17:37:06 +09:00
pata_jmicron.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_legacy.c	ata: pata_legacy: make legacy_exit() work again	2024-05-07 07:23:31 +09:00
pata_macio.c	ata: pata_macio: Fix max_segment_size with PAGE_SIZE == 64K	2024-06-06 14:53:34 +02:00
pata_marvell.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_mpc52xx.c	ata: pata_mpc52xx: Convert to platform remove callback returning void	2023-08-02 17:55:49 +09:00
pata_mpiix.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_netcell.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_ninja32.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_ns87410.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_ns87415.c	ata: pata_ns87415: mark ns87560_tf_read static	2023-07-28 08:52:42 +09:00
pata_octeon_cf.c	ata: pata_octeon_cf: fix error return code in octeon_cf_probe()	2023-07-26 08:32:21 +09:00
pata_of_platform.c	ata: libata: Make ata_platform_remove_one return void	2023-05-15 06:49:39 +09:00
pata_oldpiix.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_opti.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_optidma.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_pcmcia.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_pdc202xx_old.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_pdc2027x.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_piccolo.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_platform.c	ata: libata: Make ata_platform_remove_one return void	2023-05-15 06:49:39 +09:00
pata_pxa.c	ata: pata_pxa: convert not to use dma_request_slave_channel()	2023-11-20 09:28:25 +09:00
pata_radisys.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_rb532_cf.c	ata: pata_rb532_cf: Convert to platform remove callback returning void	2023-08-02 17:55:52 +09:00
pata_rdc.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_rz1000.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_sc1200.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_sch.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_serverworks.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_sil680.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_sis.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_sl82c105.c	ata: libata: remove deprecated EH callbacks	2023-08-02 17:45:42 +09:00
pata_triflex.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pata_via.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
pdc_adma.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
sata_dwc_460ex.c	ata: sata_dwc_460ex: Convert to platform remove callback returning void	2023-08-02 17:55:52 +09:00
sata_fsl.c	ata: sata_fsl: Convert to platform remove callback returning void	2023-08-02 17:55:52 +09:00
sata_gemini.c	ata: sata_gemini: Check clk_enable() result	2024-04-04 12:42:00 +09:00
sata_gemini.h
sata_highbank.c	ata: fix debounce timings type	2023-08-02 17:37:06 +09:00
sata_inic162x.c	ata: fix debounce timings type	2023-08-02 17:37:06 +09:00
sata_mv.c	SCSI misc on 20240514	2024-05-14 18:25:53 -07:00
sata_nv.c	scsi: libata: Switch to using ->device_configure	2024-04-11 21:37:50 -04:00
sata_promise.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
sata_promise.h
sata_qstor.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
sata_rcar.c	ata: sata_rcar: Convert to platform remove callback returning void	2023-08-02 17:55:52 +09:00
sata_sil.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
sata_sil24.c	scsi: libata: Switch to using ->device_configure	2024-04-11 21:37:50 -04:00
sata_sis.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
sata_svw.c	ata: Use of_property_read_reg() to parse "reg"	2023-06-13 15:38:48 +09:00
sata_sx4.c	ata: sata_sx4: fix pdc20621_get_from_dimm() on 64-bit	2024-04-01 07:52:17 +09:00
sata_uli.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
sata_via.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
sata_vsc.c	scsi: ata: Declare SCSI host templates const	2023-03-24 19:19:19 -04:00
sis.h