Takashi Iwai fc27fe7e8d ALSA: seq: Cancel pending autoload work at unbinding device ... ALSA sequencer core has a mechanism to load the enumerated devices automatically, and it's performed in an off-load work. This seems causing some race when a sequencer is removed while the pending autoload work is running. As syzkaller spotted, it may lead to some use-after-free: BUG: KASAN: use-after-free in snd_rawmidi_dev_seq_free+0x69/0x70 sound/core/rawmidi.c:1617 Write of size 8 at addr ffff88006c611d90 by task kworker/2:1/567 CPU: 2 PID: 567 Comm: kworker/2:1 Not tainted 4.13.0+ #29 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Bochs 01/01/2011 Workqueue: events autoload_drivers Call Trace: __dump_stack lib/dump_stack.c:16 [inline] dump_stack+0x192/0x22c lib/dump_stack.c:52 print_address_description+0x78/0x280 mm/kasan/report.c:252 kasan_report_error mm/kasan/report.c:351 [inline] kasan_report+0x230/0x340 mm/kasan/report.c:409 __asan_report_store8_noabort+0x1c/0x20 mm/kasan/report.c:435 snd_rawmidi_dev_seq_free+0x69/0x70 sound/core/rawmidi.c:1617 snd_seq_dev_release+0x4f/0x70 sound/core/seq_device.c:192 device_release+0x13f/0x210 drivers/base/core.c:814 kobject_cleanup lib/kobject.c:648 [inline] kobject_release lib/kobject.c:677 [inline] kref_put include/linux/kref.h:70 [inline] kobject_put+0x145/0x240 lib/kobject.c:694 put_device+0x25/0x30 drivers/base/core.c:1799 klist_devices_put+0x36/0x40 drivers/base/bus.c:827 klist_next+0x264/0x4a0 lib/klist.c:403 next_device drivers/base/bus.c:270 [inline] bus_for_each_dev+0x17e/0x210 drivers/base/bus.c:312 autoload_drivers+0x3b/0x50 sound/core/seq_device.c:117 process_one_work+0x9fb/0x1570 kernel/workqueue.c:2097 worker_thread+0x1e4/0x1350 kernel/workqueue.c:2231 kthread+0x324/0x3f0 kernel/kthread.c:231 ret_from_fork+0x25/0x30 arch/x86/entry/entry_64.S:425 The fix is simply to assure canceling the autoload work at removing the device. Reported-by: Andrey Konovalov <andreyknvl@google.com> Tested-by: Andrey Konovalov <andreyknvl@google.com> Cc: <stable@vger.kernel.org> Signed-off-by: Takashi Iwai <tiwai@suse.de>		2017-09-12 12:41:20 +02:00
..
oss
seq
compress_offload.c
control.c	ALSA: Get rid of card power_lock	2017-08-30 20:44:29 +02:00
control_compat.c	ALSA: Get rid of card power_lock	2017-08-30 20:44:29 +02:00
ctljack.c
device.c	ALSA: core: Use %pS printk format for direct addresses	2017-09-07 10:36:02 +02:00
hrtimer.c
hwdep.c
hwdep_compat.c
info.c
info_oss.c
init.c	ALSA: Get rid of card power_lock	2017-08-30 20:44:29 +02:00
isadma.c
jack.c
Kconfig
Makefile
memalloc.c
memory.c
misc.c
pcm.c	ALSA: pcm: Correct broken procfs set up	2017-08-25 00:05:16 +02:00
pcm_compat.c	ALSA: pcm: Unify ioctl functions for playback and capture streams	2017-08-30 20:44:55 +02:00
pcm_dmaengine.c
pcm_drm_eld.c
pcm_iec958.c
pcm_lib.c
pcm_local.h
pcm_memory.c
pcm_misc.c
pcm_native.c	ALSA: pcm: Unify ioctl functions for playback and capture streams	2017-08-30 20:44:55 +02:00
pcm_param_trace.h
pcm_timer.c
pcm_trace.h
rawmidi.c
rawmidi_compat.c
seq_device.c	ALSA: seq: Cancel pending autoload work at unbinding device	2017-09-12 12:41:20 +02:00
sgbuf.c
sound.c
sound_oss.c
timer.c	ALSA: timer: Use common error handling code in alsa_timer_init()	2017-08-23 10:39:09 +02:00
timer_compat.c
vmaster.c