Justin Stitt e0bbf92682 um,ethertap: Replace deprecated strncpy() with strscpy() ... `strncpy` is deprecated for use on NUL-terminated destination strings [1]. `gate_buf` should always be NUL-terminated and does not require NUL-padding. It is used as a string arg inside an argv array given to `run_helper()`. Due to this, let's use `strscpy` as it guarantees NUL-terminated on the destination buffer preventing potential buffer overreads [2]. This exact invocation was changed from `strcpy` to `strncpy` in commit 7879b1d94b ("um,ethertap: use strncpy") back in 2015. Let's continue hardening our `str*cpy` apis and use the newer and safer `strscpy`! Link: www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings[1] Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html [2] Link: https://github.com/KSPP/linux/issues/90 Cc: linux-hardening@vger.kernel.org Cc: Kees Cook <keescook@chromium.org> Signed-off-by: Justin Stitt <justinstitt@google.com> Reviewed-by: Kees Cook <keescook@chromium.org> Link: https://lore.kernel.org/r/20230911-strncpy-arch-um-os-linux-drivers-ethertap_user-c-v1-1-d9e53f52ab32@google.com Signed-off-by: Kees Cook <keescook@chromium.org>		2023-09-29 11:37:50 -07:00
..
etap.h	um: Add SPDX headers for files in arch/um/os-Linux	2019-09-15 21:37:17 +02:00
ethertap_kern.c	um: Add SPDX headers for files in arch/um/os-Linux	2019-09-15 21:37:17 +02:00
ethertap_user.c	um,ethertap: Replace deprecated strncpy() with strscpy()	2023-09-29 11:37:50 -07:00
Makefile	kbuild: remove --include-dir MAKEFLAG from top Makefile	2023-02-05 18:51:22 +09:00
tuntap.h	um: Add SPDX headers for files in arch/um/os-Linux	2019-09-15 21:37:17 +02:00
tuntap_kern.c	um: Add SPDX headers for files in arch/um/os-Linux	2019-09-15 21:37:17 +02:00
tuntap_user.c	uml: Replace strlcpy with strscpy	2023-06-20 13:35:37 -07:00