mirror of
https://github.com/torvalds/linux
synced 2024-11-05 18:23:50 +00:00
65319890c3
Especially when CONFIG_LOCKDEP and other debug configs are enabled,
Perf can print the following warning when running the "kernel lock
contention analysis" test:
Warning:
Processed 1378918 events and lost 4 chunks!
Check IO/CPU overload!
Warning:
Processed 4593325 samples and lost 70.00%!
The test already supplies -q to run in quiet mode, so extend quiet mode
to perf_stdio__warning() and also ui__warning() for consistency.
This fixes the following failure due to the extra lines counted:
perf test "lock cont" -vvv
82: kernel lock contention analysis test :
--- start ---
test child forked, pid 3125
Testing perf lock record and perf lock contention
[Fail] Recorded result count is not 1: 9
test child finished with -1
---- end ----
kernel lock contention analysis test: FAILED!
Fixes: ec685de25b ("perf test: Add kernel lock contention test")
Signed-off-by: James Clark <james.clark@arm.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Ian Rogers <irogers@google.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://lore.kernel.org/r/20221018094137.783081-2-james.clark@arm.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
90 lines
1.7 KiB
C
90 lines
1.7 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
#include "util.h"
|
|
#include "../util/debug.h"
|
|
#include <stdio.h>
|
|
|
|
/*
|
|
* Default error logging functions
|
|
*/
|
|
static int perf_stdio__error(const char *format, va_list args)
|
|
{
|
|
fprintf(stderr, "Error:\n");
|
|
vfprintf(stderr, format, args);
|
|
return 0;
|
|
}
|
|
|
|
static int perf_stdio__warning(const char *format, va_list args)
|
|
{
|
|
if (quiet)
|
|
return 0;
|
|
|
|
fprintf(stderr, "Warning:\n");
|
|
vfprintf(stderr, format, args);
|
|
return 0;
|
|
}
|
|
|
|
static struct perf_error_ops default_eops =
|
|
{
|
|
.error = perf_stdio__error,
|
|
.warning = perf_stdio__warning,
|
|
};
|
|
|
|
static struct perf_error_ops *perf_eops = &default_eops;
|
|
|
|
|
|
int ui__error(const char *format, ...)
|
|
{
|
|
int ret;
|
|
va_list args;
|
|
|
|
va_start(args, format);
|
|
ret = perf_eops->error(format, args);
|
|
va_end(args);
|
|
|
|
return ret;
|
|
}
|
|
|
|
int ui__warning(const char *format, ...)
|
|
{
|
|
int ret;
|
|
va_list args;
|
|
if (quiet)
|
|
return 0;
|
|
|
|
va_start(args, format);
|
|
ret = perf_eops->warning(format, args);
|
|
va_end(args);
|
|
|
|
return ret;
|
|
}
|
|
|
|
/**
|
|
* perf_error__register - Register error logging functions
|
|
* @eops: The pointer to error logging function struct
|
|
*
|
|
* Register UI-specific error logging functions. Before calling this,
|
|
* other logging functions should be unregistered, if any.
|
|
*/
|
|
int perf_error__register(struct perf_error_ops *eops)
|
|
{
|
|
if (perf_eops != &default_eops)
|
|
return -1;
|
|
|
|
perf_eops = eops;
|
|
return 0;
|
|
}
|
|
|
|
/**
|
|
* perf_error__unregister - Unregister error logging functions
|
|
* @eops: The pointer to error logging function struct
|
|
*
|
|
* Unregister already registered error logging functions.
|
|
*/
|
|
int perf_error__unregister(struct perf_error_ops *eops)
|
|
{
|
|
if (perf_eops != eops)
|
|
return -1;
|
|
|
|
perf_eops = &default_eops;
|
|
return 0;
|
|
}
|