mirror of
https://github.com/torvalds/linux
synced 2024-11-05 18:23:50 +00:00
297d716f62
Change the ownership of power_supply structure from each driver implementing the class to the power supply core. The patch changes power_supply_register() function thus all drivers implementing power supply class are adjusted. Each driver provides the implementation of power supply. However it should not be the owner of power supply class instance because it is exposed by core to other subsystems with power_supply_get_by_name(). These other subsystems have no knowledge when the driver will unregister the power supply. This leads to several issues when driver is unbound - mostly because user of power supply accesses freed memory. Instead let the core own the instance of struct 'power_supply'. Other users of this power supply will still access valid memory because it will be freed when device reference count reaches 0. Currently this means "it will leak" but power_supply_put() call in next patches will solve it. This solves invalid memory references in following race condition scenario: Thread 1: charger manager Thread 2: power supply driver, used by charger manager THREAD 1 (charger manager) THREAD 2 (power supply driver) ========================== ============================== psy = power_supply_get_by_name() Driver unbind, .remove power_supply_unregister() Device fully removed psy->get_property() The 'get_property' call is executed in invalid context because the driver was unbound and struct 'power_supply' memory was freed. This could be observed easily with charger manager driver (here compiled with max17040 fuel gauge): $ cat /sys/devices/virtual/power_supply/cm-battery/capacity & $ echo "1-0036" > /sys/bus/i2c/drivers/max17040/unbind [ 55.725123] Unable to handle kernel NULL pointer dereference at virtual address 00000000 [ 55.732584] pgd = d98d4000 [ 55.734060] [00000000] *pgd=5afa2831, *pte=00000000, *ppte=00000000 [ 55.740318] Internal error: Oops: 80000007 [#1] PREEMPT SMP ARM [ 55.746210] Modules linked in: [ 55.749259] CPU: 1 PID: 2936 Comm: cat Tainted: G W 3.19.0-rc1-next-20141226-00048-gf79f475f3c44-dirty #1496 [ 55.760190] Hardware name: SAMSUNG EXYNOS (Flattened Device Tree) [ 55.766270] task: d9b76f00 ti: daf54000 task.ti: daf54000 [ 55.771647] PC is at 0x0 [ 55.774182] LR is at charger_get_property+0x2f4/0x36c [ 55.779201] pc : [<00000000>] lr : [<c034b0b4>] psr: 60000013 [ 55.779201] sp : daf55e90 ip : 00000003 fp : 00000000 [ 55.790657] r10: 00000000 r9 : c06e2878 r8 : d9b26c68 [ 55.795865] r7 : dad81610 r6 : daec7410 r5 : daf55ebc r4 : 00000000 [ 55.802367] r3 : 00000000 r2 : daf55ebc r1 : 0000002a r0 : d9b26c68 [ 55.808879] Flags: nZCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment user [ 55.815994] Control: 10c5387d Table: 598d406a DAC: 00000015 [ 55.821723] Process cat (pid: 2936, stack limit = 0xdaf54210) [ 55.827451] Stack: (0xdaf55e90 to 0xdaf56000) [ 55.831795] 5e80: 60000013 c01459c4 0000002a c06f8ef8 [ 55.839956] 5ea0: db651000 c06f8ef8 daebac00 c04cb668 daebac08 c0346864 00000000 c01459c4 [ 55.848115] 5ec0: d99eaa80 c06f8ef8 00000fff 00001000 db651000 c027f25c c027f240 d99eaa80 [ 55.856274] 5ee0: d9a06c00 c0146218 daf55f18 00001000 d99eaa80 db4c18c0 00000001 00000001 [ 55.864468] 5f00: daf55f80 c0144c78 c0144c54 c0107f90 00015000 d99eaab0 00000000 00000000 [ 55.872603] 5f20: 000051c7 00000000 db4c18c0 c04a9370 00015000 00001000 daf55f80 00001000 [ 55.880763] 5f40: daf54000 00015000 00000000 c00e53dc db4c18c0 c00e548c 0000000d 00008124 [ 55.888937] 5f60: 00000001 00000000 00000000 db4c18c0 db4c18c0 00001000 00015000 c00e5550 [ 55.897099] 5f80: 00000000 00000000 00001000 00001000 00015000 00000003 00000003 c000f364 [ 55.905239] 5fa0: 00000000 c000f1a0 00001000 00015000 00000003 00015000 00001000 0001333c [ 55.913399] 5fc0: 00001000 00015000 00000003 00000003 00000002 00000000 00000000 00000000 [ 55.921560] 5fe0: 7fffe000 be999850 0000a225 b6f3c19c 60000010 00000003 00000000 00000000 [ 55.929744] [<c034b0b4>] (charger_get_property) from [<c0346864>] (power_supply_show_property+0x48/0x20c) [ 55.939286] [<c0346864>] (power_supply_show_property) from [<c027f25c>] (dev_attr_show+0x1c/0x48) [ 55.948130] [<c027f25c>] (dev_attr_show) from [<c0146218>] (sysfs_kf_seq_show+0x84/0x104) [ 55.956298] [<c0146218>] (sysfs_kf_seq_show) from [<c0144c78>] (kernfs_seq_show+0x24/0x28) [ 55.964536] [<c0144c78>] (kernfs_seq_show) from [<c0107f90>] (seq_read+0x1b0/0x484) [ 55.972172] [<c0107f90>] (seq_read) from [<c00e53dc>] (__vfs_read+0x18/0x4c) [ 55.979188] [<c00e53dc>] (__vfs_read) from [<c00e548c>] (vfs_read+0x7c/0x100) [ 55.986304] [<c00e548c>] (vfs_read) from [<c00e5550>] (SyS_read+0x40/0x8c) [ 55.993164] [<c00e5550>] (SyS_read) from [<c000f1a0>] (ret_fast_syscall+0x0/0x48) [ 56.000626] Code: bad PC value [ 56.011652] ---[ end trace 7b64343fbdae8ef1 ]--- Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> [for the nvec part] Reviewed-by: Marc Dietrich <marvin24@gmx.de> [for compal-laptop.c] Acked-by: Darren Hart <dvhart@linux.intel.com> [for the mfd part] Acked-by: Lee Jones <lee.jones@linaro.org> [for the hid part] Acked-by: Jiri Kosina <jkosina@suse.cz> [for the acpi part] Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Signed-off-by: Sebastian Reichel <sre@kernel.org>
432 lines
11 KiB
C
432 lines
11 KiB
C
/*
|
|
* Generic battery driver code using IIO
|
|
* Copyright (C) 2012, Anish Kumar <anish198519851985@gmail.com>
|
|
* based on jz4740-battery.c
|
|
* based on s3c_adc_battery.c
|
|
*
|
|
* This file is subject to the terms and conditions of the GNU General Public
|
|
* License. See the file COPYING in the main directory of this archive for
|
|
* more details.
|
|
*
|
|
*/
|
|
#include <linux/interrupt.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/power_supply.h>
|
|
#include <linux/gpio.h>
|
|
#include <linux/err.h>
|
|
#include <linux/timer.h>
|
|
#include <linux/jiffies.h>
|
|
#include <linux/errno.h>
|
|
#include <linux/init.h>
|
|
#include <linux/module.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/iio/consumer.h>
|
|
#include <linux/iio/types.h>
|
|
#include <linux/power/generic-adc-battery.h>
|
|
|
|
#define JITTER_DEFAULT 10 /* hope 10ms is enough */
|
|
|
|
enum gab_chan_type {
|
|
GAB_VOLTAGE = 0,
|
|
GAB_CURRENT,
|
|
GAB_POWER,
|
|
GAB_MAX_CHAN_TYPE
|
|
};
|
|
|
|
/*
|
|
* gab_chan_name suggests the standard channel names for commonly used
|
|
* channel types.
|
|
*/
|
|
static const char *const gab_chan_name[] = {
|
|
[GAB_VOLTAGE] = "voltage",
|
|
[GAB_CURRENT] = "current",
|
|
[GAB_POWER] = "power",
|
|
};
|
|
|
|
struct gab {
|
|
struct power_supply *psy;
|
|
struct power_supply_desc psy_desc;
|
|
struct iio_channel *channel[GAB_MAX_CHAN_TYPE];
|
|
struct gab_platform_data *pdata;
|
|
struct delayed_work bat_work;
|
|
int level;
|
|
int status;
|
|
bool cable_plugged;
|
|
};
|
|
|
|
static struct gab *to_generic_bat(struct power_supply *psy)
|
|
{
|
|
return power_supply_get_drvdata(psy);
|
|
}
|
|
|
|
static void gab_ext_power_changed(struct power_supply *psy)
|
|
{
|
|
struct gab *adc_bat = to_generic_bat(psy);
|
|
|
|
schedule_delayed_work(&adc_bat->bat_work, msecs_to_jiffies(0));
|
|
}
|
|
|
|
static const enum power_supply_property gab_props[] = {
|
|
POWER_SUPPLY_PROP_STATUS,
|
|
POWER_SUPPLY_PROP_CHARGE_FULL_DESIGN,
|
|
POWER_SUPPLY_PROP_CHARGE_EMPTY_DESIGN,
|
|
POWER_SUPPLY_PROP_CHARGE_NOW,
|
|
POWER_SUPPLY_PROP_VOLTAGE_NOW,
|
|
POWER_SUPPLY_PROP_CURRENT_NOW,
|
|
POWER_SUPPLY_PROP_TECHNOLOGY,
|
|
POWER_SUPPLY_PROP_VOLTAGE_MIN_DESIGN,
|
|
POWER_SUPPLY_PROP_VOLTAGE_MAX_DESIGN,
|
|
POWER_SUPPLY_PROP_MODEL_NAME,
|
|
};
|
|
|
|
/*
|
|
* This properties are set based on the received platform data and this
|
|
* should correspond one-to-one with enum chan_type.
|
|
*/
|
|
static const enum power_supply_property gab_dyn_props[] = {
|
|
POWER_SUPPLY_PROP_VOLTAGE_NOW,
|
|
POWER_SUPPLY_PROP_CURRENT_NOW,
|
|
POWER_SUPPLY_PROP_POWER_NOW,
|
|
};
|
|
|
|
static bool gab_charge_finished(struct gab *adc_bat)
|
|
{
|
|
struct gab_platform_data *pdata = adc_bat->pdata;
|
|
bool ret = gpio_get_value(pdata->gpio_charge_finished);
|
|
bool inv = pdata->gpio_inverted;
|
|
|
|
if (!gpio_is_valid(pdata->gpio_charge_finished))
|
|
return false;
|
|
return ret ^ inv;
|
|
}
|
|
|
|
static int gab_get_status(struct gab *adc_bat)
|
|
{
|
|
struct gab_platform_data *pdata = adc_bat->pdata;
|
|
struct power_supply_info *bat_info;
|
|
|
|
bat_info = &pdata->battery_info;
|
|
if (adc_bat->level == bat_info->charge_full_design)
|
|
return POWER_SUPPLY_STATUS_FULL;
|
|
return adc_bat->status;
|
|
}
|
|
|
|
static enum gab_chan_type gab_prop_to_chan(enum power_supply_property psp)
|
|
{
|
|
switch (psp) {
|
|
case POWER_SUPPLY_PROP_POWER_NOW:
|
|
return GAB_POWER;
|
|
case POWER_SUPPLY_PROP_VOLTAGE_NOW:
|
|
return GAB_VOLTAGE;
|
|
case POWER_SUPPLY_PROP_CURRENT_NOW:
|
|
return GAB_CURRENT;
|
|
default:
|
|
WARN_ON(1);
|
|
break;
|
|
}
|
|
return GAB_POWER;
|
|
}
|
|
|
|
static int read_channel(struct gab *adc_bat, enum power_supply_property psp,
|
|
int *result)
|
|
{
|
|
int ret;
|
|
int chan_index;
|
|
|
|
chan_index = gab_prop_to_chan(psp);
|
|
ret = iio_read_channel_processed(adc_bat->channel[chan_index],
|
|
result);
|
|
if (ret < 0)
|
|
pr_err("read channel error\n");
|
|
return ret;
|
|
}
|
|
|
|
static int gab_get_property(struct power_supply *psy,
|
|
enum power_supply_property psp, union power_supply_propval *val)
|
|
{
|
|
struct gab *adc_bat;
|
|
struct gab_platform_data *pdata;
|
|
struct power_supply_info *bat_info;
|
|
int result = 0;
|
|
int ret = 0;
|
|
|
|
adc_bat = to_generic_bat(psy);
|
|
if (!adc_bat) {
|
|
dev_err(&psy->dev, "no battery infos ?!\n");
|
|
return -EINVAL;
|
|
}
|
|
pdata = adc_bat->pdata;
|
|
bat_info = &pdata->battery_info;
|
|
|
|
switch (psp) {
|
|
case POWER_SUPPLY_PROP_STATUS:
|
|
val->intval = gab_get_status(adc_bat);
|
|
break;
|
|
case POWER_SUPPLY_PROP_CHARGE_EMPTY_DESIGN:
|
|
val->intval = 0;
|
|
break;
|
|
case POWER_SUPPLY_PROP_CHARGE_NOW:
|
|
val->intval = pdata->cal_charge(result);
|
|
break;
|
|
case POWER_SUPPLY_PROP_VOLTAGE_NOW:
|
|
case POWER_SUPPLY_PROP_CURRENT_NOW:
|
|
case POWER_SUPPLY_PROP_POWER_NOW:
|
|
ret = read_channel(adc_bat, psp, &result);
|
|
if (ret < 0)
|
|
goto err;
|
|
val->intval = result;
|
|
break;
|
|
case POWER_SUPPLY_PROP_TECHNOLOGY:
|
|
val->intval = bat_info->technology;
|
|
break;
|
|
case POWER_SUPPLY_PROP_VOLTAGE_MIN_DESIGN:
|
|
val->intval = bat_info->voltage_min_design;
|
|
break;
|
|
case POWER_SUPPLY_PROP_VOLTAGE_MAX_DESIGN:
|
|
val->intval = bat_info->voltage_max_design;
|
|
break;
|
|
case POWER_SUPPLY_PROP_CHARGE_FULL_DESIGN:
|
|
val->intval = bat_info->charge_full_design;
|
|
break;
|
|
case POWER_SUPPLY_PROP_MODEL_NAME:
|
|
val->strval = bat_info->name;
|
|
break;
|
|
default:
|
|
return -EINVAL;
|
|
}
|
|
err:
|
|
return ret;
|
|
}
|
|
|
|
static void gab_work(struct work_struct *work)
|
|
{
|
|
struct gab *adc_bat;
|
|
struct gab_platform_data *pdata;
|
|
struct delayed_work *delayed_work;
|
|
bool is_plugged;
|
|
int status;
|
|
|
|
delayed_work = container_of(work, struct delayed_work, work);
|
|
adc_bat = container_of(delayed_work, struct gab, bat_work);
|
|
pdata = adc_bat->pdata;
|
|
status = adc_bat->status;
|
|
|
|
is_plugged = power_supply_am_i_supplied(adc_bat->psy);
|
|
adc_bat->cable_plugged = is_plugged;
|
|
|
|
if (!is_plugged)
|
|
adc_bat->status = POWER_SUPPLY_STATUS_DISCHARGING;
|
|
else if (gab_charge_finished(adc_bat))
|
|
adc_bat->status = POWER_SUPPLY_STATUS_NOT_CHARGING;
|
|
else
|
|
adc_bat->status = POWER_SUPPLY_STATUS_CHARGING;
|
|
|
|
if (status != adc_bat->status)
|
|
power_supply_changed(adc_bat->psy);
|
|
}
|
|
|
|
static irqreturn_t gab_charged(int irq, void *dev_id)
|
|
{
|
|
struct gab *adc_bat = dev_id;
|
|
struct gab_platform_data *pdata = adc_bat->pdata;
|
|
int delay;
|
|
|
|
delay = pdata->jitter_delay ? pdata->jitter_delay : JITTER_DEFAULT;
|
|
schedule_delayed_work(&adc_bat->bat_work,
|
|
msecs_to_jiffies(delay));
|
|
return IRQ_HANDLED;
|
|
}
|
|
|
|
static int gab_probe(struct platform_device *pdev)
|
|
{
|
|
struct gab *adc_bat;
|
|
struct power_supply_desc *psy_desc;
|
|
struct power_supply_config psy_cfg = {};
|
|
struct gab_platform_data *pdata = pdev->dev.platform_data;
|
|
enum power_supply_property *properties;
|
|
int ret = 0;
|
|
int chan;
|
|
int index = 0;
|
|
|
|
adc_bat = devm_kzalloc(&pdev->dev, sizeof(*adc_bat), GFP_KERNEL);
|
|
if (!adc_bat) {
|
|
dev_err(&pdev->dev, "failed to allocate memory\n");
|
|
return -ENOMEM;
|
|
}
|
|
|
|
psy_cfg.drv_data = adc_bat;
|
|
psy_desc = &adc_bat->psy_desc;
|
|
psy_desc->name = pdata->battery_info.name;
|
|
|
|
/* bootup default values for the battery */
|
|
adc_bat->cable_plugged = false;
|
|
adc_bat->status = POWER_SUPPLY_STATUS_DISCHARGING;
|
|
psy_desc->type = POWER_SUPPLY_TYPE_BATTERY;
|
|
psy_desc->get_property = gab_get_property;
|
|
psy_desc->external_power_changed = gab_ext_power_changed;
|
|
adc_bat->pdata = pdata;
|
|
|
|
/*
|
|
* copying the static properties and allocating extra memory for holding
|
|
* the extra configurable properties received from platform data.
|
|
*/
|
|
psy_desc->properties = kcalloc(ARRAY_SIZE(gab_props) +
|
|
ARRAY_SIZE(gab_chan_name),
|
|
sizeof(*psy_desc->properties),
|
|
GFP_KERNEL);
|
|
if (!psy_desc->properties) {
|
|
ret = -ENOMEM;
|
|
goto first_mem_fail;
|
|
}
|
|
|
|
memcpy(psy_desc->properties, gab_props, sizeof(gab_props));
|
|
properties = (enum power_supply_property *)
|
|
((char *)psy_desc->properties + sizeof(gab_props));
|
|
|
|
/*
|
|
* getting channel from iio and copying the battery properties
|
|
* based on the channel supported by consumer device.
|
|
*/
|
|
for (chan = 0; chan < ARRAY_SIZE(gab_chan_name); chan++) {
|
|
adc_bat->channel[chan] = iio_channel_get(&pdev->dev,
|
|
gab_chan_name[chan]);
|
|
if (IS_ERR(adc_bat->channel[chan])) {
|
|
ret = PTR_ERR(adc_bat->channel[chan]);
|
|
adc_bat->channel[chan] = NULL;
|
|
} else {
|
|
/* copying properties for supported channels only */
|
|
memcpy(properties + sizeof(*(psy_desc->properties)) * index,
|
|
&gab_dyn_props[chan],
|
|
sizeof(gab_dyn_props[chan]));
|
|
index++;
|
|
}
|
|
}
|
|
|
|
/* none of the channels are supported so let's bail out */
|
|
if (index == 0) {
|
|
ret = -ENODEV;
|
|
goto second_mem_fail;
|
|
}
|
|
|
|
/*
|
|
* Total number of properties is equal to static properties
|
|
* plus the dynamic properties.Some properties may not be set
|
|
* as come channels may be not be supported by the device.So
|
|
* we need to take care of that.
|
|
*/
|
|
psy_desc->num_properties = ARRAY_SIZE(gab_props) + index;
|
|
|
|
adc_bat->psy = power_supply_register(&pdev->dev, psy_desc, &psy_cfg);
|
|
if (IS_ERR(adc_bat->psy)) {
|
|
ret = PTR_ERR(adc_bat->psy);
|
|
goto err_reg_fail;
|
|
}
|
|
|
|
INIT_DELAYED_WORK(&adc_bat->bat_work, gab_work);
|
|
|
|
if (gpio_is_valid(pdata->gpio_charge_finished)) {
|
|
int irq;
|
|
ret = gpio_request(pdata->gpio_charge_finished, "charged");
|
|
if (ret)
|
|
goto gpio_req_fail;
|
|
|
|
irq = gpio_to_irq(pdata->gpio_charge_finished);
|
|
ret = request_any_context_irq(irq, gab_charged,
|
|
IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING,
|
|
"battery charged", adc_bat);
|
|
if (ret < 0)
|
|
goto err_gpio;
|
|
}
|
|
|
|
platform_set_drvdata(pdev, adc_bat);
|
|
|
|
/* Schedule timer to check current status */
|
|
schedule_delayed_work(&adc_bat->bat_work,
|
|
msecs_to_jiffies(0));
|
|
return 0;
|
|
|
|
err_gpio:
|
|
gpio_free(pdata->gpio_charge_finished);
|
|
gpio_req_fail:
|
|
power_supply_unregister(adc_bat->psy);
|
|
err_reg_fail:
|
|
for (chan = 0; chan < ARRAY_SIZE(gab_chan_name); chan++) {
|
|
if (adc_bat->channel[chan])
|
|
iio_channel_release(adc_bat->channel[chan]);
|
|
}
|
|
second_mem_fail:
|
|
kfree(psy_desc->properties);
|
|
first_mem_fail:
|
|
return ret;
|
|
}
|
|
|
|
static int gab_remove(struct platform_device *pdev)
|
|
{
|
|
int chan;
|
|
struct gab *adc_bat = platform_get_drvdata(pdev);
|
|
struct gab_platform_data *pdata = adc_bat->pdata;
|
|
|
|
power_supply_unregister(adc_bat->psy);
|
|
|
|
if (gpio_is_valid(pdata->gpio_charge_finished)) {
|
|
free_irq(gpio_to_irq(pdata->gpio_charge_finished), adc_bat);
|
|
gpio_free(pdata->gpio_charge_finished);
|
|
}
|
|
|
|
for (chan = 0; chan < ARRAY_SIZE(gab_chan_name); chan++) {
|
|
if (adc_bat->channel[chan])
|
|
iio_channel_release(adc_bat->channel[chan]);
|
|
}
|
|
|
|
kfree(adc_bat->psy_desc.properties);
|
|
cancel_delayed_work(&adc_bat->bat_work);
|
|
return 0;
|
|
}
|
|
|
|
#ifdef CONFIG_PM
|
|
static int gab_suspend(struct device *dev)
|
|
{
|
|
struct gab *adc_bat = dev_get_drvdata(dev);
|
|
|
|
cancel_delayed_work_sync(&adc_bat->bat_work);
|
|
adc_bat->status = POWER_SUPPLY_STATUS_UNKNOWN;
|
|
return 0;
|
|
}
|
|
|
|
static int gab_resume(struct device *dev)
|
|
{
|
|
struct gab *adc_bat = dev_get_drvdata(dev);
|
|
struct gab_platform_data *pdata = adc_bat->pdata;
|
|
int delay;
|
|
|
|
delay = pdata->jitter_delay ? pdata->jitter_delay : JITTER_DEFAULT;
|
|
|
|
/* Schedule timer to check current status */
|
|
schedule_delayed_work(&adc_bat->bat_work,
|
|
msecs_to_jiffies(delay));
|
|
return 0;
|
|
}
|
|
|
|
static const struct dev_pm_ops gab_pm_ops = {
|
|
.suspend = gab_suspend,
|
|
.resume = gab_resume,
|
|
};
|
|
|
|
#define GAB_PM_OPS (&gab_pm_ops)
|
|
#else
|
|
#define GAB_PM_OPS (NULL)
|
|
#endif
|
|
|
|
static struct platform_driver gab_driver = {
|
|
.driver = {
|
|
.name = "generic-adc-battery",
|
|
.pm = GAB_PM_OPS
|
|
},
|
|
.probe = gab_probe,
|
|
.remove = gab_remove,
|
|
};
|
|
module_platform_driver(gab_driver);
|
|
|
|
MODULE_AUTHOR("anish kumar <anish198519851985@gmail.com>");
|
|
MODULE_DESCRIPTION("generic battery driver using IIO");
|
|
MODULE_LICENSE("GPL");
|