mirror of
https://github.com/torvalds/linux
synced 2024-09-16 00:58:07 +00:00
3ae3cf418a
spmi_controller_alloc() currently returns NULL to all types of errors, which can be improved. Use appropriate error code in returns and pass the errors from used functions where possible. Signed-off-by: Fei Shao <fshao@chromium.org> Link: https://lore.kernel.org/r/20230824104101.4083400-6-fshao@chromium.org Signed-off-by: Stephen Boyd <sboyd@kernel.org> Link: https://lore.kernel.org/r/20231206231733.4031901-8-sboyd@kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
65 lines
1.3 KiB
C
65 lines
1.3 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* Copyright 2023 Google LLC.
|
|
*/
|
|
|
|
#include <linux/device.h>
|
|
#include <linux/spmi.h>
|
|
|
|
static void devm_spmi_controller_release(struct device *parent, void *res)
|
|
{
|
|
spmi_controller_put(*(struct spmi_controller **)res);
|
|
}
|
|
|
|
struct spmi_controller *devm_spmi_controller_alloc(struct device *parent, size_t size)
|
|
{
|
|
struct spmi_controller **ptr, *ctrl;
|
|
|
|
ptr = devres_alloc(devm_spmi_controller_release, sizeof(*ptr), GFP_KERNEL);
|
|
if (!ptr)
|
|
return ERR_PTR(-ENOMEM);
|
|
|
|
ctrl = spmi_controller_alloc(parent, size);
|
|
if (IS_ERR(ctrl)) {
|
|
devres_free(ptr);
|
|
return ctrl;
|
|
}
|
|
|
|
*ptr = ctrl;
|
|
devres_add(parent, ptr);
|
|
|
|
return ctrl;
|
|
}
|
|
EXPORT_SYMBOL_GPL(devm_spmi_controller_alloc);
|
|
|
|
static void devm_spmi_controller_remove(struct device *parent, void *res)
|
|
{
|
|
spmi_controller_remove(*(struct spmi_controller **)res);
|
|
}
|
|
|
|
int devm_spmi_controller_add(struct device *parent, struct spmi_controller *ctrl)
|
|
{
|
|
struct spmi_controller **ptr;
|
|
int ret;
|
|
|
|
ptr = devres_alloc(devm_spmi_controller_remove, sizeof(*ptr), GFP_KERNEL);
|
|
if (!ptr)
|
|
return -ENOMEM;
|
|
|
|
ret = spmi_controller_add(ctrl);
|
|
if (ret) {
|
|
devres_free(ptr);
|
|
return ret;
|
|
}
|
|
|
|
*ptr = ctrl;
|
|
devres_add(parent, ptr);
|
|
|
|
return 0;
|
|
|
|
}
|
|
EXPORT_SYMBOL_GPL(devm_spmi_controller_add);
|
|
|
|
MODULE_LICENSE("GPL");
|
|
MODULE_DESCRIPTION("SPMI devres helpers");
|