mirror of
https://github.com/torvalds/linux
synced 2024-10-04 02:10:58 +00:00
47512cfd0d
The goldfish platform code registers the platform device unconditionally
which causes havoc in several ways if the goldfish_pdev_bus driver is
enabled:
- Access to the hardcoded physical memory region, which is either not
available or contains stuff which is completely unrelated.
- Prevents that the interrupt of the serial port can be requested
- In case of a spurious interrupt it goes into a infinite loop in the
interrupt handler of the pdev_bus driver (which needs to be fixed
seperately).
Add a 'goldfish' command line option to make the registration opt-in when
the platform is compiled in.
I'm seriously grumpy about this engineering trainwreck, which has seven
SOBs from Intel developers for 50 lines of code. And none of them figured
out that this is broken. Impressive fail!
Fixes: ddd70cf93d ("goldfish: platform device for x86")
Reported-by: Gabriel C <nix.or.die@gmail.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: stable@vger.kernel.org
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
64 lines
1.5 KiB
C
64 lines
1.5 KiB
C
/*
|
|
* Copyright (C) 2007 Google, Inc.
|
|
* Copyright (C) 2011 Intel, Inc.
|
|
* Copyright (C) 2013 Intel, Inc.
|
|
*
|
|
* This software is licensed under the terms of the GNU General Public
|
|
* License version 2, as published by the Free Software Foundation, and
|
|
* may be copied, distributed, and modified under those terms.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
*/
|
|
|
|
#include <linux/kernel.h>
|
|
#include <linux/irq.h>
|
|
#include <linux/platform_device.h>
|
|
|
|
/*
|
|
* Where in virtual device memory the IO devices (timers, system controllers
|
|
* and so on)
|
|
*/
|
|
|
|
#define GOLDFISH_PDEV_BUS_BASE (0xff001000)
|
|
#define GOLDFISH_PDEV_BUS_END (0xff7fffff)
|
|
#define GOLDFISH_PDEV_BUS_IRQ (4)
|
|
|
|
#define GOLDFISH_TTY_BASE (0x2000)
|
|
|
|
static struct resource goldfish_pdev_bus_resources[] = {
|
|
{
|
|
.start = GOLDFISH_PDEV_BUS_BASE,
|
|
.end = GOLDFISH_PDEV_BUS_END,
|
|
.flags = IORESOURCE_MEM,
|
|
},
|
|
{
|
|
.start = GOLDFISH_PDEV_BUS_IRQ,
|
|
.end = GOLDFISH_PDEV_BUS_IRQ,
|
|
.flags = IORESOURCE_IRQ,
|
|
}
|
|
};
|
|
|
|
static bool goldfish_enable __initdata;
|
|
|
|
static int __init goldfish_setup(char *str)
|
|
{
|
|
goldfish_enable = true;
|
|
return 0;
|
|
}
|
|
__setup("goldfish", goldfish_setup);
|
|
|
|
static int __init goldfish_init(void)
|
|
{
|
|
if (!goldfish_enable)
|
|
return -ENODEV;
|
|
|
|
platform_device_register_simple("goldfish_pdev_bus", -1,
|
|
goldfish_pdev_bus_resources, 2);
|
|
return 0;
|
|
}
|
|
device_initcall(goldfish_init);
|