mirror of
https://github.com/torvalds/linux
synced 2024-10-07 11:53:31 +00:00
e82882cdd2
This WMI driver for the tablet mode control switch for Lenovo Yoga notebooks was originally written by Gergo Koteles. The mode is mapped to a SW_TABLET_MODE switch capable input device. Andrew followed the suggestions that were posted in reply to Gergo's RFC patch, and on the v1 & v2 versions of this patch to follow-up and get it merged. Changes from Gergo's RFC: - Refactored obtaining a reference to the EC ACPI device needed for the quirk implementation as suggested by Hans de Goede - Applied small fixes and switched to always registering handles with the driver for automatic cleanup as suggested by Barnabás Pőcze. - Merged the lenovo_ymc_trigger_ec function with the ideapad_trigger_ymc_next_read function since it was no longer external. - Added the word "Tablet" to the driver description to hopefully make it more clear. - Fixed the LENOVO_YMC_QUERY_METHOD ID and the name string for the EC APCI device trigged for the quirk - Triggered the input event on probe so that the initial tablet mode state when the driver is loaded is reported to userspace as suggested by Armin Wolf. - Restricted the permissions of the ec_trigger parameter as suggested by Armin Wolf. Also updated the description. We have tested this on the Yoga 7 14AIL7 for the non-quirk path and on the Yoga 7 14ARB7 which has the firmware bug that requires triggering the embedded controller to send the mode change events. This workaround is also used by the Windows drivers. According to reports at https://github.com/lukas-w/yoga-usage-mode, which uses the same WMI devices, the following models should also work: Yoga C940, Ideapad flex 14API, Yoga 9 14IAP7, Yoga 7 14ARB7, etc. Signed-off-by: Gergo Koteles <soyer@irl.hu> Co-developed-by: Andrew Kallmeyer <kallmeyeras@gmail.com> Signed-off-by: Andrew Kallmeyer <kallmeyeras@gmail.com> Link: https://lore.kernel.org/r/20221004214332.35934-1-soyer@irl.hu/ Link: https://lore.kernel.org/r/20230310041726.217447-1-kallmeyeras@gmail.com/ Link: https://lore.kernel.org/r/20230323025200.5462-1-kallmeyeras@gmail.com/ Tested-by: André Apitzsch <git@apitzsch.eu> Link: https://lore.kernel.org/r/20230329014559.44494-3-kallmeyeras@gmail.com Reviewed-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
153 lines
3 KiB
C
153 lines
3 KiB
C
/* SPDX-License-Identifier: GPL-2.0-or-later */
|
|
/*
|
|
* ideapad-laptop.h - Lenovo IdeaPad ACPI Extras
|
|
*
|
|
* Copyright © 2010 Intel Corporation
|
|
* Copyright © 2010 David Woodhouse <dwmw2@infradead.org>
|
|
*/
|
|
|
|
#ifndef _IDEAPAD_LAPTOP_H_
|
|
#define _IDEAPAD_LAPTOP_H_
|
|
|
|
#include <linux/acpi.h>
|
|
#include <linux/jiffies.h>
|
|
#include <linux/errno.h>
|
|
|
|
enum {
|
|
VPCCMD_R_VPC1 = 0x10,
|
|
VPCCMD_R_BL_MAX,
|
|
VPCCMD_R_BL,
|
|
VPCCMD_W_BL,
|
|
VPCCMD_R_WIFI,
|
|
VPCCMD_W_WIFI,
|
|
VPCCMD_R_BT,
|
|
VPCCMD_W_BT,
|
|
VPCCMD_R_BL_POWER,
|
|
VPCCMD_R_NOVO,
|
|
VPCCMD_R_VPC2,
|
|
VPCCMD_R_TOUCHPAD,
|
|
VPCCMD_W_TOUCHPAD,
|
|
VPCCMD_R_CAMERA,
|
|
VPCCMD_W_CAMERA,
|
|
VPCCMD_R_3G,
|
|
VPCCMD_W_3G,
|
|
VPCCMD_R_ODD, /* 0x21 */
|
|
VPCCMD_W_FAN,
|
|
VPCCMD_R_RF,
|
|
VPCCMD_W_RF,
|
|
VPCCMD_W_YMC = 0x2A,
|
|
VPCCMD_R_FAN = 0x2B,
|
|
VPCCMD_R_SPECIAL_BUTTONS = 0x31,
|
|
VPCCMD_W_BL_POWER = 0x33,
|
|
};
|
|
|
|
static inline int eval_int_with_arg(acpi_handle handle, const char *name, unsigned long arg, unsigned long *res)
|
|
{
|
|
struct acpi_object_list params;
|
|
unsigned long long result;
|
|
union acpi_object in_obj;
|
|
acpi_status status;
|
|
|
|
params.count = 1;
|
|
params.pointer = &in_obj;
|
|
in_obj.type = ACPI_TYPE_INTEGER;
|
|
in_obj.integer.value = arg;
|
|
|
|
status = acpi_evaluate_integer(handle, (char *)name, ¶ms, &result);
|
|
if (ACPI_FAILURE(status))
|
|
return -EIO;
|
|
|
|
if (res)
|
|
*res = result;
|
|
|
|
return 0;
|
|
}
|
|
|
|
static inline int eval_vpcr(acpi_handle handle, unsigned long cmd, unsigned long *res)
|
|
{
|
|
return eval_int_with_arg(handle, "VPCR", cmd, res);
|
|
}
|
|
|
|
static inline int eval_vpcw(acpi_handle handle, unsigned long cmd, unsigned long data)
|
|
{
|
|
struct acpi_object_list params;
|
|
union acpi_object in_obj[2];
|
|
acpi_status status;
|
|
|
|
params.count = 2;
|
|
params.pointer = in_obj;
|
|
in_obj[0].type = ACPI_TYPE_INTEGER;
|
|
in_obj[0].integer.value = cmd;
|
|
in_obj[1].type = ACPI_TYPE_INTEGER;
|
|
in_obj[1].integer.value = data;
|
|
|
|
status = acpi_evaluate_object(handle, "VPCW", ¶ms, NULL);
|
|
if (ACPI_FAILURE(status))
|
|
return -EIO;
|
|
|
|
return 0;
|
|
}
|
|
|
|
#define IDEAPAD_EC_TIMEOUT 200 /* in ms */
|
|
|
|
static inline int read_ec_data(acpi_handle handle, unsigned long cmd, unsigned long *data)
|
|
{
|
|
unsigned long end_jiffies, val;
|
|
int err;
|
|
|
|
err = eval_vpcw(handle, 1, cmd);
|
|
if (err)
|
|
return err;
|
|
|
|
end_jiffies = jiffies + msecs_to_jiffies(IDEAPAD_EC_TIMEOUT) + 1;
|
|
|
|
while (time_before(jiffies, end_jiffies)) {
|
|
schedule();
|
|
|
|
err = eval_vpcr(handle, 1, &val);
|
|
if (err)
|
|
return err;
|
|
|
|
if (val == 0)
|
|
return eval_vpcr(handle, 0, data);
|
|
}
|
|
|
|
acpi_handle_err(handle, "timeout in %s\n", __func__);
|
|
|
|
return -ETIMEDOUT;
|
|
}
|
|
|
|
static inline int write_ec_cmd(acpi_handle handle, unsigned long cmd, unsigned long data)
|
|
{
|
|
unsigned long end_jiffies, val;
|
|
int err;
|
|
|
|
err = eval_vpcw(handle, 0, data);
|
|
if (err)
|
|
return err;
|
|
|
|
err = eval_vpcw(handle, 1, cmd);
|
|
if (err)
|
|
return err;
|
|
|
|
end_jiffies = jiffies + msecs_to_jiffies(IDEAPAD_EC_TIMEOUT) + 1;
|
|
|
|
while (time_before(jiffies, end_jiffies)) {
|
|
schedule();
|
|
|
|
err = eval_vpcr(handle, 1, &val);
|
|
if (err)
|
|
return err;
|
|
|
|
if (val == 0)
|
|
return 0;
|
|
}
|
|
|
|
acpi_handle_err(handle, "timeout in %s\n", __func__);
|
|
|
|
return -ETIMEDOUT;
|
|
}
|
|
|
|
#undef IDEAPAD_EC_TIMEOUT
|
|
#endif /* !_IDEAPAD_LAPTOP_H_ */
|