linux/block
FUJITA Tomonori abf5439370 block: move cmdfilter from gendisk to request_queue
cmd_filter works only for the block layer SG_IO with SCSI block
devices. It breaks scsi/sg.c, bsg, and the block layer SG_IO with SCSI
character devices (such as st). We hit a kernel crash with them.

The problem is that cmd_filter code accesses to gendisk (having struct
blk_scsi_cmd_filter) via inode->i_bdev->bd_disk. It works for only
SCSI block device files. With character device files, inode->i_bdev
leads you to struct cdev. inode->i_bdev->bd_disk->blk_scsi_cmd_filter
isn't safe.

SCSI ULDs don't expose gendisk; they keep it private. bsg needs to be
independent on any protocols. We shouldn't change ULDs to expose their
gendisk.

This patch moves struct blk_scsi_cmd_filter from gendisk to
request_queue, a common object, which eveyone can access to.

The user interface doesn't change; users can change the filters via
/sys/block/. gendisk has a pointer to request_queue so the cmd_filter
code accesses to struct blk_scsi_cmd_filter.

Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
2008-08-27 09:50:19 +02:00
..
as-iosched.c Use WARN() in block/ 2008-07-26 12:00:07 -07:00
blk-barrier.c block: remove remaining __FUNCTION__ occurrences 2008-05-01 08:04:02 -07:00
blk-core.c block: move cmdfilter from gendisk to request_queue 2008-08-27 09:50:19 +02:00
blk-exec.c block: unexport blk_end_sync_rq 2008-07-15 21:21:45 +02:00
blk-integrity.c block: integrity flags can't use bit ops on unsigned short 2008-07-03 13:21:15 +02:00
blk-ioc.c cfq-iosched: fix RCU race in the cfq io_context destructor handling 2008-05-07 09:28:57 +02:00
blk-map.c block/blk-map.c: use the new object_is_on_stack() helper 2008-07-26 12:00:02 -07:00
blk-merge.c block: Block layer data integrity support 2008-07-03 13:21:13 +02:00
blk-settings.c block: add blk_queue_update_dma_pad 2008-07-04 09:52:13 +02:00
blk-sysfs.c block: sysfs store function needs to grab queue_lock and use queue_flag_*() 2008-05-07 09:09:39 +02:00
blk-tag.c block: adjust tagging function queue bit locking 2008-05-07 09:27:43 +02:00
blk.h block: Block layer data integrity support 2008-07-03 13:21:13 +02:00
blktrace.c Added in user-injected messages into blk traces 2008-07-03 13:21:12 +02:00
bsg.c block: move cmdfilter from gendisk to request_queue 2008-08-27 09:50:19 +02:00
cfq-iosched.c cfq-iosched: get rid of enable_idle being unused warning 2008-07-03 13:21:14 +02:00
cmd-filter.c block: move cmdfilter from gendisk to request_queue 2008-08-27 09:50:19 +02:00
compat_ioctl.c Fix misuses of bdevname() 2008-05-13 08:02:26 -07:00
deadline-iosched.c block: let elv_register() return void 2007-12-18 08:29:28 +01:00
elevator.c block: request_module(): use format string 2008-07-03 13:21:15 +02:00
genhd.c block: drop references taken by class_find_device() 2008-08-21 10:15:38 -07:00
ioctl.c block/ioctl.c and fs/partition/check.c: check value returned by add_partition() 2008-07-25 10:53:44 -07:00
Kconfig block: Block layer data integrity support 2008-07-03 13:21:13 +02:00
Kconfig.iosched update I/O sched Kconfig help texts - CFQ is now default, not AS. 2007-02-17 20:08:22 +01:00
Makefile allow userspace to modify scsi command filter on per device basis 2008-07-03 13:21:14 +02:00
noop-iosched.c block: let elv_register() return void 2007-12-18 08:29:28 +01:00
scsi_ioctl.c block: move cmdfilter from gendisk to request_queue 2008-08-27 09:50:19 +02:00