Daniel Borkmann a4fe78386a bpf: Fix BPF_PROG_QUERY last field check ... While working on the ebpf-go [0] library integration for bpf_mprog and tcx, Lorenz noticed that two subsequent BPF_PROG_QUERY requests currently fail. A typical workflow is to first gather the bpf_mprog count without passing program/ link arrays, followed by the second request which contains the actual array pointers. The initial call populates count and revision fields. The second call gets rejected due to a BPF_PROG_QUERY_LAST_FIELD bug which should point to query.revision instead of query.link_attach_flags since the former is really the last member. It was not noticed in libbpf as bpf_prog_query_opts() always calls bpf(2) with an on-stack bpf_attr that is memset() each time (and therefore query.revision was reset to zero). [0] https://ebpf-go.dev Fixes: e420bed025 ("bpf: Add fd-based tcx multi-prog infra with link support") Reported-by: Lorenz Bauer <lmb@isovalent.com> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net> Link: https://lore.kernel.org/r/20231006220655.1653-1-daniel@iogearbox.net Signed-off-by: Martin KaFai Lau <martin.lau@kernel.org>		2023-10-06 17:11:20 -07:00
..
preload	bpf: make preloaded map iterators to display map elements count	2023-07-06 12:42:25 -07:00
arraymap.c	bpf: return long from bpf_map_ops funcs	2023-03-22 15:11:30 -07:00
bloom_filter.c	bpf: Centralize permissions checks for all BPF map types	2023-06-19 14:04:04 +02:00
bpf_cgrp_storage.c	bpf: Teach verifier that certain helpers accept NULL pointer.	2023-04-04 16:57:16 -07:00
bpf_inode_storage.c	Networking changes for 6.4.	2023-04-26 16:07:23 -07:00
bpf_iter.c	bpf: implement numbers iterator	2023-03-08 16:19:51 -08:00
bpf_local_storage.c	bpf: bpf_sk_storage: Fix the missing uncharge in sk_omem_alloc	2023-09-06 11:08:14 +02:00
bpf_lru_list.c	bpf: Address KCSAN report on bpf_lru_list	2023-05-12 12:01:03 -07:00
bpf_lru_list.h	bpf: lru: Remove unused declaration bpf_lru_promote()	2023-08-08 17:21:42 -07:00
bpf_lsm.c	bpf: Fix the kernel crash caused by bpf_setsockopt().	2023-01-26 23:26:40 -08:00
bpf_struct_ops.c	bpf: Support default .validate() and .update() behavior for struct_ops links	2023-08-14 22:23:39 -07:00
bpf_struct_ops_types.h
bpf_task_storage.c	bpf: Teach verifier that certain helpers accept NULL pointer.	2023-04-04 16:57:16 -07:00
btf.c	bpf: Fix a erroneous check after snprintf()	2023-09-12 13:15:46 -07:00
cgroup.c	bpf, cgroup: fix multiple kernel-doc warnings	2023-09-12 13:19:07 -07:00
cgroup_iter.c	cgroup: bpf: use cgroup_lock()/cgroup_unlock() wrappers	2023-03-17 12:07:13 -10:00
core.c	bpf: make bpf_prog_pack allocator portable	2023-09-06 06:26:05 -07:00
cpumap.c	bpf, cpumask: Clean up bpf_cpu_map_entry directly in cpu_map_free	2023-08-21 15:21:16 -07:00
cpumask.c	bpf: Convert bpf_cpumask to bpf_mem_cache_free_rcu.	2023-07-12 23:45:23 +02:00
devmap.c	bpf, devmap: Remove unused dtab field from bpf_dtab_netdev	2023-07-31 18:26:08 -07:00
disasm.c	bpf: change bpf_alu_sign_string and bpf_movsx_string to static	2023-08-04 16:15:50 -07:00
disasm.h
dispatcher.c	bpf: Synchronize dispatcher update with bpf_dispatcher_xdp_func	2022-12-14 12:02:14 -08:00
hashtab.c	bpf: populate the per-cpu insertions/deletions counters for hashmaps	2023-07-06 12:42:25 -07:00
helpers.c	bpf: Allow bpf_spin_{lock,unlock} in sleepable progs	2023-08-25 09:23:17 -07:00
inode.c	bpf: convert to ctime accessor functions	2023-07-24 10:30:07 +02:00
Kconfig	bpf: Add fd-based tcx multi-prog infra with link support	2023-07-19 10:07:27 -07:00
link_iter.c	bpf: Add bpf_link iterator	2022-05-10 11:20:45 -07:00
local_storage.c	cgroup changes for v6.4-rc1	2023-04-29 10:05:22 -07:00
log.c	bpf: drop unnecessary user-triggerable WARN_ONCE in verifierl log	2023-05-16 22:34:50 -07:00
lpm_trie.c	bpf: Centralize permissions checks for all BPF map types	2023-06-19 14:04:04 +02:00
Makefile	bpf: Add fd-based tcx multi-prog infra with link support	2023-07-19 10:07:27 -07:00
map_in_map.c	bpf: Fix elem_size not being set for inner maps	2023-06-02 16:22:12 -07:00
map_in_map.h
map_iter.c	bpf: allow any program to use the bpf_map_sum_elem_count kfunc	2023-07-19 09:48:53 -07:00
memalloc.c	bpf: Use kmalloc_size_roundup() to adjust size_index	2023-09-30 09:39:28 -07:00
mmap_unlock_work.h
mprog.c	bpf, mprog: Fix maximum program check on mprog attachment	2023-09-29 15:49:57 -07:00
net_namespace.c
offload.c	bpf: Avoid dummy bpf_offload_netdev in __bpf_prog_dev_bound_init	2023-09-11 22:06:06 -07:00
percpu_freelist.c	bpf: Initialize same number of free nodes for each pcpu_freelist	2022-11-11 12:05:14 -08:00
percpu_freelist.h
prog_iter.c
queue_stack_maps.c	bpf: Avoid deadlock when using queue and stack maps from NMI	2023-09-11 19:04:49 -07:00
reuseport_array.c	bpf: Centralize permissions checks for all BPF map types	2023-06-19 14:04:04 +02:00
ringbuf.c	bpf: Remove unnecessary ring buffer size check	2023-07-05 14:09:45 +02:00
stackmap.c	bpf: Centralize permissions checks for all BPF map types	2023-06-19 14:04:04 +02:00
syscall.c	bpf: Fix BPF_PROG_QUERY last field check	2023-10-06 17:11:20 -07:00
sysfs_btf.c
task_iter.c	bpf: keep a reference to the mm, in case the task is dead.	2022-12-28 14:11:48 -08:00
tcx.c	tcx: Fix splat during dev unregister	2023-07-31 14:44:02 -07:00
tnum.c
trampoline.c	bpf: Assign bpf_tramp_run_ctx::saved_run_ctx before recursion check.	2023-09-06 10:44:28 +02:00
verifier.c	bpf: unconditionally reset backtrack_state masks on global func exit	2023-09-20 03:26:25 -07:00