linux/drivers/s390
Steffen Maier 9704154fa0 scsi: zfcp: drop duplicate seq_no from zfcp_fsf_req which is also in QTCB header
There is no point for double bookkeeping especially just for tracing.  The
trace can take it from the QTCB which always exists for non-SRB responses
traced with zfcp_dbf_hba_fsf_res().

As a side effect, this removes an alignment hole and reduces the size of
struct zfcp_fsf_req, and thus of each pending request, by 8 bytes.

Before:
$ pahole -C zfcp_fsf_req drivers/s390/scsi/zfcp.ko
...
	struct fsf_qtcb *          qtcb;                 /*   144     8 */
	u32                        seq_no;               /*   152     4 */
	/* XXX 4 bytes hole, try to pack */
	void *                     data;                 /*   160     8 */
...
	/* size: 296, cachelines: 2, members: 14 */
	/* sum members: 288, holes: 2, sum holes: 8 */
	/* last cacheline: 40 bytes */
After:
$ pahole -C zfcp_fsf_req drivers/s390/scsi/zfcp.ko
...
	struct fsf_qtcb *          qtcb;                 /*   144     8 */
	void *                     data;                 /*   152     8 */
...
	/* size: 288, cachelines: 2, members: 13 */
        /* sum members: 284, holes: 1, sum holes: 4 */

Signed-off-by: Steffen Maier <maier@linux.ibm.com>
Reviewed-by: Benjamin Block <bblock@linux.ibm.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
2018-11-15 15:01:17 -05:00
..
block s390 updates for the 4.20 merge window 2018-10-23 11:14:47 +01:00
char mm: remove include/linux/bootmem.h 2018-10-31 08:54:16 -07:00
cio mm: remove include/linux/bootmem.h 2018-10-31 08:54:16 -07:00
crypto KVM updates for v4.20 2018-10-25 17:57:35 -07:00
net pci-v4.20-changes 2018-10-25 06:50:48 -07:00
scsi scsi: zfcp: drop duplicate seq_no from zfcp_fsf_req which is also in QTCB header 2018-11-15 15:01:17 -05:00
virtio mm: remove include/linux/bootmem.h 2018-10-31 08:54:16 -07:00
Makefile kbuild: rename built-in.o to built-in.a 2018-03-26 02:01:19 +09:00