linux/drivers/net/pcmcia
Herbert Xu 5b057c6b1a [NET]: Avoid allocating skb in skb_pad
First of all it is unnecessary to allocate a new skb in skb_pad since
the existing one is not shared.  More importantly, our hard_start_xmit
interface does not allow a new skb to be allocated since that breaks
requeueing.

This patch uses pskb_expand_head to expand the existing skb and linearize
it if needed.  Actually, someone should sift through every instance of
skb_pad on a non-linear skb as they do not fit the reasons why this was
originally created.

Incidentally, this fixes a minor bug when the skb is cloned (tcpdump,
TCP, etc.).  As it is skb_pad will simply write over a cloned skb.  Because
of the position of the write it is unlikely to cause problems but still
it's best if we don't do it.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
2006-06-23 02:06:41 -07:00
..
3c574_cs.c [PATCH] pcmcia: convert DEV_OK to pcmcia_dev_present 2006-03-31 17:26:57 +02:00
3c589_cs.c [PATCH] pcmcia: convert DEV_OK to pcmcia_dev_present 2006-03-31 17:26:57 +02:00
axnet_cs.c [PATCH] network: axnet_cs: bug fix multicast code (support older ax88190 chipset) 2006-05-20 00:20:29 -04:00
com20020_cs.c [PATCH] pcmcia: use bitfield instead of p_state and state 2006-03-31 17:26:33 +02:00
fmvj18x_cs.c [NET]: Avoid allocating skb in skb_pad 2006-06-23 02:06:41 -07:00
ibmtr_cs.c [PATCH] pcmcia: use bitfield instead of p_state and state 2006-03-31 17:26:33 +02:00
Kconfig Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
Makefile Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
nmclan_cs.c [PATCH] nmclan_cs: dereferencing skb after netif_rx() 2006-06-05 12:29:15 -07:00
ositech.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
pcnet_cs.c [netdrvr pcnet_cs, myri] trim trailing whitespace 2006-05-24 00:28:37 -04:00
smc91c92_cs.c [PATCH] pcmcia: convert DEV_OK to pcmcia_dev_present 2006-03-31 17:26:57 +02:00
xirc2ps_cs.c [NET]: Avoid allocating skb in skb_pad 2006-06-23 02:06:41 -07:00