linux/drivers/regulator
Dmitry Torokhov 1ad02bbce6 Regulators: wm8400 - cleanup platform driver data handling
On Wed, Feb 24, 2010 at 08:40:56PM +0000, Mark Brown wrote:
> On Wed, Feb 24, 2010 at 11:21:26AM -0800, Dmitry Torokhov wrote:
> > On Wed, Feb 24, 2010 at 07:14:03PM +0000, Mark Brown wrote:
>
> > > This doesn't help unless you also provide a way for users to obtain a
> > > struct wm8400.
>
> > Why would they need it? Only code that creates instances of wm8400 needs
> > to know the definition of the sturcture, the rest can simply pass the
> > pointer around.
>
> > I guess there is disconnect between us and I do not see any users of
> > wm8400_register_regulator() in linux-next... Is there another tree I
> > could peek at?
>
> There are no users in mainline.  This would be called by board specific
> code from the init callback of the wm8400 - you'd need to pass that
> callback the struct wm8400.
>
> In any case, this is clearly an unrelated change to whatever else you
> were doing to the driver so should be split off into a separate patch,
> but if this is being changed at all then it'd be much more sensible to
> change it to use a more modern pattern which completely removes the
> wm8400_register_regulator() function and just uses platform data.

Fair enough, I removed the offending part, updated patch below.

--
Dmitry

regulator: wm8400 - cleanup platform driver data handling

Driver data set by platform_set_drvdata() is for private use of
the driver currently bound to teh device and not for use by parent,
subsystem and anyone else.

Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Liam Girdwood <lrg@slimlogic.co.uk>
2010-03-03 14:49:30 +00:00
..
88pm8607.c regulator: Ensure val is initialised in 88pm8607 choose_voltage() 2009-12-17 10:27:25 +00:00
ab3100.c Regulators: ab3100 - fix probe and remove annotations 2010-03-03 14:49:27 +00:00
bq24022.c regulator/bq24022: fix bug in is_enabled function 2009-04-28 18:58:08 +01:00
core.c regulator: Provide optional dummy regulator for consumers 2010-03-03 14:49:26 +00:00
da903x.c regulator: keep index within bounds in da9034_get_ldo12_voltage() 2009-12-17 10:27:25 +00:00
dummy.c regulator: Provide optional dummy regulator for consumers 2010-03-03 14:49:26 +00:00
dummy.h regulator: Provide optional dummy regulator for consumers 2010-03-03 14:49:26 +00:00
fixed.c Regulators: fixed - annotate probe and remove methods 2010-03-03 14:49:27 +00:00
Kconfig regulator: Provide optional dummy regulator for consumers 2010-03-03 14:49:26 +00:00
lp3971.c Regulators: lp3971 - fail if platform data was not supplied 2010-03-03 14:49:28 +00:00
Makefile regulator: Provide optional dummy regulator for consumers 2010-03-03 14:49:26 +00:00
max1586.c Regulators: max1586 - annotate probe and remove methods 2010-03-03 14:49:28 +00:00
max8649.c regulator: enable max8649 regulator driver 2010-03-03 14:49:24 +00:00
max8660.c Regulators: max8660 - annotate probe and remove methods 2010-03-03 14:49:29 +00:00
mc13783-regulator.c regulator: mc13783: consider Power Gates as digital regulators. 2010-03-03 14:49:23 +00:00
pcap-regulator.c Regulators: pcap-regulator - clean up driver data after removal 2010-03-03 14:49:29 +00:00
pcf50633-regulator.c mfd: Fix pcf50633-regulator drvdata usage 2009-12-13 19:21:20 +01:00
tps6507x-regulator.c Regulators: tps6507x-regulator - mark probe method as __devinit 2010-03-03 14:49:28 +00:00
tps65023-regulator.c Regulators: tps65023-regulator - mark probe method as __devinit 2010-03-03 14:49:27 +00:00
twl-regulator.c Regulators: twl-regulator - mark probe function as __devinit 2010-03-03 14:49:27 +00:00
userspace-consumer.c regulator: userspace: use sysfs_create_group 2009-09-22 13:32:41 +01:00
virtual.c Regulators: virtual - use sysfs attribute groups 2010-03-03 14:49:26 +00:00
wm831x-dcdc.c Regulators: wm831x-xxx - clean up driver data after removal 2010-03-03 14:49:29 +00:00
wm831x-isink.c Regulators: wm831x-xxx - clean up driver data after removal 2010-03-03 14:49:29 +00:00
wm831x-ldo.c Regulators: wm831x-xxx - clean up driver data after removal 2010-03-03 14:49:29 +00:00
wm8350-regulator.c regulator: Implement enable_time() for WM835x ISINKs 2010-03-03 14:49:23 +00:00
wm8400-regulator.c Regulators: wm8400 - cleanup platform driver data handling 2010-03-03 14:49:30 +00:00
wm8994-regulator.c Regulators: wm8994 - clean up driver data after removal 2010-03-03 14:49:29 +00:00