linux/drivers/pinctrl/uniphier
Gustavo A. R. Silva aa0ed0d00f pinctrl: uniphier: Replace zero-length array with flexible-array member
The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:

struct foo {
        int stuff;
        struct boo array[];
};

By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last in the structure, which
will help us prevent some kind of undefined behavior bugs from being
inadvertently introduced[3] to the codebase from now on.

Also, notice that, dynamic memory allocations won't be affected by
this change:

"Flexible array members have incomplete type, and so the sizeof operator
may not be applied. As a quirk of the original implementation of
zero-length arrays, sizeof evaluates to zero."[1]

This issue was found with the help of Coccinelle.

[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 7649773293 ("cxgb3/l2t: Fix undefined behaviour")

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Link: https://lore.kernel.org/r/20200217185437.GA20901@embeddedor
Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
2020-02-21 15:36:24 +01:00
..
Kconfig treewide: Add SPDX license identifier - Makefile/Kconfig 2019-05-21 10:50:46 +02:00
Makefile License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
pinctrl-uniphier-core.c pinctrl: uniphier: Replace zero-length array with flexible-array member 2020-02-21 15:36:24 +01:00
pinctrl-uniphier-ld4.c pinctrl: uniphier: Separate modem group from UART ctsrts group 2019-08-05 13:17:20 +02:00
pinctrl-uniphier-ld6b.c pinctrl: uniphier: Separate modem group from UART ctsrts group 2019-08-05 13:17:20 +02:00
pinctrl-uniphier-ld11.c pinctrl: uniphier: Separate modem group from UART ctsrts group 2019-08-05 13:17:20 +02:00
pinctrl-uniphier-ld20.c pinctrl: uniphier: Add 5th LD20 MPEG2-TS input pin-mux setting 2019-08-05 13:19:35 +02:00
pinctrl-uniphier-pro4.c pinctrl: uniphier: Separate modem group from UART ctsrts group 2019-08-05 13:17:20 +02:00
pinctrl-uniphier-pro5.c pinctrl: uniphier: Fix Pro5 SD pin-mux setting 2019-08-05 13:21:31 +02:00
pinctrl-uniphier-pxs2.c pinctrl: uniphier: Separate modem group from UART ctsrts group 2019-08-05 13:17:20 +02:00
pinctrl-uniphier-pxs3.c pinctrl: uniphier: Separate modem group from UART ctsrts group 2019-08-05 13:17:20 +02:00
pinctrl-uniphier-sld8.c pinctrl: uniphier: Separate modem group from UART ctsrts group 2019-08-05 13:17:20 +02:00
pinctrl-uniphier.h pinctrl: uniphier: constify uniphier_pinctrl_socdata 2018-12-21 11:18:08 +01:00