linux/drivers/net/wireless/intersil
Arnd Bergmann 48dc5fb3ba hostap: avoid uninitialized variable use in hfa384x_get_rid
The driver reads a value from hfa384x_from_bap(), which may fail,
and then assigns the value to a local variable. gcc detects that
in in the failure case, the 'rlen' variable now contains
uninitialized data:

In file included from ../drivers/net/wireless/intersil/hostap/hostap_pci.c:220:0:
drivers/net/wireless/intersil/hostap/hostap_hw.c: In function 'hfa384x_get_rid':
drivers/net/wireless/intersil/hostap/hostap_hw.c:842:5: warning: 'rec' may be used uninitialized in this function [-Wmaybe-uninitialized]
  if (le16_to_cpu(rec.len) == 0) {

This restructures the function as suggested by Russell King, to
make it more readable and get more reliable error handling, by
handling each failure mode using a goto.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
2016-02-06 13:59:24 +02:00
..
hostap hostap: avoid uninitialized variable use in hfa384x_get_rid 2016-02-06 13:59:24 +02:00
orinoco orinoco: move under intersil vendor directory 2015-11-18 14:28:31 +02:00
p54
prism54 prism54: fix checks for dma mapping errors 2015-12-31 10:23:32 +02:00
Kconfig prism54: move under intersil vendor directory 2015-11-18 14:28:31 +02:00
Makefile prism54: move under intersil vendor directory 2015-11-18 14:28:31 +02:00