mirror of
https://github.com/torvalds/linux
synced 2024-09-06 18:01:05 +00:00
![]() When asn1_encode_sequence() fails, WARN is not the correct solution.
1. asn1_encode_sequence() is not an internal function (located
in lib/asn1_encode.c).
2. Location is known, which makes the stack trace useless.
3. Results a crash if panic_on_warn is set.
It is also noteworthy that the use of WARN is undocumented, and it
should be avoided unless there is a carefully considered rationale to
use it.
Replace WARN with pr_err, and print the return value instead, which is
only useful piece of information.
Cc: stable@vger.kernel.org # v5.13+
Fixes:
|
||
---|---|---|
.. | ||
encrypted-keys | ||
trusted-keys | ||
big_key.c | ||
compat.c | ||
compat_dh.c | ||
dh.c | ||
gc.c | ||
internal.h | ||
Kconfig | ||
key.c | ||
keyctl.c | ||
keyctl_pkey.c | ||
keyring.c | ||
Makefile | ||
permission.c | ||
persistent.c | ||
proc.c | ||
process_keys.c | ||
request_key.c | ||
request_key_auth.c | ||
sysctl.c | ||
user_defined.c |