mirror of
https://github.com/torvalds/linux
synced 2024-10-20 02:09:15 +00:00
8863b1212a
The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:
struct foo {
int stuff;
struct boo array[];
};
By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last in the structure, which
will help us prevent some kind of undefined behavior bugs from being
inadvertently introduced[3] to the codebase from now on.
Also, notice that, dynamic memory allocations won't be affected by
this change:
"Flexible array members have incomplete type, and so the sizeof operator
may not be applied. As a quirk of the original implementation of
zero-length arrays, sizeof evaluates to zero."[1]
sizeof(flexible-array-member) triggers a warning because flexible array
members have incomplete type[1]. There are some instances of code in
which the sizeof operator is being incorrectly/erroneously applied to
zero-length arrays and the result is zero. Such instances may be hiding
some bugs. So, this work (flexible-array member conversions) will also
help to get completely rid of those sorts of issues.
This issue was found with the help of Coccinelle.
[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit
|
||
|---|---|---|
| .. | ||
| 3945-debug.c | ||
| 3945-mac.c | ||
| 3945-rs.c | ||
| 3945.c | ||
| 3945.h | ||
| 4965-calib.c | ||
| 4965-debug.c | ||
| 4965-mac.c | ||
| 4965-rs.c | ||
| 4965.c | ||
| 4965.h | ||
| commands.h | ||
| common.c | ||
| common.h | ||
| csr.h | ||
| debug.c | ||
| iwl-spectrum.h | ||
| Kconfig | ||
| Makefile | ||
| prph.h | ||