linux/sound/firewire/tascam/tascam-proc.c
Takashi Iwai 0c298bdc38 ALSA: firewire: Remove superfluous snd_info_register() calls
The calls of snd_info_register() are superfluous and should be avoided
at the procfs creation time.  They are called at the end of the whole
initialization via snd_card_register().  This patch drops such
superfluous calls.

Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Tested-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
2019-02-06 18:11:38 +01:00

81 lines
2.1 KiB
C

/*
* tascam-proc.h - a part of driver for TASCAM FireWire series
*
* Copyright (c) 2015 Takashi Sakamoto
*
* Licensed under the terms of the GNU General Public License, version 2.
*/
#include "./tascam.h"
static void proc_read_firmware(struct snd_info_entry *entry,
struct snd_info_buffer *buffer)
{
struct snd_tscm *tscm = entry->private_data;
__be32 data;
unsigned int reg, fpga, arm, hw;
int err;
err = snd_fw_transaction(tscm->unit, TCODE_READ_QUADLET_REQUEST,
TSCM_ADDR_BASE + TSCM_OFFSET_FIRMWARE_REGISTER,
&data, sizeof(data), 0);
if (err < 0)
return;
reg = be32_to_cpu(data);
err = snd_fw_transaction(tscm->unit, TCODE_READ_QUADLET_REQUEST,
TSCM_ADDR_BASE + TSCM_OFFSET_FIRMWARE_FPGA,
&data, sizeof(data), 0);
if (err < 0)
return;
fpga = be32_to_cpu(data);
err = snd_fw_transaction(tscm->unit, TCODE_READ_QUADLET_REQUEST,
TSCM_ADDR_BASE + TSCM_OFFSET_FIRMWARE_ARM,
&data, sizeof(data), 0);
if (err < 0)
return;
arm = be32_to_cpu(data);
err = snd_fw_transaction(tscm->unit, TCODE_READ_QUADLET_REQUEST,
TSCM_ADDR_BASE + TSCM_OFFSET_FIRMWARE_HW,
&data, sizeof(data), 0);
if (err < 0)
return;
hw = be32_to_cpu(data);
snd_iprintf(buffer, "Register: %d (0x%08x)\n", reg & 0xffff, reg);
snd_iprintf(buffer, "FPGA: %d (0x%08x)\n", fpga & 0xffff, fpga);
snd_iprintf(buffer, "ARM: %d (0x%08x)\n", arm & 0xffff, arm);
snd_iprintf(buffer, "Hardware: %d (0x%08x)\n", hw >> 16, hw);
}
static void add_node(struct snd_tscm *tscm, struct snd_info_entry *root,
const char *name,
void (*op)(struct snd_info_entry *e,
struct snd_info_buffer *b))
{
struct snd_info_entry *entry;
entry = snd_info_create_card_entry(tscm->card, name, root);
if (entry)
snd_info_set_text_ops(entry, tscm, op);
}
void snd_tscm_proc_init(struct snd_tscm *tscm)
{
struct snd_info_entry *root;
/*
* All nodes are automatically removed at snd_card_disconnect(),
* by following to link list.
*/
root = snd_info_create_card_entry(tscm->card, "firewire",
tscm->card->proc_root);
if (root == NULL)
return;
root->mode = S_IFDIR | 0555;
add_node(tscm, root, "firmware", proc_read_firmware);
}