Alexander Lobakin 75eaf63ea7 net: skbuff: don't include <net/page_pool/types.h> to <linux/skbuff.h> ... Currently, touching <net/page_pool/types.h> triggers a rebuild of more than half of the kernel. That's because it's included in <linux/skbuff.h>. And each new include to page_pool/types.h adds more [useless] data for the toolchain to process per each source file from that pile. In commit 6a5bcd84e8 ("page_pool: Allow drivers to hint on SKB recycling"), Matteo included it to be able to call a couple of functions defined there. Then, in commit 57f05bc2ab ("page_pool: keep pp info as long as page pool owns the page") one of the calls was removed, so only one was left. It's the call to page_pool_return_skb_page() in napi_frag_unref(). The function is external and doesn't have any dependencies. Having very niche page_pool_types.h included only for that looks like an overkill. As %PP_SIGNATURE is not local to page_pool.c (was only in the early submissions), nothing holds this function there. Teleport page_pool_return_skb_page() to skbuff.c, just next to the main consumer, skb_pp_recycle(), and rename it to napi_pp_put_page(), as it doesn't work with skbs at all and the former name tells nothing. The #if guards here are only to not compile and have it in the vmlinux when not needed -- both call sites are already guarded. Now, touching page_pool_types.h only triggers rebuilding of the drivers using it and a couple of core networking files. Suggested-by: Jakub Kicinski <kuba@kernel.org> # make skbuff.h less heavy Suggested-by: Alexander Duyck <alexanderduyck@fb.com> # move to skbuff.c Signed-off-by: Alexander Lobakin <aleksander.lobakin@intel.com> Reviewed-by: Alexander Duyck <alexanderduyck@fb.com> Link: https://lore.kernel.org/r/20230804180529.2483231-3-aleksander.lobakin@intel.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>		2023-08-07 13:05:53 -07:00
..
bpf_sk_storage.c	bpf: Add length check for SK_DIAG_BPF_STORAGE_REQ_MAP_FD parsing	2023-07-27 10:07:56 -07:00
datagram.c
dev.c	pull-request: bpf-next 2023-08-03	2023-08-03 15:34:36 -07:00
dev.h
dev_addr_lists.c
dev_addr_lists_test.c
dev_ioctl.c	net: omit ndo_hwtstamp_get() call when possible in dev_set_hwtstamp_phylib()	2023-08-06 13:25:10 +01:00
drop_monitor.c
dst.c
dst_cache.c
failover.c
fib_notifier.c
fib_rules.c
filter.c	bpf, net: Support SO_REUSEPORT sockets with bpf_sk_assign	2023-07-25 13:55:55 -07:00
flow_dissector.c	net: flow_dissector: Add IPSEC dissector	2023-08-02 10:09:31 +01:00
flow_offload.c	tc: flower: Enable offload support IPSEC SPI field.	2023-08-02 10:09:32 +01:00
gen_estimator.c
gen_stats.c
gro.c	gro: move the tc_ext comparison to a helper	2023-06-18 18:08:35 +01:00
gro_cells.c
gso.c	net: move gso declarations and functions to their own files	2023-06-10 00:11:41 -07:00
hwbm.c
link_watch.c
lwt_bpf.c
lwtunnel.c
Makefile	net: move gso declarations and functions to their own files	2023-06-10 00:11:41 -07:00
neighbour.c
net-procfs.c
net-sysfs.c	net: move struct netdev_rx_queue out of netdevice.h	2023-08-03 08:38:07 -07:00
net-sysfs.h
net-traces.c	udp6: add a missing call into udp_fail_queue_rcv_skb tracepoint	2023-07-07 09:16:52 +01:00
net_namespace.c
netclassid_cgroup.c
netdev-genl-gen.c
netdev-genl-gen.h
netdev-genl.c	net: convert some netlink netdev iterators to depend on the xarray	2023-07-28 11:35:58 -07:00
netevent.c
netpoll.c	netpoll: allocate netdev tracker right away	2023-06-15 08:21:11 +01:00
netprio_cgroup.c
of_net.c	net: Explicitly include correct DT includes	2023-07-27 20:33:16 -07:00
page_pool.c	net: skbuff: don't include <net/page_pool/types.h> to <linux/skbuff.h>	2023-08-07 13:05:53 -07:00
pktgen.c
ptp_classifier.c
request_sock.c
rtnetlink.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2023-08-03 14:34:37 -07:00
scm.c
secure_seq.c
selftests.c
skbuff.c	net: skbuff: don't include <net/page_pool/types.h> to <linux/skbuff.h>	2023-08-07 13:05:53 -07:00
skmsg.c
sock.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2023-08-03 14:34:37 -07:00
sock_destructor.h
sock_diag.c
sock_map.c	bpf: sockmap: Remove preempt_disable in sock_map_sk_acquire	2023-08-01 09:24:34 +02:00
sock_reuseport.c
stream.c
sysctl_net_core.c
timestamping.c
tso.c
utils.c
xdp.c	page_pool: split types and declarations from page_pool.h	2023-08-07 13:05:19 -07:00