mirror of
https://github.com/torvalds/linux
synced 2024-10-06 19:34:19 +00:00
5d211c7090
Robert reported the following when booting a CXL host with Restricted CXL
Host (RCH) topology:
[ 39.815379] cxl_acpi ACPI0017:00: not a cxl_port device
[ 39.827123] WARNING: CPU: 46 PID: 1754 at drivers/cxl/core/port.c:592 to_cxl_port+0x56/0x70 [cxl_core]
... plus some related subsequent NULL pointer dereference:
[ 40.718708] BUG: kernel NULL pointer dereference, address: 00000000000002d8
The iterator to walk the PCIe path did not account for RCH topology.
However RCH does not support hotplug and the memory exported by the
Restricted CXL Device (RCD) should be covered by HMAT and therefore no
access_coordinate is needed. Add check to see if the endpoint device is
RCD and skip calculation.
Also add a call to cxl_endpoint_get_perf_coordinates() in cxl_test in order
to exercise the topology iterator. The dev_is_pci() check added is to help
with this test and should be harmless for normal operation.
Reported-by: Robert Richter <rrichter@amd.com>
Closes: https://lore.kernel.org/all/Ziv8GfSMSbvlBB0h@rric.localdomain/
Fixes:
|
||
|---|---|---|
| .. | ||
| test | ||
| config_check.c | ||
| cxl_acpi_test.c | ||
| cxl_core_exports.c | ||
| cxl_core_test.c | ||
| cxl_mem_test.c | ||
| cxl_pmem_test.c | ||
| cxl_port_test.c | ||
| Kbuild | ||
| mock_acpi.c | ||
| watermark.h | ||