mirror of
https://github.com/torvalds/linux
synced 2024-11-05 18:23:50 +00:00
a823e76138
Since we cannot make sure the 'pdata->num_leds' will always be none zero here, and then if it equals to zero, the kmemdup() will return ZERO_SIZE_PTR, which equals to ((void *)16). So this patch fix this with just doing the zero check before calling kmemdup(). Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com> Signed-off-by: Bryan Wu <cooloney@gmail.com>
45 lines
1.3 KiB
C
45 lines
1.3 KiB
C
/*
|
|
* Copyright (C) 2011 Pengutronix
|
|
* Uwe Kleine-Koenig <u.kleine-koenig@pengutronix.de>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify it under
|
|
* the terms of the GNU General Public License version 2 as published by the
|
|
* Free Software Foundation.
|
|
*/
|
|
#include <linux/err.h>
|
|
#include <linux/leds.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/slab.h>
|
|
|
|
/**
|
|
* gpio_led_register_device - register a gpio-led device
|
|
* @pdata: the platform data used for the new device
|
|
*
|
|
* Makes a copy of pdata and pdata->leds and registers a new leds-gpio device
|
|
* with the result. This allows to have pdata and pdata-leds in .init.rodata
|
|
* and so saves some bytes compared to a static struct platform_device with
|
|
* static platform data.
|
|
*
|
|
* Returns the registered device or an error pointer.
|
|
*/
|
|
struct platform_device *__init gpio_led_register_device(
|
|
int id, const struct gpio_led_platform_data *pdata)
|
|
{
|
|
struct platform_device *ret;
|
|
struct gpio_led_platform_data _pdata = *pdata;
|
|
|
|
if (!pdata->num_leds)
|
|
return ERR_PTR(-EINVAL);
|
|
|
|
_pdata.leds = kmemdup(pdata->leds,
|
|
pdata->num_leds * sizeof(*pdata->leds), GFP_KERNEL);
|
|
if (!_pdata.leds)
|
|
return ERR_PTR(-ENOMEM);
|
|
|
|
ret = platform_device_register_resndata(NULL, "leds-gpio", id,
|
|
NULL, 0, &_pdata, sizeof(_pdata));
|
|
if (IS_ERR(ret))
|
|
kfree(_pdata.leds);
|
|
|
|
return ret;
|
|
}
|