Hans de Goede 71d69e82f4 platform/x86: think-lmi: Return EINVAL when kbdlang gets set to a 0 length string ... Commit 0ddcf3a6b4 ("platform/x86: think-lmi: Avoid potential read before start of the buffer") moved the length == 0 up to before stripping the '\n' which typically gets added when users echo a value to a sysfs-attribute from the shell. This avoids a potential buffer-underrun, but it also causes a behavioral change, prior to this change "echo > kbdlang", iow writing just a single '\n' would result in an EINVAL error, but after the change this gets accepted setting kbdlang to an empty string. Fix this by replacing the manual '\n' check with using strchrnul() to get the length till '\n' or terminating 0 in one go; and then do the length != 0 check after this. Fixes: 0ddcf3a6b4 ("platform/x86: think-lmi: Avoid potential read before start of the buffer") Reported-by: Juha Leppänen <juha_efku@dnainternet.net> Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com> Signed-off-by: Hans de Goede <hdegoede@redhat.com> Link: https://lore.kernel.org/r/20210621193648.44138-1-hdegoede@redhat.com		2021-06-22 11:42:31 +02:00
..
chrome	chrome platform changes for 5.13	2021-05-07 14:49:18 -07:00
goldfish	platform/goldfish: Convert pipe tasklet to threaded irq	2021-01-27 14:57:06 +01:00
mellanox	platform/mellanox: mlxreg-hotplug: Revert "move to use request_irq by IRQF_NO_AUTOEN flag"	2021-06-16 17:47:52 +02:00
mips	MIPS: Loongson: Fix boot warning about hwmon_device_register()	2020-07-16 10:49:55 +02:00
olpc	Platform: OLPC: Constify static struct regulator_ops	2021-02-08 16:59:21 +01:00
surface	Merge remote-tracking branch 'linux-pm/acpi-scan' into review-hans	2021-06-16 17:48:22 +02:00
x86	platform/x86: think-lmi: Return EINVAL when kbdlang gets set to a 0 length string	2021-06-22 11:42:31 +02:00
Kconfig	platform: Add Surface platform directory	2020-10-27 12:51:03 +01:00
Makefile	platform: Add Surface platform directory	2020-10-27 12:51:03 +01:00