Steffen Maier 71b8e45da5 scsi: zfcp: fix queuecommand for scsi_eh commands when DIX enabled ... Since commit db007fc5e2 ("[SCSI] Command protection operation"), scsi_eh_prep_cmnd() saves scmd->prot_op and temporarily resets it to SCSI_PROT_NORMAL. Other FCP LLDDs such as qla2xxx and lpfc shield their queuecommand() to only access any of scsi_prot_sg...() if (scsi_get_prot_op(cmd) != SCSI_PROT_NORMAL). Do the same thing for zfcp, which introduced DIX support with commit ef3eb71d8b ("[SCSI] zfcp: Introduce experimental support for DIF/DIX"). Otherwise, TUR SCSI commands as part of scsi_eh likely fail in zfcp, because the regular SCSI command with DIX protection data, that scsi_eh re-uses in scsi_send_eh_cmnd(), of course still has (scsi_prot_sg_count() != 0) and so zfcp sends down bogus requests to the FCP channel hardware. This causes scsi_eh_test_devices() to have (finish_cmds == 0) [not SCSI device is online or not scsi_eh_tur() failed] so regular SCSI commands, that caused / were affected by scsi_eh, are moved to work_q and scsi_eh_test_devices() itself returns false. In turn, it unnecessarily escalates in our case in scsi_eh_ready_devs() beyond host reset to finally scsi_eh_offline_sdevs() which sets affected SCSI devices offline with the following kernel message: "kernel: sd H:0:T:L: Device offlined - not ready after error recovery" Signed-off-by: Steffen Maier <maier@linux.vnet.ibm.com> Fixes: ef3eb71d8b ("[SCSI] zfcp: Introduce experimental support for DIF/DIX") Cc: <stable@vger.kernel.org> #2.6.36+ Reviewed-by: Benjamin Block <bblock@linux.vnet.ibm.com> Signed-off-by: Benjamin Block <bblock@linux.vnet.ibm.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>		2017-08-10 19:36:54 -04:00
..
block	libnvdimm for 4.13	2017-07-07 09:44:06 -07:00
char	mm, tree wide: replace __GFP_REPEAT by __GFP_RETRY_MAYFAIL with more useful semantic	2017-07-12 16:26:03 -07:00
cio	s390: chp: handle CRW_ERC_INIT for channel-path status change	2017-07-13 11:28:29 +02:00
crypto	s390/zcrypt: Fix missing newlines at some debug feature messages.	2017-07-05 07:35:29 +02:00
net	drivers: s390: move static and inline before return type	2017-07-12 16:26:04 -07:00
scsi	scsi: zfcp: fix queuecommand for scsi_eh commands when DIX enabled	2017-08-10 19:36:54 -04:00
virtio	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux	2017-05-16 09:24:44 -07:00
Makefile	virtio/s390: rename drivers/s390/kvm -> drivers/s390/virtio	2015-07-07 14:27:06 +03:00