linux/fs/gfs2
Andreas Gruenbacher 6ff9b09e00 gfs2: Get rid of potential double-freeing in gfs2_create_inode
In gfs2_create_inode, after setting and releasing the acl / default_acl, the
acl / default_acl pointers are not set to NULL as they should be.  In that
state, when the function reaches label fail_free_acls, gfs2_create_inode will
try to release the same acls again.

Fix that by setting the pointers to NULL after releasing the acls.  Slightly
simplify the logic.  Also, posix_acl_release checks for NULL already, so
there is no need to duplicate those checks here.

Fixes: e01580bf9e ("gfs2: use generic posix ACL infrastructure")
Reported-by: Pan Bian <bianpan2016@163.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: stable@vger.kernel.org # v4.9+
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
Signed-off-by: Bob Peterson <rpeterso@redhat.com>
2018-12-11 21:44:29 +01:00
..
acl.c gfs2: using posix_acl_xattr_size instead of posix_acl_to_xattr 2018-07-24 20:02:11 +02:00
acl.h gfs2: Switch to generic xattr handlers 2016-05-12 22:28:05 -04:00
aops.c gfs2: Fix the gfs2_invalidatepage description 2018-12-11 17:50:35 +01:00
aops.h gfs2: iomap buffered write support 2018-07-02 16:27:17 +01:00
bmap.c gfs2: add more timing info to journal recovery process 2018-12-11 17:50:36 +01:00
bmap.h gfs2: Iomap cleanups and improvements 2018-06-04 07:56:51 -05:00
dentry.c gfs2: Lock holder cleanup 2016-06-27 09:47:09 -05:00
dir.c gfs2: Pass resource group to rgblk_free 2018-10-12 07:33:07 -05:00
dir.h GFS2: Make rename not save dirent location 2014-10-01 14:06:15 +01:00
export.c gfs2: Get rid of gfs2_ilookup 2016-06-27 09:47:08 -05:00
file.c gfs2: Move rs_{sizehint, rgd_gh} fields into the inode 2018-10-12 07:29:14 -05:00
gfs2.h
glock.c gfs2: Use fs_* functions instead of pr_* function where we can 2018-10-05 11:16:54 -05:00
glock.h gfs2: gfs2_evict_inode: Put glocks asynchronously 2017-08-10 10:45:21 -05:00
glops.c gfs2: read journal in large chunks to locate the head 2018-12-11 17:50:36 +01:00
glops.h GFS2: update freeze code to use freeze/thaw_super on all nodes 2014-11-17 10:36:39 +00:00
incore.h gfs2: Remove vestigial bd_ops 2018-12-11 21:43:58 +01:00
inode.c gfs2: Get rid of potential double-freeing in gfs2_create_inode 2018-12-11 21:44:29 +01:00
inode.h gfs2: Clean up gfs2_is_{ordered,writeback} 2018-12-11 17:50:35 +01:00
Kconfig gfs2: Fix the crc32c dependency 2018-02-01 11:25:31 -07:00
lock_dlm.c gfs2: Use fs_* functions instead of pr_* function where we can 2018-10-05 11:16:54 -05:00
log.c gfs2: Remove vestigial bd_ops 2018-12-11 21:43:58 +01:00
log.h gfs2: Clean up gfs2_is_{ordered,writeback} 2018-12-11 17:50:35 +01:00
lops.c gfs2: read journal in large chunks to locate the head 2018-12-11 17:50:36 +01:00
lops.h gfs2: read journal in large chunks to locate the head 2018-12-11 17:50:36 +01:00
main.c gfs2: Move rs_{sizehint, rgd_gh} fields into the inode 2018-10-12 07:29:14 -05:00
Makefile License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
meta_io.c gfs2: Don't withdraw under a spin lock 2018-06-21 07:39:44 -05:00
meta_io.h GFS2: Refactor gfs2_remove_from_journal 2016-05-06 11:27:27 -05:00
ops_fstype.c gfs2: read journal in large chunks to locate the head 2018-12-11 17:50:36 +01:00
quota.c gfs2: Fix some minor typos 2018-10-12 07:31:21 -05:00
quota.h gfs2: Fix fallocate chunk size 2018-03-08 09:26:20 -07:00
recovery.c gfs2: read journal in large chunks to locate the head 2018-12-11 17:50:36 +01:00
recovery.h gfs2: read journal in large chunks to locate the head 2018-12-11 17:50:36 +01:00
rgrp.c gfs2: Put bitmap buffers in put_super 2018-11-09 10:55:27 +00:00
rgrp.h gfs2: Pass resource group to rgblk_free 2018-10-12 07:33:07 -05:00
super.c gfs2: read journal in large chunks to locate the head 2018-12-11 17:50:36 +01:00
super.h GFS2: update freeze code to use freeze/thaw_super on all nodes 2014-11-17 10:36:39 +00:00
sys.c GFS2: Fix recovery issues for spectators 2018-07-25 00:06:24 +02:00
sys.h GFS2: dlm based recovery coordination 2012-01-11 09:23:05 +00:00
trace_gfs2.h gfs2: eliminate rs_inum and reduce the size of gfs2 inodes 2018-06-21 07:39:31 -05:00
trans.c gfs2: Remove vestigial bd_ops 2018-12-11 21:43:58 +01:00
trans.h gfs2: Eliminate redundant ip->i_rgd 2018-07-05 17:47:16 +02:00
util.c gfs2: slow the deluge of io error messages 2018-10-05 10:51:11 -05:00
util.h gfs2: Use fs_* functions instead of pr_* function where we can 2018-10-05 11:16:54 -05:00
xattr.c gfs2: Pass resource group to rgblk_free 2018-10-12 07:33:07 -05:00
xattr.h gfs2: Remove gfs2_xattr_acl_chmod 2015-12-06 21:25:17 -05:00