linux/fs/notify
Nathan Chancellor 6def1a1d2d fanotify: Fix the checks in fanotify_fsid_equal
Clang warns:

fs/notify/fanotify/fanotify.c:28:23: warning: self-comparison always
evaluates to true [-Wtautological-compare]
        return fsid1->val[0] == fsid1->val[0] && fsid2->val[1] == fsid2->val[1];
                             ^
fs/notify/fanotify/fanotify.c:28:57: warning: self-comparison always
evaluates to true [-Wtautological-compare]
        return fsid1->val[0] == fsid1->val[0] && fsid2->val[1] == fsid2->val[1];
                                                               ^
2 warnings generated.

The intention was clearly to compare val[0] and val[1] in the two
different fsid structs. Fix it otherwise this function always returns
true.

Fixes: afc894c784 ("fanotify: Store fanotify handles differently")
Link: https://github.com/ClangBuiltLinux/linux/issues/952
Link: https://lore.kernel.org/r/20200327171030.30625-1-natechancellor@gmail.com
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Jan Kara <jack@suse.cz>
2020-03-30 12:40:53 +02:00
..
dnotify
fanotify fanotify: Fix the checks in fanotify_fsid_equal 2020-03-30 12:40:53 +02:00
inotify fsnotify: replace inode pointer with an object id 2020-03-24 11:28:00 +01:00
fdinfo.c
fdinfo.h
fsnotify.c fanotify: send FAN_DIR_MODIFY event flavor with dir inode and name 2020-03-25 10:27:16 +01:00
fsnotify.h
group.c
Kconfig
Makefile
mark.c
notification.c