system/linux
system/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux synced 2024-11-05 18:23:50 +00:00
Code Issues Projects Releases Packages Wiki Activity
linux/net/mac80211
History
Luciano Coelho 6df653c71e mac80211: initialize sta pointer to avoid false-positive warning 
Some compilers (eg. gcc 4.4.1 for ARM) report a false positive warning
in mlme.c:

net/mac80211/mlme.c: In function 'ieee80211_prep_connection':
net/mac80211/mlme.c:3035: warning: 'sta' may be used uninitialized in this function

This is a false positive because the place where 'sta' is used is
inside an if with the same condition of where it is set:

[...]
        if (!have_sta) {
                sta = sta_info_alloc(sdata, cbss->bssid, GFP_KERNEL);
                if (!sta)
                        return -ENOMEM;
        }
[...]
        if (!have_sta) {
[...]
                sta->sta.supp_rates[cbss->channel->band] = rates;
[...]

For some reason the compiler doesn't understand this and warns.

While this is not a problem in the code itself, we can avoid polluting
the build logs with false positives by setting sta to NULL on
declaration and checking for sta instead of !have_sta in the second if.

Reported-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Luciano Coelho <coelho@ti.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2012-06-20 10:54:23 +02:00
..
aes_ccm.c mac80211: use AES_BLOCK_SIZE 2011-07-08 11:11:24 -04:00
aes_ccm.h mac80211: use AES_BLOCK_SIZE 2011-07-08 11:11:24 -04:00
aes_cmac.c mac80211: use AES_BLOCK_SIZE 2011-07-08 11:11:24 -04:00
aes_cmac.h mac80211: fix CMAC races 2011-07-08 11:11:20 -04:00
agg-rx.c Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless 2012-06-06 14:40:06 -04:00
agg-tx.c net: mac80211: Add and use ht_vdbg debugging macro 2012-06-05 15:32:10 -04:00
cfg.c mac80211: fix the assignment of mesh element TTL 2012-06-18 13:55:16 +02:00
cfg.h
chan.c mac80211: allow channel change while mesh is down 2012-06-05 15:21:47 -04:00
debugfs.c simple_open: automatically convert to simple_open() 2012-04-05 15:25:50 -07:00
debugfs.h simple_open: automatically convert to simple_open() 2012-04-05 15:25:50 -07:00
debugfs_key.c simple_open: automatically convert to simple_open() 2012-04-05 15:25:50 -07:00
debugfs_key.h
debugfs_netdev.c {nl,cfg,mac}80211: implement dot11MeshHWMPconfirmationInterval 2012-06-18 13:55:15 +02:00
debugfs_netdev.h
debugfs_sta.c Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless 2012-04-12 13:49:28 -04:00
debugfs_sta.h
driver-ops.h mac80211: Framework to get wifi-driver stats via ethtool. 2012-05-08 21:53:51 -04:00
driver-trace.c
driver-trace.h mac80211: Framework to get wifi-driver stats via ethtool. 2012-05-08 21:53:51 -04:00
event.c
ht.c net: Convert net_ratelimit uses to net_<level>_ratelimited 2012-05-15 13:45:03 -04:00
ibss.c cfg80211: simplify cfg80211_can_beacon_sec_chan API 2012-06-05 15:32:16 -04:00
ieee80211_i.h mac80211: set only VO as a U-APSD enabled AC 2012-06-18 19:18:54 +02:00
iface.c mac80211: unify SW/offload remain-on-channel 2012-06-06 15:31:18 -04:00
Kconfig mac80211: Implement mesh synchronization framework 2012-04-10 15:20:31 -04:00
key.c mac80211: clean up asm/unaligned.h inclusion 2012-02-27 14:06:32 -05:00
key.h mac80211: allow driver to disconnect after resume 2011-07-13 14:49:43 -04:00
led.c net: Add export.h for EXPORT_SYMBOL/THIS_MODULE to non-modules 2011-10-31 19:30:30 -04:00
led.h
main.c mac80211: stop Rx during HW reconfig 2012-06-18 19:18:53 +02:00
Makefile mac80211: unify SW/offload remain-on-channel 2012-06-06 15:31:18 -04:00
mesh.c mac80211: invoke the timer only with correct dot11MeshHWMPRootMode value 2012-06-18 13:55:14 +02:00
mesh.h {nl,cfg,mac}80211: implement dot11MeshHWMPconfirmationInterval 2012-06-18 13:55:15 +02:00
mesh_hwmp.c mac80211: fix and improve mesh RANN processing 2012-06-18 19:18:55 +02:00
mesh_pathtbl.c net: mac80211: Convert printk(KERN_DEBUG to pr_debug 2012-06-05 15:27:16 -04:00
mesh_plink.c net: mac80211: Convert printk(KERN_DEBUG to pr_debug 2012-06-05 15:27:16 -04:00
mesh_sync.c net: mac80211: Convert printk(KERN_DEBUG to pr_debug 2012-06-05 15:27:16 -04:00
michael.c
michael.h
mlme.c mac80211: initialize sta pointer to avoid false-positive warning 2012-06-20 10:54:23 +02:00
offchannel.c mac80211: cleanup offchannel_ps_enable argument 2012-06-20 10:53:34 +02:00
pm.c mac80211: Clear wowlan flag when drv_suspend returns failure 2012-06-06 15:20:22 -04:00
rate.c simple_open: automatically convert to simple_open() 2012-04-05 15:25:50 -07:00
rate.h mac80211: notify driver of rate control updates 2012-04-10 14:54:08 -04:00
rc80211_minstrel.c mac80211: remove hw.conf.channel usage where possible 2012-04-13 14:32:50 -04:00
rc80211_minstrel.h
rc80211_minstrel_debugfs.c net: Add export.h for EXPORT_SYMBOL/THIS_MODULE to non-modules 2011-10-31 19:30:30 -04:00
rc80211_minstrel_ht.c mac80211: remove hw.conf.channel usage where possible 2012-04-13 14:32:50 -04:00
rc80211_minstrel_ht.h
rc80211_minstrel_ht_debugfs.c net: Add export.h for EXPORT_SYMBOL/THIS_MODULE to non-modules 2011-10-31 19:30:30 -04:00
rc80211_pid.h
rc80211_pid_algo.c net: fix assignment of 0/1 to bool variables. 2011-12-19 22:27:29 -05:00
rc80211_pid_debugfs.c net: Add export.h for EXPORT_SYMBOL/THIS_MODULE to non-modules 2011-10-31 19:30:30 -04:00
rx.c mac80211: stop Rx during HW reconfig 2012-06-18 19:18:53 +02:00
scan.c mac80211: unify SW/offload remain-on-channel 2012-06-06 15:31:18 -04:00
spectmgmt.c mac80211: Remove unnecessary OOM logging messages 2011-09-13 15:45:02 -04:00
sta_info.c Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless 2012-06-06 14:40:06 -04:00
sta_info.h Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-next 2012-05-14 18:00:48 -04:00
status.c mac80211: unify SW/offload remain-on-channel 2012-06-06 15:31:18 -04:00
tkip.c net: mac80211: Convert printk(KERN_DEBUG to pr_debug 2012-06-05 15:27:16 -04:00
tkip.h
tx.c Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless 2012-06-06 14:40:06 -04:00
util.c mac80211: stop Rx during HW reconfig 2012-06-18 19:18:53 +02:00
wep.c mac80211: fix network header location when adding encryption headers 2012-05-16 12:47:43 -04:00
wep.h mac80211: move RX WEP weak IV counting 2012-03-13 14:54:16 -04:00
wme.c mac80211: use IEEE80211_NUM_ACS 2012-04-10 14:56:10 -04:00
wme.h mac80211: make ieee80211_downgrade_queue static 2012-04-10 14:54:06 -04:00
wpa.c mac80211: fix network header location when adding encryption headers 2012-05-16 12:47:43 -04:00
wpa.h mac80211: fix tx->skb NULL pointer dereference 2012-01-16 15:01:16 -05:00