linux/drivers/net/ixgbe
Jeff Kirsher 2d0bb1c1f4 e100/e1000*/igb*/ixgb*: Add missing read memory barrier
Based on patches from Sonny Rao and Milton Miller...

Combined the patches to fix up clean_tx_irq and clean_rx_irq.

The PowerPC architecture does not require loads to independent bytes
to be ordered without adding an explicit barrier.

In ixgbe_clean_rx_irq we load the status bit then load the packet data.
With packet split disabled if these loads go out of order we get a
stale packet, but we will notice the bad sequence numbers and drop it.

The problem occurs with packet split enabled where the TCP/IP header
and data are in different descriptors. If the reads go out of order
we may have data that doesn't match the TCP/IP header. Since we use
hardware checksumming this bad data is never verified and it makes it
all the way to the application.

This bug was found during stress testing and adding this barrier has
been shown to fix it.  The bug can manifest as a data integrity issue
(bad payload data) or as a BUG in skb_pull().

This was a nasty bug to hunt down, if people agree with the fix I think
it's a candidate for stable.

Previously Submitted to e1000-devel only for ixgbe

http://marc.info/?l=e1000-devel&m=126593062701537&w=3

We've now seen this problem hit with other device drivers (e1000e mostly)
So I'm resubmitting with fixes for other Intel Device Drivers with
similar issues.

CC: Milton Miller <miltonm@bga.com>
CC: Anton Blanchard <anton@samba.org>
CC: Sonny Rao <sonnyrao@us.ibm.com>
CC: stable <stable@kernel.org>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2010-08-08 20:02:45 -07:00
..
ixgbe.h ixgbe: update set_rx_mode to fix issues w/ macvlan 2010-06-15 14:23:35 -07:00
ixgbe_82598.c ixgbe:add support for a new 82599 10G Base-T device 2010-05-20 23:07:06 -07:00
ixgbe_82599.c ixgbe: use netif_<level> instead of netdev_<level> 2010-07-05 18:50:55 -07:00
ixgbe_common.c ixgbe: return IXGBE_ERR_RAR_INDEX when out of range 2010-06-03 03:28:28 -07:00
ixgbe_common.h ixgbe: use netif_<level> instead of netdev_<level> 2010-07-05 18:50:55 -07:00
ixgbe_dcb.c ixgbe: update copyright dates 2010-01-13 17:12:45 -08:00
ixgbe_dcb.h ixgbe: update copyright dates 2010-01-13 17:12:45 -08:00
ixgbe_dcb_82598.c ixgbe: update copyright dates 2010-01-13 17:12:45 -08:00
ixgbe_dcb_82598.h ixgbe: update copyright dates 2010-01-13 17:12:45 -08:00
ixgbe_dcb_82599.c ixgbe: dcb, set DPF bit when PFC is enabled 2010-07-19 20:23:36 -07:00
ixgbe_dcb_82599.h ixgbe: update copyright dates 2010-01-13 17:12:45 -08:00
ixgbe_dcb_nl.c ixgbe: use netif_<level> instead of netdev_<level> 2010-07-05 18:50:55 -07:00
ixgbe_ethtool.c ixgbe: fix ethtool stats 2010-07-24 20:43:19 -07:00
ixgbe_fcoe.c ixgbe: use GFP_ATOMIC when allocating FCoE DDP context from the dma pool 2010-07-19 20:23:37 -07:00
ixgbe_fcoe.h ixgbe: update copyright dates 2010-01-13 17:12:45 -08:00
ixgbe_main.c e100/e1000*/igb*/ixgb*: Add missing read memory barrier 2010-08-08 20:02:45 -07:00
ixgbe_mbx.c ixgbe: Mailbox header and code module 2010-01-10 13:34:24 -08:00
ixgbe_mbx.h ixgbe: Mailbox header and code module 2010-01-10 13:34:24 -08:00
ixgbe_phy.c ixgbe: add 1g PHY support for 82599 2010-06-30 14:27:40 -07:00
ixgbe_phy.h ixgbe: add 1g PHY support for 82599 2010-06-30 14:27:40 -07:00
ixgbe_sriov.c ixgbe: use netif_<level> instead of netdev_<level> 2010-07-05 18:50:55 -07:00
ixgbe_sriov.h ixgbe: Add support for VF MAC and VLAN configuration 2010-05-05 21:15:33 -07:00
ixgbe_type.h ixgbe: add 1g PHY support for 82599 2010-06-30 14:27:40 -07:00
Makefile Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6 2010-01-23 00:31:06 -08:00