mirror of
https://github.com/torvalds/linux
synced 2024-10-04 02:10:58 +00:00
7f5c5d20f0
This patch significantly cleans up and simplifies the data_update interface. Instead of only being able to specify a single pointer by device to rewrite, we're now able to specify any or all of the pointers in the original extent to be rewrited, as a bitmask. data_cmd is no more: the various pred functions now just return true if the extent should be moved/updated. All the data_update path does is rewrite existing replicas, or add new ones. This fixes a bug where with background compression on replicated filesystems, where rebalance -> data_update would incorrectly drop the wrong old replica, and keep trying to recompress an extent pointer and each time failing to drop the right replica. Oops. Now, the data update path doesn't look at the io options to decide which pointers to keep and which to drop - it only goes off of the data_update_options passed to it. Signed-off-by: Kent Overstreet <kent.overstreet@gmail.com>
40 lines
935 B
C
40 lines
935 B
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
|
|
#ifndef _BCACHEFS_DATA_UPDATE_H
|
|
#define _BCACHEFS_DATA_UPDATE_H
|
|
|
|
#include "bkey_buf.h"
|
|
#include "io_types.h"
|
|
|
|
struct moving_context;
|
|
|
|
struct data_update_opts {
|
|
unsigned rewrite_ptrs;
|
|
u16 target;
|
|
u8 extra_replicas;
|
|
unsigned btree_insert_flags;
|
|
unsigned write_flags;
|
|
};
|
|
|
|
struct data_update {
|
|
/* extent being updated: */
|
|
enum btree_id btree_id;
|
|
struct bkey_buf k;
|
|
struct data_update_opts data_opts;
|
|
struct moving_context *ctxt;
|
|
struct bch_write_op op;
|
|
};
|
|
|
|
int bch2_data_update_index_update(struct bch_write_op *);
|
|
|
|
void bch2_data_update_read_done(struct data_update *,
|
|
struct bch_extent_crc_unpacked);
|
|
|
|
void bch2_data_update_exit(struct data_update *);
|
|
int bch2_data_update_init(struct bch_fs *, struct data_update *,
|
|
struct write_point_specifier,
|
|
struct bch_io_opts, struct data_update_opts,
|
|
enum btree_id, struct bkey_s_c);
|
|
|
|
#endif /* _BCACHEFS_DATA_UPDATE_H */
|