system/linux
system/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux synced 2024-10-01 00:39:03 +00:00
Code Issues Packages Projects Releases Wiki Activity
linux/drivers/clk
History
Hans de Goede 6793b3cd5d clk_mux: Fix set_parent doing the wrong thing when INDEX_BIT && index >= 3 
If CLK_MUX_INDEX_BIT is set, then each bit turns on / off a single parent,
so theoretically multiple parents could be enabled at the same time, but in
practice only one bit should ever be 1. So to select parent 0, set
the register (*) to 0x01, to select parent 1 set it 0x02, parent 2, 0x04,
parent 3, 0x08, etc.

But the current code does:

                if (mux->flags & CLK_MUX_INDEX_BIT)
                        index = (1 << ffs(index));

Which means that:

For an input index of 0, ffs returns 0, so we set the register
to 0x01, ok.

For an input index of 1, ffs returns 1, so we set the register
to 0x02, ok.

For an input index of 2, ffs returns 2, so we set the register
to 0x04, ok.

For an input index of 3, ffs returns 1, so we set the register
to 0x02, not good!

The code should simply be:

                if (mux->flags & CLK_MUX_INDEX_BIT)
                        index = 1 << index;

Which always does the right thing, this commit fixes this.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Michael Turquette <mturquette@linaro.org>
2014-11-19 14:03:13 -08:00
..
at91 The clk tree changes for 3.18 are dominated by clock drivers. Mostly 2014-10-15 07:05:03 +02:00
bcm clk: bcm/kona: implement determine_rate() 2014-05-27 17:34:32 -07:00
berlin clk: berlin: add core clock driver for BG2Q 2014-05-29 09:30:19 -07:00
hisilicon clk: hix5hd2: add I2C clocks 2014-09-28 10:27:09 +08:00
keystone
mmp clk: mmp: add mmp2 DT support for clock driver 2014-11-12 16:34:22 -08:00
mvebu clock mvebu changes for v3.18 (round 2) 2014-10-03 16:43:02 -07:00
mxs
pxa clk: pxa: keep clocks initialization separated per variant 2014-11-17 11:27:45 -08:00
qcom qcom clock changes for 3.18 2014-09-26 16:10:57 -07:00
rockchip clk: rockchip: fix clock select order for rk3288 usbphy480m_src 2014-11-16 00:40:19 +01:00
samsung clk: samsung: exynos7: add gate clock for ADC block 2014-10-31 10:45:54 +01:00
shmobile clk: shmobile: div6: support selectable-input clocks 2014-11-12 14:24:08 +01:00
sirf
socfpga Adds support getting the divider registers for the MAIN PLL that was once 2014-05-12 19:11:13 -07:00
spear Merge branch 'clk-fixes' into clk-next 2014-07-13 07:56:45 -07:00
st clk: st: Use round to closest divider flag 2014-07-28 22:37:16 -07:00
sunxi Allwinner Clocks Additions for 3.18 2014-09-27 12:52:33 -07:00
tegra clk: tegra: Make clock initialization more robust 2014-09-18 14:56:53 +03:00
ti Merge branch 'for-v3.18/ti-clk-driver' of github.com:t-kristo/linux-pm into clk-next 2014-09-29 23:38:59 -07:00
ux500
versatile clk: versatile: add versatile OSC support 2014-06-24 14:21:22 -05:00
x86
zynq clk: zynq: Move const initdata into correct code section 2014-09-09 12:18:20 -07:00
clk-axi-clkgen.c clk: Remove .owner field for driver 2014-09-25 17:43:31 -07:00
clk-axm5516.c clk: Add clock driver for AXM55xx SoC 2014-05-22 22:06:14 -07:00
clk-bcm2835.c
clk-clps711x.c clk: Add CLPS711X clk driver 2014-07-28 23:30:46 -07:00
clk-composite.c clk: composite: improve rate_hw sanity check logic 2014-07-13 12:17:05 -07:00
clk-conf.c clk: Add missing of_clk_set_defaults export 2014-08-04 09:48:39 -07:00
clk-devres.c
clk-divider.c clk: divider: Fix overflow in clk_divider_bestdiv 2014-05-27 19:16:24 -07:00
clk-efm32gg.c clk/efm32gg: fix dt init prototype 2014-09-09 13:52:18 -07:00
clk-fixed-factor.c
clk-fixed-rate.c
clk-fractional-divider.c clk: fractional-divider: cast parent_rate to u64 before multiplying 2014-09-10 09:42:37 -07:00
clk-gate.c clk: use uninitialized_var instead setting 'flags' to 0 directly. 2014-09-27 16:03:06 -07:00
clk-gpio-gate.c clk: gpio-gate: Ensure gpiod_ APIs are prototyped 2014-09-30 11:57:54 -07:00
clk-highbank.c
clk-ls1x.c
clk-max-gen.c clk: Add generic driver for Maxim PMIC clocks 2014-09-09 13:55:44 -07:00
clk-max-gen.h clk: Add generic driver for Maxim PMIC clocks 2014-09-09 13:55:44 -07:00
clk-max77686.c clk: Remove .owner field for driver 2014-09-25 17:43:31 -07:00
clk-max77802.c clk: Remove .owner field for driver 2014-09-25 17:43:31 -07:00
clk-moxart.c
clk-mux.c clk_mux: Fix set_parent doing the wrong thing when INDEX_BIT && index >= 3 2014-11-19 14:03:13 -08:00
clk-nomadik.c
clk-nspire.c
clk-palmas.c clk: Remove .owner field for driver 2014-09-25 17:43:31 -07:00
clk-ppc-corenet.c clk: ppc-corenet: Fix Section mismatch warning 2014-07-01 20:11:22 -07:00
clk-rk808.c clk: RK808: add clkout driver for RK808 2014-10-14 02:18:18 +02:00
clk-s2mps11.c Merge branch 'clk-fixes' into clk-next 2014-07-03 11:55:42 -07:00
clk-si570.c clk: si570: Fix email address specifiction 2014-05-20 16:18:18 +02:00
clk-si5351.c
clk-si5351.h
clk-twl6040.c clk: Remove .owner field for driver 2014-09-25 17:43:31 -07:00
clk-u300.c clk: u300: Terminate of match table 2014-05-27 18:29:04 -07:00
clk-vt8500.c
clk-wm831x.c clk: Remove .owner field for driver 2014-09-25 17:43:31 -07:00
clk-xgene.c
clk.c clk: delete a local variable's repeated assignment 2014-11-19 11:41:18 -08:00
clk.h clk: Add of_clk_get_by_clkspec() helper 2014-05-22 15:54:59 -07:00
clkdev.c clkdev: Don't print errors on probe defer 2014-06-26 12:55:03 -07:00
Kconfig The clk tree changes for 3.18 are dominated by clock drivers. Mostly 2014-10-15 07:05:03 +02:00
Makefile The clk tree changes for 3.18 are dominated by clock drivers. Mostly 2014-10-15 07:05:03 +02:00