linux/net/ax25
David S. Miller 676d23690f net: Fix use after free by removing length arg from sk_data_ready callbacks.
Several spots in the kernel perform a sequence like:

	skb_queue_tail(&sk->s_receive_queue, skb);
	sk->sk_data_ready(sk, skb->len);

But at the moment we place the SKB onto the socket receive queue it
can be consumed and freed up.  So this skb->len access is potentially
to freed up memory.

Furthermore, the skb->len can be modified by the consumer so it is
possible that the value isn't accurate.

And finally, no actual implementation of this callback actually uses
the length argument.  And since nobody actually cared about it's
value, lots of call sites pass arbitrary values in such as '0' and
even '1'.

So just remove the length argument from the callback, that way there
is no confusion whatsoever and all of these use-after-free cases get
fixed as a side effect.

Based upon a patch by Eric Dumazet and his suggestion to audit this
issue tree-wide.

Signed-off-by: David S. Miller <davem@davemloft.net>
2014-04-11 16:15:36 -04:00
..
af_ax25.c net: add build-time checks for msg->msg_name size 2014-01-18 23:04:16 -08:00
ax25_addr.c small cleanup in ax25_addr_parse() 2012-07-09 00:16:16 -07:00
ax25_dev.c net ax25: Simplify and cleanup the ax25 sysctl handling. 2012-04-20 21:22:28 -04:00
ax25_ds_in.c Remove all #inclusions of asm/system.h 2012-03-28 18:30:03 +01:00
ax25_ds_subr.c hlist: drop the node parameter from iterators 2013-02-27 19:10:24 -08:00
ax25_ds_timer.c hlist: drop the node parameter from iterators 2013-02-27 19:10:24 -08:00
ax25_iface.c hlist: drop the node parameter from iterators 2013-02-27 19:10:24 -08:00
ax25_in.c net: Fix use after free by removing length arg from sk_data_ready callbacks. 2014-04-11 16:15:36 -04:00
ax25_ip.c net: cleanup unsigned to unsigned int 2012-04-15 12:44:40 -04:00
ax25_out.c net: use consume_skb() in place of kfree_skb() 2012-06-04 11:27:40 -04:00
ax25_route.c net: use consume_skb() in place of kfree_skb() 2012-06-04 11:27:40 -04:00
ax25_std_in.c Remove all #inclusions of asm/system.h 2012-03-28 18:30:03 +01:00
ax25_std_subr.c Remove all #inclusions of asm/system.h 2012-03-28 18:30:03 +01:00
ax25_std_timer.c Remove all #inclusions of asm/system.h 2012-03-28 18:30:03 +01:00
ax25_subr.c Remove all #inclusions of asm/system.h 2012-03-28 18:30:03 +01:00
ax25_timer.c Remove all #inclusions of asm/system.h 2012-03-28 18:30:03 +01:00
ax25_uid.c hlist: drop the node parameter from iterators 2013-02-27 19:10:24 -08:00
Kconfig Update broken web addresses in the kernel. 2010-10-18 11:03:14 +02:00
Makefile
sysctl_net_ax25.c net: Convert uses of typedef ctl_table to struct ctl_table 2013-06-13 02:36:09 -07:00
TODO