Magnus Karlsson 642e450b6b xsk: Do not discard packet when NETDEV_TX_BUSY ... In the skb Tx path, transmission of a packet is performed with dev_direct_xmit(). When NETDEV_TX_BUSY is set in the drivers, it signifies that it was not possible to send the packet right now, please try later. Unfortunately, the xsk transmit code discarded the packet and returned EBUSY to the application. Fix this unnecessary packet loss, by not discarding the packet in the Tx ring and return EAGAIN. As EAGAIN is returned to the application, it can then retry the send operation later and the packet will then likely be sent as the driver will then likely have space/resources to send the packet. In summary, EAGAIN tells the application that the packet was not discarded from the Tx ring and that it needs to call send() again. EBUSY, on the other hand, signifies that the packet was not sent and discarded from the Tx ring. The application needs to put the packet on the Tx ring again if it wants it to be sent. Fixes: 35fcde7f8d ("xsk: support for Tx") Reported-by: Arkadiusz Zema <A.Zema@falconvsystems.com> Suggested-by: Arkadiusz Zema <A.Zema@falconvsystems.com> Suggested-by: Daniel Borkmann <daniel@iogearbox.net> Signed-off-by: Magnus Karlsson <magnus.karlsson@intel.com> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net> Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com> Link: https://lore.kernel.org/bpf/1600257625-2353-1-git-send-email-magnus.karlsson@gmail.com		2020-09-16 23:36:58 +02:00
..
6lowpan	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
9p	treewide: Use fallthrough pseudo-keyword	2020-08-23 17:36:59 -05:00
802
8021q	treewide: Use fallthrough pseudo-keyword	2020-08-23 17:36:59 -05:00
appletalk	appletalk: Fix atalk_proc_init() return path	2020-08-03 15:48:32 -07:00
atm	treewide: Use fallthrough pseudo-keyword	2020-08-23 17:36:59 -05:00
ax25	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2020-07-25 17:49:04 -07:00
batman-adv	batman-adv: bla: use netif_rx_ni when not in interrupt context	2020-08-18 19:40:03 +02:00
bluetooth	mm, treewide: rename kzfree() to kfree_sensitive()	2020-08-07 11:33:22 -07:00
bpf	treewide: Use fallthrough pseudo-keyword	2020-08-23 17:36:59 -05:00
bpfilter	Merge branch 'exec-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace	2020-08-04 14:27:25 -07:00
bridge	netfilter: ebtables: reject bogus getopt len value	2020-08-14 11:59:08 +02:00
caif	net: caif: fix error code handling	2020-08-25 07:50:25 -07:00
can	treewide: Use fallthrough pseudo-keyword	2020-08-23 17:36:59 -05:00
ceph	treewide: Use fallthrough pseudo-keyword	2020-08-23 17:36:59 -05:00
core	Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf	2020-09-15 19:26:21 -07:00
dcb	net: DCB: Validate DCB_ATTR_DCB_BUFFER argument	2020-09-10 15:09:08 -07:00
dccp	treewide: Use fallthrough pseudo-keyword	2020-08-23 17:36:59 -05:00
decnet	treewide: Use fallthrough pseudo-keyword	2020-08-23 17:36:59 -05:00
dns_resolver	docs: networking: convert dns_resolver.txt to ReST	2020-04-28 14:39:46 -07:00
dsa	net: dsa: link interfaces with the DSA master to get rid of lockdep warnings	2020-09-08 19:40:09 -07:00
ethernet	net: move devres helpers into a separate source file	2020-05-23 16:56:17 -07:00
ethtool	ethtool: Don't omit the netlink reply if no features were changed	2020-08-18 16:00:24 -07:00
hsr	hsr: avoid newline at end of message in NL_SET_ERR_MSG_MOD	2020-09-09 11:15:26 -07:00
ieee802154	treewide: Use fallthrough pseudo-keyword	2020-08-23 17:36:59 -05:00
ife
ipv4	ipv4: Update exception handling for multipath routes via same device	2020-09-15 15:44:09 -07:00
ipv6	ipv6: avoid lockdep issue in fib6_del()	2020-09-08 19:56:25 -07:00
iucv	treewide: Use fallthrough pseudo-keyword	2020-08-23 17:36:59 -05:00
kcm	net: pass a sockptr_t into ->setsockopt	2020-07-24 15:41:54 -07:00
key	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2020-08-02 01:02:12 -07:00
l2tp	l2tp: improve API documentation in l2tp_core.h	2020-07-30 16:45:31 -07:00
l3mdev	net: Fix some comments	2020-08-27 07:55:59 -07:00
lapb	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
llc	net: pass a sockptr_t into ->setsockopt	2020-07-24 15:41:54 -07:00
mac80211	mac80211: reduce packet loss event false positives	2020-08-27 10:53:20 +02:00
mac802154	Merge tag 'ieee802154-for-davem-2020-09-08' of git://git.kernel.org/pub/scm/linux/kernel/git/sschmidt/wpan	2020-09-08 20:12:58 -07:00
mpls	treewide: Use fallthrough pseudo-keyword	2020-08-23 17:36:59 -05:00
mptcp	mptcp: fix kmalloc flag in mptcp_pm_nl_get_local_id	2020-09-10 12:30:03 -07:00
ncsi	treewide: Use fallthrough pseudo-keyword	2020-08-23 17:36:59 -05:00
netfilter	netfilter: nft_meta: use socket user_ns to retrieve skuid and skgid	2020-09-08 13:04:56 +02:00
netlabel	netlabel: fix problems with mapping removal	2020-08-24 16:08:00 -07:00
netlink	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2020-09-03 18:50:48 -07:00
netrom	treewide: Use fallthrough pseudo-keyword	2020-08-23 17:36:59 -05:00
nfc	net/nfc/rawsock.c: add CAP_NET_RAW check.	2020-08-11 10:34:30 -07:00
nsh	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
openvswitch	treewide: Use fallthrough pseudo-keyword	2020-08-23 17:36:59 -05:00
packet	net/packet: fix overflow in tpacket_rcv	2020-09-04 11:56:02 -07:00
phonet	treewide: Use fallthrough pseudo-keyword	2020-08-23 17:36:59 -05:00
psample	net: psample: fix build error when CONFIG_INET is not enabled	2020-05-23 16:36:05 -07:00
qrtr	net: qrtr: check skb_put_padto() return value	2020-09-09 11:04:39 -07:00
rds	treewide: Use fallthrough pseudo-keyword	2020-08-23 17:36:59 -05:00
rfkill
rose	treewide: Use fallthrough pseudo-keyword	2020-08-23 17:36:59 -05:00
rxrpc	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2020-09-03 18:50:48 -07:00
sched	net: sched: initialize with 0 before setting erspan md->u	2020-09-14 16:53:38 -07:00
sctp	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2020-09-03 18:50:48 -07:00
smc	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2020-09-03 18:50:48 -07:00
strparser
sunrpc	Fixes:	2020-08-25 18:01:36 -07:00
switchdev	net: switchdev: kerneldoc fixes	2020-07-13 17:20:40 -07:00
tipc	net: tipc: kerneldoc fixes	2020-09-15 13:33:04 -07:00
tls	net/tls: Fix kmap usage	2020-08-11 10:20:34 -07:00
unix	treewide: Use fallthrough pseudo-keyword	2020-08-23 17:36:59 -05:00
vmw_vsock	vsock: fix potential null pointer dereference in vsock_poll()	2020-08-12 12:56:06 -07:00
wimax
wireless	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2020-09-03 18:50:48 -07:00
x25	treewide: Use fallthrough pseudo-keyword	2020-08-23 17:36:59 -05:00
xdp	xsk: Do not discard packet when NETDEV_TX_BUSY	2020-09-16 23:36:58 +02:00
xfrm	treewide: Use fallthrough pseudo-keyword	2020-08-23 17:36:59 -05:00
compat.c	net/scm: Fix typo in SCM_RIGHTS compat refactoring	2020-08-07 12:43:25 -07:00
devres.c	net: devres: rename the release callback of devm_register_netdev()	2020-06-30 15:57:34 -07:00
Kconfig	net: ethtool: Remove PHYLIB direct dependency	2020-07-07 15:41:05 -07:00
Makefile	net: move devres helpers into a separate source file	2020-05-23 16:56:17 -07:00
socket.c	net: Fix some comments	2020-08-27 07:55:59 -07:00
sysctl_net.c