linux/drivers/dma/sh
Lad Prabhakar 62b68a8879 dmaengine: usb-dmac: Avoid format-overflow warning
gcc points out that the fix-byte buffer might be too small:
drivers/dma/sh/usb-dmac.c: In function 'usb_dmac_probe':
drivers/dma/sh/usb-dmac.c:720:34: warning: '%u' directive writing between 1 and 10 bytes into a region of size 3 [-Wformat-overflow=]
  720 |         sprintf(pdev_irqname, "ch%u", index);
      |                                  ^~
In function 'usb_dmac_chan_probe',
    inlined from 'usb_dmac_probe' at drivers/dma/sh/usb-dmac.c:814:9:
drivers/dma/sh/usb-dmac.c:720:31: note: directive argument in the range [0, 4294967294]
  720 |         sprintf(pdev_irqname, "ch%u", index);
      |                               ^~~~~~
drivers/dma/sh/usb-dmac.c:720:9: note: 'sprintf' output between 4 and 13 bytes into a destination of size 5
  720 |         sprintf(pdev_irqname, "ch%u", index);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Maximum number of channels for USB-DMAC as per the driver is 1-99 so use
u8 instead of unsigned int/int for DMAC channel indexing and make the
pdev_irqname string long enough to avoid the warning.

While at it use scnprintf() instead of sprintf() to make the code more
robust.

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20240110222210.193479-1-prabhakar.mahadev-lad.rj@bp.renesas.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
2024-01-19 17:41:03 +05:30
..
Kconfig dmaengine: sh: Kconfig: Make RZ_DMAC depend on ARCH_RZG2L 2022-04-08 23:22:00 +05:30
Makefile dmaengine: sh: Add DMAC driver for RZ/G2L SoC 2021-08-29 19:14:19 +05:30
rcar-dmac.c dmaengine: sh: rcar-dmac: Convert to platform remove callback returning void 2023-09-28 13:10:54 +05:30
rz-dmac.c dmaengine: sh: rz-dmac: Avoid format-overflow warning 2024-01-19 17:07:58 +05:30
shdma-base.c dmaengine: remove MODULE_LICENSE in non-modules 2023-04-13 13:13:51 -07:00
shdma.h dmaengine: sh: Remove R-Mobile APE6 support 2018-12-05 13:01:54 +05:30
shdmac.c dmaengine: sh: shdmac: Convert to platform remove callback returning void 2023-09-28 13:10:54 +05:30
usb-dmac.c dmaengine: usb-dmac: Avoid format-overflow warning 2024-01-19 17:41:03 +05:30