mirror of
https://github.com/torvalds/linux
synced 2024-11-05 18:23:50 +00:00
9b9ae16a97
The legacy S3C-DMA API required every period of a cyclic buffer to be
queued separately. After conversion of Samsung ASoC to Samsung DMA
wrappers somebody made an assumption that the same is needed for DMA
engine API, which is not true.
In effect, Samsung ASoC DMA code was queuing the whole cyclic buffer
multiple times with a shift of one period per iteration, leading to:
a) severe memory waste - up to 13x times more DMA transfer descriptors
are allocated than needed,
b) possible memory corruption, because further cyclic buffers were out
of the original buffers, due to the offset.
This patch fixes this problem by making the legacy S3C-DMA API use the
same semantics as DMA engine (the whole cyclic buffer is enqueued at
once) and modifying users of Samsung DMA wrappers in cyclic mode to
behave appropriately.
Signed-off-by: Tomasz Figa <tomasz.figa@gmail.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Mark Brown <broonie@linaro.org>
146 lines
3.1 KiB
C
146 lines
3.1 KiB
C
/* linux/arch/arm/plat-samsung/s3c-dma-ops.c
|
|
*
|
|
* Copyright (c) 2011 Samsung Electronics Co., Ltd.
|
|
* http://www.samsung.com
|
|
*
|
|
* Samsung S3C-DMA Operations
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License version 2 as
|
|
* published by the Free Software Foundation.
|
|
*/
|
|
|
|
#include <linux/kernel.h>
|
|
#include <linux/errno.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/types.h>
|
|
#include <linux/export.h>
|
|
|
|
#include <mach/dma.h>
|
|
|
|
struct cb_data {
|
|
void (*fp) (void *);
|
|
void *fp_param;
|
|
unsigned ch;
|
|
struct list_head node;
|
|
};
|
|
|
|
static LIST_HEAD(dma_list);
|
|
|
|
static void s3c_dma_cb(struct s3c2410_dma_chan *channel, void *param,
|
|
int size, enum s3c2410_dma_buffresult res)
|
|
{
|
|
struct cb_data *data = param;
|
|
|
|
data->fp(data->fp_param);
|
|
}
|
|
|
|
static unsigned s3c_dma_request(enum dma_ch dma_ch,
|
|
struct samsung_dma_req *param,
|
|
struct device *dev, char *ch_name)
|
|
{
|
|
struct cb_data *data;
|
|
|
|
if (s3c2410_dma_request(dma_ch, param->client, NULL) < 0) {
|
|
s3c2410_dma_free(dma_ch, param->client);
|
|
return 0;
|
|
}
|
|
|
|
if (param->cap == DMA_CYCLIC)
|
|
s3c2410_dma_setflags(dma_ch, S3C2410_DMAF_CIRCULAR);
|
|
|
|
data = kzalloc(sizeof(struct cb_data), GFP_KERNEL);
|
|
data->ch = dma_ch;
|
|
list_add_tail(&data->node, &dma_list);
|
|
|
|
return (unsigned)dma_ch;
|
|
}
|
|
|
|
static int s3c_dma_release(unsigned ch, void *param)
|
|
{
|
|
struct cb_data *data;
|
|
|
|
list_for_each_entry(data, &dma_list, node)
|
|
if (data->ch == ch)
|
|
break;
|
|
list_del(&data->node);
|
|
|
|
s3c2410_dma_free(ch, param);
|
|
kfree(data);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int s3c_dma_config(unsigned ch, struct samsung_dma_config *param)
|
|
{
|
|
s3c2410_dma_devconfig(ch, param->direction, param->fifo);
|
|
s3c2410_dma_config(ch, param->width);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int s3c_dma_prepare(unsigned ch, struct samsung_dma_prep *param)
|
|
{
|
|
struct cb_data *data;
|
|
dma_addr_t pos = param->buf;
|
|
dma_addr_t end = param->buf + param->len;
|
|
|
|
list_for_each_entry(data, &dma_list, node)
|
|
if (data->ch == ch)
|
|
break;
|
|
|
|
if (!data->fp) {
|
|
s3c2410_dma_set_buffdone_fn(ch, s3c_dma_cb);
|
|
data->fp = param->fp;
|
|
data->fp_param = param->fp_param;
|
|
}
|
|
|
|
if (param->cap != DMA_CYCLIC) {
|
|
s3c2410_dma_enqueue(ch, (void *)data, param->buf, param->len);
|
|
return 0;
|
|
}
|
|
|
|
while (pos < end) {
|
|
s3c2410_dma_enqueue(ch, (void *)data, pos, param->period);
|
|
pos += param->period;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static inline int s3c_dma_trigger(unsigned ch)
|
|
{
|
|
return s3c2410_dma_ctrl(ch, S3C2410_DMAOP_START);
|
|
}
|
|
|
|
static inline int s3c_dma_started(unsigned ch)
|
|
{
|
|
return s3c2410_dma_ctrl(ch, S3C2410_DMAOP_STARTED);
|
|
}
|
|
|
|
static inline int s3c_dma_flush(unsigned ch)
|
|
{
|
|
return s3c2410_dma_ctrl(ch, S3C2410_DMAOP_FLUSH);
|
|
}
|
|
|
|
static inline int s3c_dma_stop(unsigned ch)
|
|
{
|
|
return s3c2410_dma_ctrl(ch, S3C2410_DMAOP_STOP);
|
|
}
|
|
|
|
static struct samsung_dma_ops s3c_dma_ops = {
|
|
.request = s3c_dma_request,
|
|
.release = s3c_dma_release,
|
|
.config = s3c_dma_config,
|
|
.prepare = s3c_dma_prepare,
|
|
.trigger = s3c_dma_trigger,
|
|
.started = s3c_dma_started,
|
|
.flush = s3c_dma_flush,
|
|
.stop = s3c_dma_stop,
|
|
};
|
|
|
|
void *s3c_dma_get_ops(void)
|
|
{
|
|
return &s3c_dma_ops;
|
|
}
|
|
EXPORT_SYMBOL(s3c_dma_get_ops);
|