linux/net/nfc/hci
Johannes Berg 59ae1d127a networking: introduce and use skb_put_data()
A common pattern with skb_put() is to just want to memcpy()
some data into the new space, introduce skb_put_data() for
this.

An spatch similar to the one for skb_put_zero() converts many
of the places using it:

    @@
    identifier p, p2;
    expression len, skb, data;
    type t, t2;
    @@
    (
    -p = skb_put(skb, len);
    +p = skb_put_data(skb, data, len);
    |
    -p = (t)skb_put(skb, len);
    +p = skb_put_data(skb, data, len);
    )
    (
    p2 = (t2)p;
    -memcpy(p2, data, len);
    |
    -memcpy(p, data, len);
    )

    @@
    type t, t2;
    identifier p, p2;
    expression skb, data;
    @@
    t *p;
    ...
    (
    -p = skb_put(skb, sizeof(t));
    +p = skb_put_data(skb, data, sizeof(t));
    |
    -p = (t *)skb_put(skb, sizeof(t));
    +p = skb_put_data(skb, data, sizeof(t));
    )
    (
    p2 = (t2)p;
    -memcpy(p2, data, sizeof(*p));
    |
    -memcpy(p, data, sizeof(*p));
    )

    @@
    expression skb, len, data;
    @@
    -memcpy(skb_put(skb, len), data, len);
    +skb_put_data(skb, data, len);

(again, manually post-processed to retain some comments)

Reviewed-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2017-06-16 11:48:37 -04:00
..
command.c NFC: hci: Change nfc_hci_send_response gate parameter to pipe 2015-01-27 23:55:20 +01:00
core.c networking: introduce and use skb_put_data() 2017-06-16 11:48:37 -04:00
hci.h NFC: hci: Remove nfc_hci_pipe2gate function 2015-01-28 00:03:36 +01:00
hcp.c NFC: hci: Remove nfc_hci_pipe2gate function 2015-01-28 00:03:36 +01:00
Kconfig NFC: Select CRC_CCITT for SHDLC link layer of HCI based drivers 2012-05-15 17:27:28 -04:00
llc.c NFC: hci: delete unused nfc_llc_get_rx_head_tail_room() 2016-07-04 12:14:05 +02:00
llc.h nfc: Fix FSF address in file headers 2013-12-11 10:56:21 -05:00
llc_nop.c nfc: Fix FSF address in file headers 2013-12-11 10:56:21 -05:00
llc_shdlc.c net: Spelling s/transmition/transmission/ 2014-01-14 17:11:26 -08:00
Makefile NFC: Changed HCI and PN544 HCI driver to use the new HCI LLC Core 2012-09-25 00:17:26 +02:00