linux/drivers/net/bonding
Alexey Dobriyan 99b7623380 proc 2/2: remove struct proc_dir_entry::owner
Setting ->owner as done currently (pde->owner = THIS_MODULE) is racy
as correctly noted at bug #12454. Someone can lookup entry with NULL
->owner, thus not pinning enything, and release it later resulting
in module refcount underflow.

We can keep ->owner and supply it at registration time like ->proc_fops
and ->data.

But this leaves ->owner as easy-manipulative field (just one C assignment)
and somebody will forget to unpin previous/pin current module when
switching ->owner. ->proc_fops is declared as "const" which should give
some thoughts.

->read_proc/->write_proc were just fixed to not require ->owner for
protection.

rmmod'ed directories will be empty and return "." and ".." -- no harm.
And directories with tricky enough readdir and lookup shouldn't be modular.
We definitely don't want such modular code.

Removing ->owner will also make PDE smaller.

So, let's nuke it.

Kudos to Jeff Layton for reminding about this, let's say, oversight.

http://bugzilla.kernel.org/show_bug.cgi?id=12454

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
2009-03-31 01:14:44 +04:00
..
bond_3ad.c 802.3ad: use standard ethhdr instead of ad_header 2008-12-26 13:41:53 -08:00
bond_3ad.h net: replace uses of __constant_{endian} 2009-02-01 00:45:17 -08:00
bond_alb.c drivers/net/bonding: fix sparse warnings: context imbalance 2009-02-17 17:26:08 -08:00
bond_alb.h Convert bonding timers to workqueues 2007-10-23 20:32:00 -04:00
bond_ipv6.c bonding: use pr_debug instead of own macros 2008-12-09 23:09:22 -08:00
bond_main.c proc 2/2: remove struct proc_dir_entry::owner 2009-03-31 01:14:44 +04:00
bond_sysfs.c drivers/net/bonding: fix sparse warnings: move decls to header file 2008-12-25 23:58:57 -08:00
bonding.h drivers/net/bonding: fix sparse warnings: move decls to header file 2008-12-25 23:58:57 -08:00
Makefile bonding: send IPv6 neighbor advertisement on failover 2008-11-06 00:49:37 -05:00