mirror of
https://github.com/torvalds/linux
synced 2024-10-07 20:05:15 +00:00
982fe2e093
dw_mci_pltfm_remove() returned zero unconditionally. Make it return void instead which makes its semantics a bit clearer. Convert the drivers that use this function as .remove() callback to .remove_new() which has the right prototype. This helps getting rid of the platform_driver's remove callback that returns an int (which is error prone). The other users didn't check the return value anyhow. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20230505221506.1247424-1-u.kleine-koenig@pengutronix.de Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
69 lines
1.9 KiB
C
69 lines
1.9 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* Copyright (C) 2018 Mellanox Technologies.
|
|
*/
|
|
|
|
#include <linux/bitfield.h>
|
|
#include <linux/bitops.h>
|
|
#include <linux/mmc/host.h>
|
|
#include <linux/mmc/mmc.h>
|
|
#include <linux/module.h>
|
|
#include <linux/of.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/pm_runtime.h>
|
|
|
|
#include "dw_mmc.h"
|
|
#include "dw_mmc-pltfm.h"
|
|
|
|
#define UHS_REG_EXT_SAMPLE_MASK GENMASK(22, 16)
|
|
#define UHS_REG_EXT_DRIVE_MASK GENMASK(29, 23)
|
|
#define BLUEFIELD_UHS_REG_EXT_SAMPLE 2
|
|
#define BLUEFIELD_UHS_REG_EXT_DRIVE 4
|
|
|
|
static void dw_mci_bluefield_set_ios(struct dw_mci *host, struct mmc_ios *ios)
|
|
{
|
|
u32 reg;
|
|
|
|
/* Update the Drive and Sample fields in register UHS_REG_EXT. */
|
|
reg = mci_readl(host, UHS_REG_EXT);
|
|
reg &= ~UHS_REG_EXT_SAMPLE_MASK;
|
|
reg |= FIELD_PREP(UHS_REG_EXT_SAMPLE_MASK,
|
|
BLUEFIELD_UHS_REG_EXT_SAMPLE);
|
|
reg &= ~UHS_REG_EXT_DRIVE_MASK;
|
|
reg |= FIELD_PREP(UHS_REG_EXT_DRIVE_MASK, BLUEFIELD_UHS_REG_EXT_DRIVE);
|
|
mci_writel(host, UHS_REG_EXT, reg);
|
|
}
|
|
|
|
static const struct dw_mci_drv_data bluefield_drv_data = {
|
|
.set_ios = dw_mci_bluefield_set_ios
|
|
};
|
|
|
|
static const struct of_device_id dw_mci_bluefield_match[] = {
|
|
{ .compatible = "mellanox,bluefield-dw-mshc",
|
|
.data = &bluefield_drv_data },
|
|
{},
|
|
};
|
|
MODULE_DEVICE_TABLE(of, dw_mci_bluefield_match);
|
|
|
|
static int dw_mci_bluefield_probe(struct platform_device *pdev)
|
|
{
|
|
return dw_mci_pltfm_register(pdev, &bluefield_drv_data);
|
|
}
|
|
|
|
static struct platform_driver dw_mci_bluefield_pltfm_driver = {
|
|
.probe = dw_mci_bluefield_probe,
|
|
.remove_new = dw_mci_pltfm_remove,
|
|
.driver = {
|
|
.name = "dwmmc_bluefield",
|
|
.probe_type = PROBE_PREFER_ASYNCHRONOUS,
|
|
.of_match_table = dw_mci_bluefield_match,
|
|
.pm = &dw_mci_pltfm_pmops,
|
|
},
|
|
};
|
|
|
|
module_platform_driver(dw_mci_bluefield_pltfm_driver);
|
|
|
|
MODULE_DESCRIPTION("BlueField DW Multimedia Card driver");
|
|
MODULE_AUTHOR("Mellanox Technologies");
|
|
MODULE_LICENSE("GPL v2");
|